Overview
| Comment: | invoke-x86_64.m: Correctly align __int128 for GCC
GCC correctly aligns __int128 with 16 bytes on the stack, like specified Unfortunately, this means that GCC and Clang have a different ABI and |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | trunk |
| Files: | files | file ages | folders |
| SHA3-256: |
c14dfdc8e567d05ddf7777a024f5f85b |
| User & Date: | js on 2017-09-16 20:20:35 |
| Other Links: | manifest | tags |
Context
|
2017-09-16
| ||
| 20:37 | OFInvocationTests: Slightly change __int128 test check-in: c2941ac553 user: js tags: trunk | |
| 20:20 | invoke-x86_64.m: Correctly align __int128 for GCC check-in: c14dfdc8e5 user: js tags: trunk | |
| 20:05 | invoke-x86_64.m: Fix compilation with GCC check-in: 2379608969 user: js tags: trunk | |
Changes
Modified src/invocation/invoke-x86_64.m from [03bcbc3b9d] to [1d2004b374].
| ︙ | ︙ | |||
109 110 111 112 113 114 115 116 117 118 119 120 121 122 |
}
memcpy(&newContext->stack[newContext->stack_size], &value, 16);
newContext->stack_size += 2;
*context = newContext;
}
void
of_invocation_invoke(OFInvocation *invocation)
{
OFMethodSignature *methodSignature = [invocation methodSignature];
size_t numberOfArguments = [methodSignature numberOfArguments];
struct call_context *context;
const char *typeEncoding;
| > > > > > > > > > > > > > > > > > > > > > > > > > > | 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 |
}
memcpy(&newContext->stack[newContext->stack_size], &value, 16);
newContext->stack_size += 2;
*context = newContext;
}
#ifndef __clang__
static void
alignStack(struct call_context **context, size_t alignment)
{
size_t stackSize = (*context)->stack_size;
struct call_context *newContext;
if (stackSize % alignment == 0)
return;
stackSize += alignment - stackSize % alignment;
if ((newContext = realloc(*context,
sizeof(**context) + stackSize * 8)) == NULL) {
free(*context);
@throw [OFOutOfMemoryException exceptionWithRequestedSize:
sizeof(**context) + stackSize * 8];
}
memset(&newContext->stack[newContext->stack_size], '\0',
(stackSize - newContext->stack_size) * 8);
newContext->stack_size = stackSize;
*context = newContext;
}
#endif
void
of_invocation_invoke(OFInvocation *invocation)
{
OFMethodSignature *methodSignature = [invocation methodSignature];
size_t numberOfArguments = [methodSignature numberOfArguments];
struct call_context *context;
const char *typeEncoding;
|
| ︙ | ︙ | |||
153 154 155 156 157 158 159 160 161 162 163 164 165 166 |
CASE_GPR('Q', unsigned long long)
#ifdef __SIZEOF_INT128__
case 't':
case 'T':;
uint64_t int128Tmp[2];
[invocation getArgument: int128Tmp
atIndex: i];
pushGPR(&context, ¤tGPR, int128Tmp[0]);
pushGPR(&context, ¤tGPR, int128Tmp[1]);
break;
#endif
case 'f':;
float floatTmp;
[invocation getArgument: &floatTmp
| > > > > > > > | 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 |
CASE_GPR('Q', unsigned long long)
#ifdef __SIZEOF_INT128__
case 't':
case 'T':;
uint64_t int128Tmp[2];
[invocation getArgument: int128Tmp
atIndex: i];
# ifndef __clang__
/*
* Clang violates the x86_64 ABI and does not properly
* align __int128 on the stack.
*/
alignStack(&context, 2);
# endif
pushGPR(&context, ¤tGPR, int128Tmp[0]);
pushGPR(&context, ¤tGPR, int128Tmp[1]);
break;
#endif
case 'f':;
float floatTmp;
[invocation getArgument: &floatTmp
|
| ︙ | ︙ |