ObjFW  Check-in [a7b6d69e14]

Overview
Comment:Fix wrong order of retain / release.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: a7b6d69e14082d39d6439c0d232a665118f6b3751f6d4afb3ae26af4382ce3c8
User & Date: js on 2009-07-21 16:08:12
Other Links: manifest | tags
Context
2009-07-21
23:25
Add -[readLineWithEncoding:] to read in the specified encoding. check-in: 9d93300b4e user: js tags: trunk
16:08
Fix wrong order of retain / release. check-in: a7b6d69e14 user: js tags: trunk
2009-07-20
23:20
Add support for C strings encoded in Windows-1252. check-in: e04c359780 user: js tags: trunk
Changes

Modified src/OFExceptions.m from [6da0c73362] to [59e1e06f15].

338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
	   path: (OFString*)path_
	   mode: (OFString*)mode_
{
	self = [super initWithClass: class_];

	path = [path_ retain];
	mode = [mode_ retain];
	err = GET_ERR;

	return self;
}

- (void)dealloc
{
	[path release];







|







338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
	   path: (OFString*)path_
	   mode: (OFString*)mode_
{
	self = [super initWithClass: class_];

	path = [path_ retain];
	mode = [mode_ retain];
	err  = GET_ERR;

	return self;
}

- (void)dealloc
{
	[path release];
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574

- initWithClass: (Class)class_
	   node: (OFString*)node_
	service: (OFString*)service_
{
	self = [super initWithClass: class_];

	node = [node_ retain];
	service = [service_ retain];
	err = GET_AT_ERR;

	return self;
}

- (void)dealloc
{
	[node release];







|

|







558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574

- initWithClass: (Class)class_
	   node: (OFString*)node_
	service: (OFString*)service_
{
	self = [super initWithClass: class_];

	node	= [node_ retain];
	service = [service_ retain];
	err	= GET_AT_ERR;

	return self;
}

- (void)dealloc
{
	[node release];

Modified src/OFMutableDictionary.m from [43575dd54b] to [48a81d9fea].

34
35
36
37
38
39
40

41
42
43
44
45
46
47
48
49
	if (data[hash] == nil)
		data[hash] = [[OFList alloc] initWithListObjectSize:
		    sizeof(of_dictionary_list_object_t)];

	for (iter = (of_dictionary_list_object_t*)[data[hash] first];
	    iter != NULL; iter = iter->next) {
		if ([iter->key isEqual: key]) {

			[iter->object release];
			iter->object = [obj retain];

			return self;
		}
	}

	key = [key copy];








>

|







34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
	if (data[hash] == nil)
		data[hash] = [[OFList alloc] initWithListObjectSize:
		    sizeof(of_dictionary_list_object_t)];

	for (iter = (of_dictionary_list_object_t*)[data[hash] first];
	    iter != NULL; iter = iter->next) {
		if ([iter->key isEqual: key]) {
			[obj retain];
			[iter->object release];
			iter->object = obj;

			return self;
		}
	}

	key = [key copy];

Modified src/OFXMLParser.m from [8b1f567d63] to [ee7d38a3f9].

105
106
107
108
109
110
111

112
113
114
115
116
117
118
119
120
- (id)delegate
{
	return [[delegate retain] autorelease];
}

- setDelegate: (OFObject <OFXMLParserDelegate>*)delegate_
{

	[delegate release];
	delegate = [delegate_ retain];

	return self;
}

- parseBuffer: (const char*)buf
     withSize: (size_t)size
{







>

|







105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
- (id)delegate
{
	return [[delegate retain] autorelease];
}

- setDelegate: (OFObject <OFXMLParserDelegate>*)delegate_
{
	[delegate_ retain];
	[delegate release];
	delegate = delegate_;

	return self;
}

- parseBuffer: (const char*)buf
     withSize: (size_t)size
{