ObjFW  Check-in [5edba36213]

Overview
Comment:OFValueTests: Make signedness of char explicit

The test checked whether the mismatch between char and unsigned char is
detected. If however char is unsigned, there is no mismatch and the test
would fail.

Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: 5edba36213821b41e62c653a318e2fa194fbf0ab20ba35b54600bc69b69ed8e8
User & Date: js on 2018-04-15 13:01:55
Other Links: manifest | tags
Context
2018-04-15
13:34
OFURL: Require files for fileSystemRepresentation check-in: d7269ab32a user: js tags: trunk
13:01
OFValueTests: Make signedness of char explicit check-in: 5edba36213 user: js tags: trunk
12:51
Add handling of AmigaOS paths check-in: 1c499f0728 user: js tags: trunk
Changes

Modified tests/OFValueTests.m from [2f42006d62] to [2902c46008].

162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
			    objCType: @encode(char)] rectangleValue])

	TEST(@"-[isEqual:]",
	    [[OFValue valueWithRectangle: rectangle]
	    isEqual: [OFValue valueWithBytes: &rectangle
				    objCType: @encode(of_rectangle_t)]] &&
	    ![[OFValue valueWithBytes: "a"
			     objCType: @encode(char)]
	    isEqual: [OFValue valueWithBytes: "a"
				    objCType: @encode(unsigned char)]] &&
	    ![[OFValue valueWithBytes: "a"
			     objCType: @encode(char)]
	    isEqual: [OFValue valueWithBytes: "b"
				    objCType: @encode(char)]])

	[pool drain];
}
@end







|










162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
			    objCType: @encode(char)] rectangleValue])

	TEST(@"-[isEqual:]",
	    [[OFValue valueWithRectangle: rectangle]
	    isEqual: [OFValue valueWithBytes: &rectangle
				    objCType: @encode(of_rectangle_t)]] &&
	    ![[OFValue valueWithBytes: "a"
			     objCType: @encode(signed char)]
	    isEqual: [OFValue valueWithBytes: "a"
				    objCType: @encode(unsigned char)]] &&
	    ![[OFValue valueWithBytes: "a"
			     objCType: @encode(char)]
	    isEqual: [OFValue valueWithBytes: "b"
				    objCType: @encode(char)]])

	[pool drain];
}
@end