Overview
| Comment: | Fix missing retains in OFList. |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | trunk |
| Files: | files | file ages | folders |
| SHA3-256: |
5c006e80bb61e983abb7a231ef31f234 |
| User & Date: | js on 2009-10-18 19:25:10 |
| Other Links: | manifest | tags |
Context
|
2009-10-18
| ||
| 19:32 | Only cancel a thread on -[dealloc] if it's still running. check-in: 19a1167518 user: js tags: trunk | |
| 19:25 | Fix missing retains in OFList. check-in: 5c006e80bb user: js tags: trunk | |
| 19:24 | Only get UTF-8 position if the string is using UTF-8. check-in: 92c42bbe32 user: js tags: trunk | |
Changes
Modified src/OFList.m from [75c1a9ff27] to [4ef2950507].
| ︙ | ︙ | |||
53 54 55 56 57 58 59 |
}
- (of_list_object_t*)append: (id)obj
{
of_list_object_t *o;
o = [self allocMemoryWithSize: sizeof(of_list_object_t)];
| | | 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 |
}
- (of_list_object_t*)append: (id)obj
{
of_list_object_t *o;
o = [self allocMemoryWithSize: sizeof(of_list_object_t)];
o->object = [obj retain];
o->next = NULL;
o->prev = last;
if (last != NULL)
last->next = o;
last = o;
|
| ︙ | ︙ | |||
76 77 78 79 80 81 82 |
}
- (of_list_object_t*)prepend: (id)obj
{
of_list_object_t *o;
o = [self allocMemoryWithSize: sizeof(of_list_object_t)];
| | | 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 |
}
- (of_list_object_t*)prepend: (id)obj
{
of_list_object_t *o;
o = [self allocMemoryWithSize: sizeof(of_list_object_t)];
o->object = [obj retain];
o->next = first;
o->prev = NULL;
if (first != NULL)
first->prev = o;
first = o;
|
| ︙ | ︙ | |||
100 101 102 103 104 105 106 |
- (of_list_object_t*)insert: (id)obj
before: (of_list_object_t*)listobj
{
of_list_object_t *o;
o = [self allocMemoryWithSize: sizeof(of_list_object_t)];
| | | 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 |
- (of_list_object_t*)insert: (id)obj
before: (of_list_object_t*)listobj
{
of_list_object_t *o;
o = [self allocMemoryWithSize: sizeof(of_list_object_t)];
o->object = [obj retain];
o->next = listobj;
o->prev = listobj->prev;
if (listobj->prev != NULL)
listobj->prev->next = o;
listobj->prev = o;
|
| ︙ | ︙ | |||
125 126 127 128 129 130 131 |
- (of_list_object_t*)insert: (id)obj
after: (of_list_object_t*)listobj
{
of_list_object_t *o;
o = [self allocMemoryWithSize: sizeof(of_list_object_t)];
| | | 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 |
- (of_list_object_t*)insert: (id)obj
after: (of_list_object_t*)listobj
{
of_list_object_t *o;
o = [self allocMemoryWithSize: sizeof(of_list_object_t)];
o->object = [obj retain];
o->next = listobj->next;
o->prev = listobj;
if (listobj->next != NULL)
listobj->next->prev = o;
listobj->next = o;
|
| ︙ | ︙ | |||
202 203 204 205 206 207 208 |
o = NULL;
prev = NULL;
@try {
for (iter = first; iter != NULL; iter = iter->next) {
o = [new allocMemoryWithSize: sizeof(of_list_object_t)];
| | | 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 |
o = NULL;
prev = NULL;
@try {
for (iter = first; iter != NULL; iter = iter->next) {
o = [new allocMemoryWithSize: sizeof(of_list_object_t)];
o->object = [iter->object retain];
o->next = NULL;
o->prev = prev;
if (new->first == NULL)
new->first = o;
if (prev != NULL)
prev->next = o;
|
| ︙ | ︙ |