ObjFW  History of src/OFMutableDictionary.m of f12cecf014c3b511

While the idea sounds nice that the tag name is the class, this means the
serialization includes whether something is mutable or immutable. This means
doing as much as making something immutable changes the serialization, which
can then cause issues after being deserialized. file: [4bd030691a] check-in: [6ce0093f8d] user: js, branch: trunk, size: 4379 [annotate] [blame] [check-ins using] [diff]

This is only migrating some places, others will be migrated as they are
touched. file: [6a9ceedcaa] check-in: [a0fd103a0b] user: js, branch: trunk, size: 4549 [annotate] [blame] [check-ins using] [diff]

-[setObject:forSubscriptedKey:] is supposed to support removing a key by
setting it to nil. file: [1ad5b29420] check-in: [bb8de03577] user: js, branch: trunk, size: 4665 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [04d26872af] check-in: [2f4e0df8be] user: js, branch: trunk, size: 4604 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [63b8a9aaca] check-in: [4af49a13c3] user: js, branch: trunk, size: 3970 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [8cacd80133] check-in: [44f45c2e35] user: js, branch: trunk, size: 3964 [annotate] [blame] [check-ins using] [diff]

If this is only overridden in OFMutableDictionary, this would lead to
inconsistent behavior, as it could be called on an OFDictionary as well
due to the fact that -[setValue:forKey:] is defined in OFObject.
Instead, if the dictionary is immutable, an OFUndefinedKeyException is
thrown. file: [b571ce2a18] check-in: [f816d1ec7c] user: js, branch: trunk, size: 4014 [annotate] [blame] [check-ins using] [diff]

If the key starts with an @, the @ is stripped and the super method is
called. Otherwise, this is equivalent to -[objectForKey:] /
-[setValue:forKey:]. file: [87db87aaf2] check-in: [cbacea7ca3] user: js, branch: trunk, size: 4344 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [a50117af87] check-in: [cec0f072f8] user: js, branch: 0.8, size: 4104 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [6b8bc772b6] check-in: [2a27cf3000] user: js, branch: trunk, size: 3993 [annotate] [blame] [check-ins using] [diff]

Now that we require GCC >= 4.6 anyway, there's no more reason to not use
it anymore. file: [d75be996d7] check-in: [6b13727ce0] user: js, branch: trunk, size: 3989 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [5eb0295031] check-in: [13ee56edf3] user: js, branch: trunk, size: 4094 [annotate] [blame] [check-ins using] [diff]

This also removes "bool *stop" from some blocks where it does not make
sense. file: [c0b80ff39c] check-in: [e8473b9db8] user: js, branch: trunk, size: 3945 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [e6fd44030a] check-in: [c5ef582958] user: js, branch: trunk, size: 3890 [annotate] [blame] [check-ins using] [diff]

This was already implemented in OFDictionary_hashtable for internal
usage and is now publicly available. file: [3f243b3679] check-in: [4fb0f4bf66] user: js, branch: trunk, size: 3876 [annotate] [blame] [check-ins using] [diff]

This greatly improves performance, as it gets rid of the overhead of
OFAutoreleasePool. file: [46ace486e0] check-in: [1255f3a11a] user: js, branch: trunk, size: 3661 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [07bbff71b3] check-in: [e1e7ffa903] user: js, branch: trunk, size: 3216 [annotate] [blame] [check-ins using] [diff]

This fixes the mutable versions reimplementing it and still behaving the
old way. file: [e5d16fd400] check-in: [3b0699b790] user: js, branch: trunk, size: 6646 [annotate] [blame] [check-ins using] [diff]

We assume now that every object understands retain, release, etc. so
that we can weaken the type from OFObject* to id. This makes it
possible to use different root object classes. file: [078edcac44] check-in: [e2b06423e0] user: js, branch: trunk, size: 6187 [annotate] [blame] [check-ins using] [diff]

This typo would prevent termination in the very rare case that the last
bucket is already used. file: [c74680827d] check-in: [3bccfadcc1] user: js, branch: trunk, size: 5237 [annotate] [blame] [check-ins using] [diff]

Changesets:
* b95fcaa6d694
* 804c68d222b4
* da8cd738da3d
* 1109d5ce3419
* d03f5c1ca95d
* 2a7017722165
* 4fccdc79eeb7
* d228149fbc04
* 8782d412a4a6 file: [cd9a17e8ee] check-in: [b91a8283fe] user: js, branch: 0.2, size: 4407 [annotate] [blame] [check-ins using] [diff]

The new implementation is easier to use as it does automatic resizing,
but therefore it's not realtime-capable anymore. The new implementation
should also be a little bit faster.

I decided to change the implementation as only very few need a
realtime-capable dictionary and those few will most likely write their
own implementation for their specific case anyway.

As the new implementation no longer uses OFList, this also made it
possible to remove a hack from OFList. file: [436bcef63e] check-in: [bbf1f79b8f] user: js, branch: trunk, size: 3431 [annotate] [blame] [check-ins using] [diff]

OFDictionary:
* More optimized way to internally store the data.
* Faster resizing of dictionaries (no rehashing anymore).

OFIterator:
* Return a key/object pair rather than first the key and then the
object.

OFList:
* Support for list objects with a different size so you can have your
own list object structs. file: [eed907dfa3] check-in: [24ecf55297] user: js, branch: trunk, size: 3081 [annotate] [blame] [check-ins using] [diff]

OFExceptions:
* OFNoMemException to OFOutOfMemoryException.
* OFMemNotPartOfObjException to OFMemoryNotPartOfObjectException.

OFObject:
* -[addItemToMemoryPool:] to -[addMemoryToPool:].
* -[allocWithSize:] to -[allocMemoryWithSize:].
* -[allocNItems:withSize] to -[allocMemoryForNItems:withSize:].
* -[resizeMem:toSize] to -[resizeMemory:toSize:].
* -[resizeMem:toNItems:withSize:] to
-[resizeMemoryToNItems:withSize:].
* -[freeMem] to -[freeMemory:].

OFString:
* -[urlencode] to -[urlEncodedString].
* -[urldecode] to -[urlDecodedString]. file: [bd2647bb71] check-in: [033054ad75] user: js, branch: trunk, size: 2747 [annotate] [blame] [check-ins using] [diff]

OFArray:
* Rename - object: to - objectAtIndex:.

OFDataArray:
* Rename - item: to - itemAtIndex:.

OFDictionary:
* Rename - get: to - objectForKey:.
* Rename - set:to: to - setObject:forKey:.
* Rename - remove: to - removeObjectForKey:. file: [da30bcc8d4] check-in: [a29d403286] user: js, branch: trunk, size: 2732 [annotate] [blame] [check-ins using] [diff]