ObjFW  History of src/OFStreamObserver.m of d72d924a00321330

The new file socket.h includes all headers required for sockets on the
used platform, while the file socket_helpers.h defines the BSD API
functions to the platform specific functions if necessary.

This cleans up the classes dealing with sockets a lot and also reduces
code duplication. file: [a3d6727f88] check-in: [81d47f4398] user: js, branch: trunk, size: 8915 [annotate] [blame] [check-ins using] [diff]

This is used instead for time intervals now instead of doubles. file: [8b0d12d65c] check-in: [dc31ce3d34] user: js, branch: trunk, size: 9254 [annotate] [blame] [check-ins using] [diff]

Instead, a decreasing variable is used now. This should be safe, as
nothing else should be binding ports while homebrew code is running. The
only problem that could arise is when code manually binds to very high
port numbers.

This also solves the problem that getsockname() is not available on the
Wii, as we know the port now anyway.

And while we're at it, this also adds struct sockaddr_storage. file: [2bcf8ed1eb] check-in: [ca113e0145] user: js, branch: trunk, size: 9311 [annotate] [blame] [check-ins using] [diff]

Not functional yet due to bugs in the SDK.
Bugs found so far:

* Binding to port 0 fails instead of choosing a free port.
* gethostbyname() does not work for IPs.
* getsockname() is missing.
* struct sockaddr_storage is missing.

I have not decided yet whether I fix those bugs in the SDK (I already
implemented getsockname() and added struct sockaddr_stroage and it seems
to work) or if I work around them in ObjFW. This will mainly depend on
how cooperative the developers of the Wii SDK are. file: [ec4b8afafc] check-in: [ffb91daffe] user: js, branch: trunk, size: 9186 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [14f367ec0c] check-in: [c5ef582958] user: js, branch: trunk, size: 8519 [annotate] [blame] [check-ins using] [diff]

It is now called -[numberOfBytesInReadBuffer].

Additionally, this commit renames OFStream's _cache to _readBuffer. file: [6df17e709d] check-in: [efe7be259d] user: js, branch: trunk, size: 8511 [annotate] [blame] [check-ins using] [diff]

It was time to finally have one file per class. file: [f18e106529] check-in: [0a55edad35] user: js, branch: trunk, size: 8821 [annotate] [blame] [check-ins using] [diff]

It is now -[fileDescriptorForReading] and -[fileDescriptorForWriting].
The split was necessary as some stream types (e.g. OFProcess) don't have
a single file descriptor, but two. This allows to use those stream types
with OFStreamObserver as well. file: [41b087a39c] check-in: [440e95fd4a] user: js, branch: trunk, size: 8761 [annotate] [blame] [check-ins using] [diff]

This greatly improves performance, as it gets rid of the overhead of
OFAutoreleasePool. file: [44b77ee334] check-in: [1255f3a11a] user: js, branch: trunk, size: 8840 [annotate] [blame] [check-ins using] [diff]

This is to be used when the condition includes a statement that needs to
be executed, as with assert, this would not be executed anymore when
NDEBUG is defined. file: [46e892e905] check-in: [417b213d41] user: js, branch: trunk, size: 8879 [annotate] [blame] [check-ins using] [diff]

Also fix a bug where OFBigDataArray would waste memory. file: [75b0a6497b] check-in: [f7576a66ce] user: js, branch: trunk, size: 8761 [annotate] [blame] [check-ins using] [diff]

Also adds more checks. file: [9591f1939e] check-in: [d5ddb2cb48] user: js, branch: trunk, size: 8755 [annotate] [blame] [check-ins using] [diff]

This is required for the new array literals. file: [89d321be6d] check-in: [008be86a16] user: js, branch: trunk, size: 8770 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [fa968ce497] check-in: [e1e7ffa903] user: js, branch: trunk, size: 8827 [annotate] [blame] [check-ins using] [diff]

* Make it possible to close a stream before the add/remove queue has
been processed.
* The actual implementations don't need to handle OFStreams now, but
get the file descriptor instead.
* Use an OFMutex instead of @synchronized. file: [2c9b5a07cf] check-in: [47caef4f8a] user: js, branch: trunk, size: 8571 [annotate] [blame] [check-ins using] [diff]

This makes it impossible for the developer to accidentally create a DoS.
When data has been received after calling -[tryReadLine] and the string
is still incomplete, -[streamIsReadyForReading:] will not be called
anymore until new data has been received, thus preventing spinning in a
loop. file: [332048c7be] check-in: [535c2d5d9b] user: js, branch: trunk, size: 8431 [annotate] [blame] [check-ins using] [diff]

Without this, the headers try to declare functions that use __block as
an argument name and thus fail to compile when using -fblocks. file: [fbacb17597] check-in: [59e52af26d] user: js, branch: 0.5, size: 11957 [annotate] [blame] [check-ins using] [diff]

Without this, the headers try to declare functions that use __block as
an argument name and thus fail to compile when using -fblocks. file: [741b860b9a] check-in: [da2701ad14] user: js, branch: trunk, size: 12485 [annotate] [blame] [check-ins using] [diff]

FD_SETSIZE is _NOT_ the number of the last fd, but the maximum number of
fds to observe! file: [b5be6cde87] check-in: [57f51f7341] user: js, branch: trunk, size: 10176 [annotate] [blame] [check-ins using] [diff]

Some systems like Ubuntu have libc headers which specify an attribute
that the compiler should issue a warning if the return value is ignored. file: [c4fa7336ee] check-in: [8349bc4bbe] user: js, branch: trunk, size: 10328 [annotate] [blame] [check-ins using] [diff]

This way, the method to determine whether OFStreamSocket should
call the delegate can be overriden by subclasses, for example
for SSL sockets. file: [b3c7d0cf87] check-in: [f4151a36e3] user: js, branch: trunk, size: 10274 [annotate] [blame] [check-ins using] [diff]

Not working on win32 yet, it will be ported to it later as it's not that
easy there, since select() can only observe sockets. file: [864995cc48] check-in: [a61ab37726] user: js, branch: trunk, size: 10141 [annotate] [blame] [check-ins using] [diff]

It does not cancel the currently running -[observe] yet when changing
the set of streams to observe. file: [bf14750714] check-in: [35aab77af3] user: js, branch: trunk, size: 9282 [annotate] [blame] [check-ins using] [diff]

It also looks at the cache of each stream now and does not block if
there is still data in the cache. file: [2babecb315] check-in: [b554732eae] user: js, branch: trunk, size: 6198 [annotate] [blame] [check-ins using] [diff]

We assume now that every object understands retain, release, etc. so
that we can weaken the type from OFObject* to id. This makes it
possible to use different root object classes. file: [7ad4630322] check-in: [e2b06423e0] user: js, branch: trunk, size: 5626 [annotate] [blame] [check-ins using] [diff]