Comment: | Add OF_ENSURE.
This is to be used when the condition includes a statement that needs to |
---|---|
Downloads: | Tarball | ZIP archive | SQL archive |
Timelines: | family | ancestors | descendants | both | trunk |
Files: | files | file ages | folders |
SHA3-256: |
417b213d4150b3b2adc42af9f9ac45f7 |
User & Date: | js on 2012-07-16 23:49:50 |
Other Links: | manifest | tags |
2012-07-17
| ||
00:02 | Implement introspection for the ObjFW runtime. check-in: 9df84ee33d user: js tags: trunk | |
2012-07-16
| ||
23:49 | Add OF_ENSURE. check-in: 417b213d41 user: js tags: trunk | |
22:44 | Don't require extra parentheses for OF_(UN)LIKELY. check-in: ff8b2a6c29 user: js tags: trunk | |
Modified src/OFAutoreleasePool.m from [6326631fd1] to [6cf9fdd824].
︙ | ︙ | |||
14 15 16 17 18 19 20 | * file. */ #include "config.h" #include <stdlib.h> | < < > > > < < | 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 | * file. */ #include "config.h" #include <stdlib.h> #import "OFAutoreleasePool.h" #import "OFArray.h" #import "OFNotImplementedException.h" #import "macros.h" #ifndef OF_COMPILER_TLS # import "threading.h" # import "OFInitializationFailedException.h" #endif extern id _objc_rootAutorelease(id); extern void* objc_autoreleasePoolPush(void); extern void objc_autoreleasePoolPop(void*); #ifdef OF_COMPILER_TLS static __thread void *first = NULL; #else |
︙ | ︙ | |||
86 87 88 89 90 91 92 | pool = objc_autoreleasePoolPush(); if (first == NULL) #ifdef OF_COMPILER_TLS first = pool; #else | | | 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 | pool = objc_autoreleasePoolPush(); if (first == NULL) #ifdef OF_COMPILER_TLS first = pool; #else OF_ENSURE(of_tlskey_set(firstKey, pool)); #endif _objc_rootAutorelease(self); } @catch (id e) { [self release]; @throw e; } |
︙ | ︙ | |||
132 133 134 135 136 137 138 | ignoreRelease = YES; #ifdef OF_COMPILER_TLS if (first == pool) first = NULL; #else if (of_tlskey_get(firstKey) == pool) | | | 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 | ignoreRelease = YES; #ifdef OF_COMPILER_TLS if (first == pool) first = NULL; #else if (of_tlskey_get(firstKey) == pool) OF_ENSURE(of_tlskey_set(firstKey, NULL)); #endif objc_autoreleasePoolPop(pool); [super dealloc]; } |
︙ | ︙ |
Modified src/OFBlock.m from [badbea4cd4] to [a204e2796b].
︙ | ︙ | |||
16 17 18 19 20 21 22 | #include "config.h" #include <stdint.h> #include <stdlib.h> #include <string.h> | < < > | 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 | #include "config.h" #include <stdint.h> #include <stdlib.h> #include <string.h> #if defined(OF_APPLE_RUNTIME) && !defined(__OBJC2__) # import <objc/runtime.h> #elif defined(OF_OBJFW_RUNTIME) # import "runtime-private.h" #endif #import "OFBlock.h" #import "OFAllocFailedException.h" #import "OFInitializationFailedException.h" #import "OFNotImplementedException.h" #import "macros.h" #ifdef OF_ATOMIC_OPS # import "atomic.h" #endif #ifdef OF_THREADS # import "threading.h" #endif |
︙ | ︙ | |||
197 198 199 200 201 202 203 | if (object_getClass((id)block) == (Class)&_NSConcreteMallocBlock) { #if defined(OF_ATOMIC_OPS) of_atomic_inc_int(&block->flags); #else unsigned hash = SPINLOCK_HASH(block); | | | | 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 | if (object_getClass((id)block) == (Class)&_NSConcreteMallocBlock) { #if defined(OF_ATOMIC_OPS) of_atomic_inc_int(&block->flags); #else unsigned hash = SPINLOCK_HASH(block); OF_ENSURE(of_spinlock_lock(&spinlocks[hash])); block->flags++; OF_ENSURE(of_spinlock_unlock(&spinlocks[hash])); #endif } return block; } void |
︙ | ︙ | |||
224 225 226 227 228 229 230 | block->descriptor->dispose_helper(block); free(block); } #else unsigned hash = SPINLOCK_HASH(block); | | | | | 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 | block->descriptor->dispose_helper(block); free(block); } #else unsigned hash = SPINLOCK_HASH(block); OF_ENSURE(of_spinlock_lock(&spinlocks[hash])); if ((--block->flags & OF_BLOCK_REFCOUNT_MASK) == 0) { OF_ENSURE(of_spinlock_unlock(&spinlocks[hash])); if (block->flags & OF_BLOCK_HAS_COPY_DISPOSE) block->descriptor->dispose_helper(block); free(block); return; } OF_ENSURE(of_spinlock_unlock(&spinlocks[hash])); #endif } void _Block_object_assign(void *dst_, const void *src_, const int flags_) { int flags = flags_ & (OF_BLOCK_FIELD_IS_BLOCK | |
︙ | ︙ |
Modified src/OFDate.m from [2b9c35d972] to [c0e29e0a91].
︙ | ︙ | |||
18 19 20 21 22 23 24 | #define _GNU_SOURCE #include <stdint.h> #include <limits.h> #include <time.h> #include <math.h> #include <float.h> | < | 18 19 20 21 22 23 24 25 26 27 28 29 30 31 | #define _GNU_SOURCE #include <stdint.h> #include <limits.h> #include <time.h> #include <math.h> #include <float.h> #include <sys/time.h> #import "OFDate.h" #import "OFString.h" #import "OFDictionary.h" #import "OFXMLElement.h" |
︙ | ︙ | |||
215 216 217 218 219 220 221 | - init { struct timeval t; self = [super init]; | | | 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 | - init { struct timeval t; self = [super init]; OF_ENSURE(!gettimeofday(&t, NULL)); seconds = t.tv_sec; seconds += (double)t.tv_usec / 1000000; return self; } |
︙ | ︙ | |||
621 622 623 624 625 626 627 | } - (double)timeIntervalSinceNow { struct timeval t; double seconds_; | | | 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 | } - (double)timeIntervalSinceNow { struct timeval t; double seconds_; OF_ENSURE(!gettimeofday(&t, NULL)); seconds_ = t.tv_sec; seconds_ += (double)t.tv_usec / 1000000; return seconds - seconds_; } - (OFDate*)dateByAddingTimeInterval: (double)seconds_ { return [OFDate dateWithTimeIntervalSince1970: seconds + seconds_]; } @end |
Modified src/OFObject.m from [edc6b04857] to [8f2badf8fb].
︙ | ︙ | |||
725 726 727 728 729 730 731 | } - retain { #if defined(OF_ATOMIC_OPS) of_atomic_inc_32(&PRE_IVAR->retainCount); #elif defined(OF_THREADS) | | | | 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 | } - retain { #if defined(OF_ATOMIC_OPS) of_atomic_inc_32(&PRE_IVAR->retainCount); #elif defined(OF_THREADS) OF_ENSURE(of_spinlock_lock(&PRE_IVAR->retainCountSpinlock)); PRE_IVAR->retainCount++; OF_ENSURE(of_spinlock_unlock(&PRE_IVAR->retainCountSspinlock)); #else PRE_IVAR->retainCount++; #endif return self; } |
︙ | ︙ | |||
749 750 751 752 753 754 755 | { #if defined(OF_ATOMIC_OPS) if (of_atomic_dec_32(&PRE_IVAR->retainCount) <= 0) [self dealloc]; #elif defined(OF_THREADS) size_t c; | | | | 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 | { #if defined(OF_ATOMIC_OPS) if (of_atomic_dec_32(&PRE_IVAR->retainCount) <= 0) [self dealloc]; #elif defined(OF_THREADS) size_t c; OF_ENSURE(of_spinlock_lock(&PRE_IVAR->retainCountSpinlock)); c = --PRE_IVAR->retainCount; OF_ENSURE(of_spinlock_unlock(&PRE_IVAR->retainCountSpinlock)); if (c == 0) [self dealloc]; #else if (--PRE_IVAR->retainCount == 0) [self dealloc]; #endif |
︙ | ︙ |
Modified src/OFStreamObserver.m from [6213636312] to [46e892e905].
︙ | ︙ | |||
15 16 17 18 19 20 21 | */ #include "config.h" #define OF_STREAM_OBSERVER_M #define __NO_EXT_QNX | | > | | 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 | */ #include "config.h" #define OF_STREAM_OBSERVER_M #define __NO_EXT_QNX #include <unistd.h> #include <assert.h> #import "OFStreamObserver.h" #import "OFArray.h" #import "OFDictionary.h" #import "OFStream.h" #import "OFDataArray.h" #ifdef _WIN32 |
︙ | ︙ | |||
42 43 44 45 46 47 48 49 50 51 52 53 54 55 | #if defined(HAVE_SYS_SELECT_H) || defined(_WIN32) # import "OFStreamObserver_select.h" #endif #import "OFInitializationFailedException.h" #import "OFNotImplementedException.h" #import "OFOutOfRangeException.h" enum { QUEUE_ADD = 0, QUEUE_REMOVE = 1, QUEUE_READ = 0, QUEUE_WRITE = 2 }; | > > | 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 | #if defined(HAVE_SYS_SELECT_H) || defined(_WIN32) # import "OFStreamObserver_select.h" #endif #import "OFInitializationFailedException.h" #import "OFNotImplementedException.h" #import "OFOutOfRangeException.h" #import "macros.h" enum { QUEUE_ADD = 0, QUEUE_REMOVE = 1, QUEUE_READ = 0, QUEUE_WRITE = 2 }; |
︙ | ︙ | |||
192 193 194 195 196 197 198 | [queueInfo addItem: &qi]; [queueFDs addItem: &fd]; } @finally { [mutex unlock]; } #ifndef _WIN32 | | | | | | | | | | 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 | [queueInfo addItem: &qi]; [queueFDs addItem: &fd]; } @finally { [mutex unlock]; } #ifndef _WIN32 OF_ENSURE(write(cancelFD[1], "", 1) > 0); #else OF_ENSURE(sendto(cancelFD[1], "", 1, 0, (struct sockaddr*)&cancelAddr, sizeof(cancelAddr)) > 0); #endif } - (void)addStreamForWriting: (OFStream*)stream { [mutex lock]; @try { int qi = QUEUE_ADD | QUEUE_WRITE; int fd = [stream fileDescriptor]; [queue addObject: stream]; [queueInfo addItem: &qi]; [queueFDs addItem: &fd]; } @finally { [mutex unlock]; } #ifndef _WIN32 OF_ENSURE(write(cancelFD[1], "", 1) > 0); #else OF_ENSURE(sendto(cancelFD[1], "", 1, 0, (struct sockaddr*)&cancelAddr, sizeof(cancelAddr)) > 0); #endif } - (void)removeStreamForReading: (OFStream*)stream { [mutex lock]; @try { int qi = QUEUE_REMOVE | QUEUE_READ; int fd = [stream fileDescriptor]; [queue addObject: stream]; [queueInfo addItem: &qi]; [queueFDs addItem: &fd]; } @finally { [mutex unlock]; } #ifndef _WIN32 OF_ENSURE(write(cancelFD[1], "", 1) > 0); #else OF_ENSURE(sendto(cancelFD[1], "", 1, 0, (struct sockaddr*)&cancelAddr, sizeof(cancelAddr)) > 0); #endif } - (void)removeStreamForWriting: (OFStream*)stream { [mutex lock]; @try { int qi = QUEUE_REMOVE | QUEUE_WRITE; int fd = [stream fileDescriptor]; [queue addObject: stream]; [queueInfo addItem: &qi]; [queueFDs addItem: &fd]; } @finally { [mutex unlock]; } #ifndef _WIN32 OF_ENSURE(write(cancelFD[1], "", 1) > 0); #else OF_ENSURE(sendto(cancelFD[1], "", 1, 0, (struct sockaddr*)&cancelAddr, sizeof(cancelAddr)) > 0); #endif } - (void)_addFileDescriptorForReading: (int)fd { @throw [OFNotImplementedException exceptionWithClass: [self class] |
︙ | ︙ |
Modified src/OFStreamObserver_kqueue.m from [5e762c9efc] to [0f25fb90be].
︙ | ︙ | |||
27 28 29 30 31 32 33 34 35 36 37 38 39 40 | #import "OFStreamObserver_kqueue.h" #import "OFDataArray.h" #import "OFAutoreleasePool.h" #import "OFInitializationFailedException.h" #import "OFOutOfMemoryException.h" #define EVENTLIST_SIZE 64 @implementation OFStreamObserver_kqueue - init { self = [super init]; | > > | 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 | #import "OFStreamObserver_kqueue.h" #import "OFDataArray.h" #import "OFAutoreleasePool.h" #import "OFInitializationFailedException.h" #import "OFOutOfMemoryException.h" #import "macros.h" #define EVENTLIST_SIZE 64 @implementation OFStreamObserver_kqueue - init { self = [super init]; |
︙ | ︙ | |||
135 136 137 138 139 140 141 | return NO; } for (i = 0; i < events; i++) { if (eventList[i].ident == cancelFD[0]) { char buffer; | | | 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 | return NO; } for (i = 0; i < events; i++) { if (eventList[i].ident == cancelFD[0]) { char buffer; OF_ENSURE(read(cancelFD[0], &buffer, 1) > 0); continue; } if (eventList[i].flags & EV_ERROR) { [delegate streamDidReceiveException: FDToStream[eventList[i].ident]]; |
︙ | ︙ |
Modified src/OFStreamObserver_poll.m from [106a17bb8d] to [17f5ac1ccb].
︙ | ︙ | |||
14 15 16 17 18 19 20 | * file. */ #include "config.h" #define __NO_EXT_QNX | < > > | 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 | * file. */ #include "config.h" #define __NO_EXT_QNX #include <unistd.h> #include <poll.h> #import "OFStreamObserver_poll.h" #import "OFDataArray.h" #import "OFAutoreleasePool.h" #import "OFOutOfRangeException.h" #import "macros.h" @implementation OFStreamObserver_poll - init { self = [super init]; @try { |
︙ | ︙ | |||
146 147 148 149 150 151 152 | } for (i = 0; i < nFDs; i++) { if (FDsCArray[i].revents & POLLIN) { if (FDsCArray[i].fd == cancelFD[0]) { char buffer; | | | 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 | } for (i = 0; i < nFDs; i++) { if (FDsCArray[i].revents & POLLIN) { if (FDsCArray[i].fd == cancelFD[0]) { char buffer; OF_ENSURE(read(cancelFD[0], &buffer, 1) > 0); FDsCArray[i].revents = 0; continue; } [delegate streamIsReadyForReading: FDToStream[FDsCArray[i].fd]]; |
︙ | ︙ |
Modified src/OFStreamObserver_select.m from [17f835ff3b] to [937ba60b81].
︙ | ︙ | |||
15 16 17 18 19 20 21 | */ #include "config.h" #define __NO_EXT_QNX #include <string.h> | < > > | 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 | */ #include "config.h" #define __NO_EXT_QNX #include <string.h> #include <unistd.h> #import "OFStreamObserver_select.h" #import "OFStream.h" #import "OFArray.h" #import "OFAutoreleasePool.h" #import "macros.h" @implementation OFStreamObserver_select - init { self = [super init]; FD_ZERO(&readFDs); |
︙ | ︙ | |||
103 104 105 106 107 108 109 | [pool release]; return NO; } if (FD_ISSET(cancelFD[0], &readFDs_)) { char buffer; #ifndef _WIN32 | | | | 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 | [pool release]; return NO; } if (FD_ISSET(cancelFD[0], &readFDs_)) { char buffer; #ifndef _WIN32 OF_ENSURE(read(cancelFD[0], &buffer, 1) > 0); #else OF_ENSURE(recvfrom(cancelFD[0], &buffer, 1, 0, NULL, NULL) > 0); #endif } objects = [readStreams objects]; count = [readStreams count]; for (i = 0; i < count; i++) { |
︙ | ︙ |
Modified src/macros.h from [8665430981] to [f51fb05aa2].
︙ | ︙ | |||
14 15 16 17 18 19 20 21 22 23 24 25 26 27 | * file. */ #import "OFObject.h" #include <stddef.h> #include <stdint.h> #if defined(OF_APPLE_RUNTIME) # import <objc/runtime.h> #endif #ifdef _PSP # define INTMAX_MAX LONG_LONG_MAX | > > | 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 | * file. */ #import "OFObject.h" #include <stddef.h> #include <stdint.h> #include <stdio.h> #include <stdlib.h> #if defined(OF_APPLE_RUNTIME) # import <objc/runtime.h> #endif #ifdef _PSP # define INTMAX_MAX LONG_LONG_MAX |
︙ | ︙ | |||
74 75 76 77 78 79 80 81 82 83 84 85 86 87 | # define OF_X86_ASM # elif defined(__ppc__) || defined(__PPC__) # define OF_PPC_ASM # elif defined(__arm__) || defined(__ARM__) # define OF_ARM_ASM # endif #endif #ifdef OF_OBJFW_RUNTIME # define objc_lookUpClass objc_lookup_class #endif #ifndef _WIN32 # define OF_PATH_DELIMITER '/' | > > > > > > > | 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 | # define OF_X86_ASM # elif defined(__ppc__) || defined(__PPC__) # define OF_PPC_ASM # elif defined(__arm__) || defined(__ARM__) # define OF_ARM_ASM # endif #endif #define OF_ENSURE(cond) \ if (!(cond)) { \ fprintf(stderr, "Failed to ensure condition in " \ __FILE__ ":%d:\n" #cond "\n", __LINE__); \ abort(); \ } #ifdef OF_OBJFW_RUNTIME # define objc_lookUpClass objc_lookup_class #endif #ifndef _WIN32 # define OF_PATH_DELIMITER '/' |
︙ | ︙ |
Modified src/runtime/property.m from [343585f1c5] to [677b6f2060].
︙ | ︙ | |||
14 15 16 17 18 19 20 | * file. */ #include "config.h" #include <string.h> | < < > | 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 | * file. */ #include "config.h" #include <string.h> #import "OFObject.h" #import "macros.h" #ifdef OF_THREADS # import "threading.h" # define NUM_SPINLOCKS 8 /* needs to be a power of 2 */ # define SPINLOCK_HASH(p) ((unsigned)((uintptr_t)p >> 4) & (NUM_SPINLOCKS - 1)) static of_spinlock_t spinlocks[NUM_SPINLOCKS]; #endif |
︙ | ︙ | |||
47 48 49 50 51 52 53 | objc_getProperty(id self, SEL _cmd, ptrdiff_t offset, BOOL atomic) { if (atomic) { id *ptr = (id*)(void*)((char*)self + offset); #ifdef OF_THREADS unsigned hash = SPINLOCK_HASH(ptr); | | < | | < | | 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 | objc_getProperty(id self, SEL _cmd, ptrdiff_t offset, BOOL atomic) { if (atomic) { id *ptr = (id*)(void*)((char*)self + offset); #ifdef OF_THREADS unsigned hash = SPINLOCK_HASH(ptr); OF_ENSURE(of_spinlock_lock(&spinlocks[hash])); @try { return [[*ptr retain] autorelease]; } @finally { OF_ENSURE(of_spinlock_unlock(&spinlocks[hash])); } #else return [[*ptr retain] autorelease]; #endif } return *(id*)(void*)((char*)self + offset); } void objc_setProperty(id self, SEL _cmd, ptrdiff_t offset, id value, BOOL atomic, signed char copy) { if (atomic) { id *ptr = (id*)(void*)((char*)self + offset); #ifdef OF_THREADS unsigned hash = SPINLOCK_HASH(ptr); OF_ENSURE(of_spinlock_lock(&spinlocks[hash])); @try { #endif id old = *ptr; switch (copy) { case 0: *ptr = [value retain]; break; case 2: *ptr = [value mutableCopy]; break; default: *ptr = [value copy]; } [old release]; #ifdef OF_THREADS } @finally { OF_ENSURE(of_spinlock_unlock(&spinlocks[hash])); } #endif return; } id *ptr = (id*)(void*)((char*)self + offset); |
︙ | ︙ | |||
128 129 130 131 132 133 134 | objc_getPropertyStruct(void *dest, const void *src, ptrdiff_t size, BOOL atomic, BOOL strong) { if (atomic) { #ifdef OF_THREADS unsigned hash = SPINLOCK_HASH(src); | | < < | | < < | | 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 | objc_getPropertyStruct(void *dest, const void *src, ptrdiff_t size, BOOL atomic, BOOL strong) { if (atomic) { #ifdef OF_THREADS unsigned hash = SPINLOCK_HASH(src); OF_ENSURE(of_spinlock_lock(&spinlocks[hash])); #endif memcpy(dest, src, size); #ifdef OF_THREADS OF_ENSURE(of_spinlock_unlock(&spinlocks[hash])); #endif return; } memcpy(dest, src, size); } void objc_setPropertyStruct(void *dest, const void *src, ptrdiff_t size, BOOL atomic, BOOL strong) { if (atomic) { #ifdef OF_THREADS unsigned hash = SPINLOCK_HASH(src); OF_ENSURE(of_spinlock_lock(&spinlocks[hash])); #endif memcpy(dest, src, size); #ifdef OF_THREADS OF_ENSURE(of_spinlock_unlock(&spinlocks[hash])); #endif return; } memcpy(dest, src, size); } |