ObjFW  History of src/OFRunLoop.m of c9bf16250c149062

On game consoles, initializing sockets takes a significant amount of
time. When not delaying socket initializing, that time is spent during
startup even when the application might never use sockets.

Worse yet, on Amiga, sockets might not be available at all and the
application will fail to start up, even when the application might never
use sockets. file: [7691af0c6a] check-in: [7460d2ccd8] user: js, branch: trunk, size: 40994 [annotate] [blame] [check-ins using] [diff]

This worked by pure coincidence since true and SCTP_UNORDERED are both
1 on Linux. file: [fbc3913f1e] check-in: [5f8070d792] user: js, branch: trunk, size: 40563 [annotate] [blame] [check-ins using] [diff]

This is more extensible. Without this, extending it later would result
in an API and ABI breakage. file: [f56fb160b7] check-in: [0fd2b1b4c8] user: js, branch: sctp, size: 40563 [annotate] [blame] [check-ins using] [diff]

Let's use the proper terminology for the protocol. file: [0a75a2f08b] check-in: [816c13da9b] user: js, branch: sctp, size: 40994 [annotate] [blame] [check-ins using] [diff]

This uses the same format as OFEnsure(). file: [1ed3a4a609] check-in: [c86b8f10f0] user: js, branch: trunk, size: 36976 [annotate] [blame] [check-ins using] [diff]

The old write API made it too easy to lose bytes when a stream is set to
non-blocking mode. The new API always throws when not all bytes were
written, which forces handling the number of bytes being written being
smaller than the number of bytes requested to be written. file: [5f45cad885] check-in: [d1d36ae522] user: js, branch: trunk, size: 36952 [annotate] [blame] [check-ins using] [diff]

This allows including them from the Amiga linklib in the future. file: [08b8bec829] check-in: [15662dd417] user: js, branch: trunk, size: 36528 [annotate] [blame] [check-ins using] [diff]

All necessary changes to adjust for the changes made in trunk are
included in the merge commit. file: [0ec2ab674a] check-in: [3c88df0ce4] user: js, branch: amiga-library, size: 36527 [annotate] [blame] [check-ins using] [diff]

This is only migrating some places, others will be migrated as they are
touched. file: [a843dfe040] check-in: [a0fd103a0b] user: js, branch: trunk, size: 37280 [annotate] [blame] [check-ins using] [diff]

Arguments that can just be captured by the block don't need to be
repeated as an argument. A lot of arguments passed to a delegate are
therefore not needed for a block. file: [964085efa2] check-in: [d7ddb3dbc7] user: js, branch: trunk, size: 37506 [annotate] [blame] [check-ins using] [diff]

This is intended for SCTP and SPX. file: [9b755653ca] check-in: [e5b2ee56ff] user: js, branch: trunk, size: 37620 [annotate] [blame] [check-ins using] [diff]

This makes it easier to reuse code for other datagram sockets, namely
IPX. file: [9886e0ee45] check-in: [b02c4b05bb] user: js, branch: trunk, size: 34180 [annotate] [blame] [check-ins using] [diff]

This is a new superclass for OFTCPSocket to allow sharing code with
other IP stream socket types, namely SCTP. file: [b3743d07b5] check-in: [3dfe642dd3] user: js, branch: trunk, size: 34180 [annotate] [blame] [check-ins using] [diff]

This does not fully fix it yet, but at least the socket tests in the
test suite pass on 3DS now. file: [f76ad8e6f6] check-in: [ab89c47f42] user: js, branch: trunk, size: 28332 [annotate] [blame] [check-ins using] [diff]

This avoids the entire problem of keeping the buffer alive until the
send finished. file: [6ee3abdf2e] check-in: [0f3ae90eef] user: js, branch: trunk, size: 28149 [annotate] [blame] [check-ins using] [diff]

This avoids the entire problem of keeping the buffer alive until the
write finished. file: [7000e17b8e] check-in: [f218986f51] user: js, branch: trunk, size: 27395 [annotate] [blame] [check-ins using] [diff]

Otherwise, there would be two methods for every operation: One for
success and one for failure. It also makes it easy to forget about
handling failure, so it's better to always pass an optional exception. file: [2b70c16414] check-in: [064dbe5127] user: js, branch: trunk, size: 27224 [annotate] [blame] [check-ins using] [diff]

The target / selector approach had several drawbacks:

* It was inconvenient to use, as for every read or write, a target,
selector and context would need to be specified.
* It lacked any kind of type-safety and would not even warn about using
a callback method with the wrong number of parameters.
* It encouraged using a different callback method for each read or
write call, which results in code that is hard to follow and also
slower (as it needs to recreate the async operation with a new
callback every time). file: [692cbbd5b1] check-in: [d16ad96cbd] user: js, branch: trunk, size: 28736 [annotate] [blame] [check-ins using] [diff]

Instead, OFDNSResolver is used for everything now. file: [b99d9d1539] check-in: [6e9ee122eb] user: js, branch: trunk, size: 28426 [annotate] [blame] [check-ins using] [diff]

This allows calling -[run] from a callback to run the loop for a while,
without the run that called the callback being stopped. file: [3fae23d4fe] check-in: [184011467a] user: js, branch: trunk, size: 23330 [annotate] [blame] [check-ins using] [diff]

Instead of letting OFStream conform to it, which itself does not really
conform to it, let all the subclasses that actually do conform to it. file: [5ad7583705] check-in: [69749b6a5b] user: js, branch: trunk, size: 23290 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [03e94e120d] check-in: [2f4e0df8be] user: js, branch: trunk, size: 22990 [annotate] [blame] [check-ins using] [diff]

This allows performing another write with the same buffer, length and
callback, which is useful for asynchronously writing in chunks. file: [8ab72d20c1] check-in: [47db5636d7] user: js, branch: trunk, size: 20777 [annotate] [blame] [check-ins using] [diff]

This matches Apple's style. file: [50df1150e8] check-in: [6b77a5dd8b] user: js, branch: trunk, size: 16285 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [f31ca790af] check-in: [4af49a13c3] user: js, branch: trunk, size: 16308 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [bedf74278b] check-in: [44f45c2e35] user: js, branch: trunk, size: 18868 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [1d17371e17] check-in: [2a27cf3000] user: js, branch: trunk, size: 18466 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [c3c6b10589] check-in: [13ee56edf3] user: js, branch: trunk, size: 18456 [annotate] [blame] [check-ins using] [diff]

It is no longer limited to streams now. file: [870ab6e96c] check-in: [c694569d86] user: js, branch: trunk, size: 15867 [annotate] [blame] [check-ins using] [diff]

This is used instead for time intervals now instead of doubles. file: [e29f8ae799] check-in: [dc31ce3d34] user: js, branch: trunk, size: 15822 [annotate] [blame] [check-ins using] [diff]

We don't care about the order here, we only care about getting the
update. The barrier is only useful to force the order. file: [3252e51e8a] check-in: [0fea69d149] user: js, branch: trunk, size: 15745 [annotate] [blame] [check-ins using] [diff]

This was only an issue with --enable-threads --disable-sockets. file: [410ce014df] check-in: [56ec27cbdf] user: js, branch: trunk, size: 15861 [annotate] [blame] [check-ins using] [diff]

This means that even if --disable-threads has been specified, it is
possible to use +[OFThread sleep*] to sleep the current (and only)
thread. file: [76c781112c] check-in: [71d45a29d1] user: js, branch: trunk, size: 15474 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [d42000199a] check-in: [c5ef582958] user: js, branch: trunk, size: 14622 [annotate] [blame] [check-ins using] [diff]

The rationale behind this is that otherwise, there are two methods
called addObject: with a different signature, the one from
OFMutableArray and the one from OFSortedList. As OFSortedList is
actually using insertion sort and all other methods on an OFList start
with insert anyway, this is also more consistent. file: [a5c17b66d7] check-in: [7a8a5a2995] user: js, branch: trunk, size: 12903 [annotate] [blame] [check-ins using] [diff]

This makes it possible to handle exceptions that occurred during async
I/O in the specified handler. file: [5d7da15761] check-in: [6343e04dcd] user: js, branch: trunk, size: 12900 [annotate] [blame] [check-ins using] [diff]

Don't let OFRunLoop conform to OFStreamObserverDelegate, as it does not
fully implement the protocol and we have no @optional in ObjC 1. file: [0f13518563] check-in: [932eb2bd6f] user: js, branch: trunk, size: 12100 [annotate] [blame] [check-ins using] [diff]

Async connecting is still missing. file: [019d6ee84a] check-in: [4d9a641d87] user: js, branch: trunk, size: 12122 [annotate] [blame] [check-ins using] [diff]

As the stream is used as a key, this references the stream. This
resulted in the stream never being deallocated, even though it was not
used anymore. The advantage of not removing it was that the next async
read on the stream would have been slightly faster by saving one malloc. file: [317802665c] check-in: [13eb2bf77b] user: js, branch: trunk, size: 6593 [annotate] [blame] [check-ins using] [diff]

This makes async I/O possible! file: [af64aebbb7] check-in: [df53f06922] user: js, branch: trunk, size: 2880 [annotate] [blame] [check-ins using] [diff]

A timer always needs to be removed before its fireDate is changed,
otherwise, this will break the ordering in the OFSortedList. file: [30c14bee93] check-in: [55e7d380e4] user: js, branch: trunk, size: 3141 [annotate] [blame] [check-ins using] [diff]