ObjFW  History of utils/ofhttp/OFHTTP.m of e7ab06503c38341c

This deprecates OFHTTPRequestMethodName(), which returns a C string.
APIs should avoid C strings as much as possible.

This function was initially only used internally, where this was fine.
However, when it was made public, it should have been converted to
OFString at the same time.

Adds OFHTTPRequestMethodParseString() for consistency, which behaves the
same as OFHTTPRequestMethodParseName() and deprecates it. file: [336f94ad28] check-in: [12c09ef41e] user: js, branch: trunk, size: 31801 [annotate] [blame] [check-ins using] [diff]

This theoretically allows embedding localizations. While this isn't
great as all will be held in memory but only one will be used, there
might be cases where everything should be in one binary. file: [05abbe7837] check-in: [88ed5be671] user: js, branch: trunk, size: 30085 [annotate] [blame] [check-ins using] [diff]

These implementations all depend on additional libraries that are
otherwise not needed for an ObjFW application that does not use TLS,
meaning they would add unnecessary dependencies for a lot of
applications and waste memory. file: [1e6fb1a87b] check-in: [8f8af474fc] user: js, branch: trunk, size: 29813 [annotate] [blame] [check-ins using] [diff]

The previous API could never work cleanly and would always require
hacks, as it needed intercepting all interactions of OFTCPSocket with
the raw socket and did not work at all if the OFTCPSocket had anything
in its read buffer before starting the TLS handshake. This also could
not be fixed easily, as it would have required the object to contain two
read buffers, one for the unencrypted connection and one for the
encrypted connection. There was also no clean way to perform the
handshake in a non-blocking way.

The new API is a lot cleaner and requires none of the hacks, but using
it requires slightly more work. But this is more than made up for by
making a fully asynchronous handshake possible. It uses the concept of a
stream wrapping another stream, meaning the entire connecting part is
being handled by OFTCPSocket and then the connected socket is passed off
to OFTLSStream to wrap it. This also makes for a lot cleaner separation
of concerns. file: [6bac196b77] check-in: [d30efa8bbf] user: js, branch: trunk, size: 29663 [annotate] [blame] [check-ins using] [diff]

This should make it easier to add TLS support using various
implementations. file: [2fe08b11b5] check-in: [34cb121dc5] user: js, branch: trunk, size: 29920 [annotate] [blame] [check-ins using] [diff]

It is unclear whether the same API can be applied to other sandboxing
frameworks. file: [8920dc599a] check-in: [510628432f] user: js, branch: 1.0, size: 29395 [annotate] [blame] [check-ins using] [diff]

The new names should be more accurate. file: [0d0e8ff125] check-in: [627511b032] user: js, branch: trunk, size: 29352 [annotate] [blame] [check-ins using] [diff]

Instead, add an exception to didPerformRequest, to make it more
consistent with other places. file: [1aec658c7f] check-in: [7f102e8c95] user: js, branch: trunk, size: 29488 [annotate] [blame] [check-ins using] [diff]

It used to be a short in some places and an int in other places. file: [20466a8b30] check-in: [6e42ee482f] user: js, branch: trunk, size: 29006 [annotate] [blame] [check-ins using] [diff]

It is not guaranteed that a type encoding for it exists. file: [636026cd3b] check-in: [d74f244ab7] user: js, branch: trunk, size: 28644 [annotate] [blame] [check-ins using] [diff]

This solves the old signed vs. unsigned problem and allows for more
bases than just 8, 10 and 16, as well as auto-detection of the base (if
base is 0). file: [e499272015] check-in: [b6ee372b98] user: js, branch: trunk, size: 28612 [annotate] [blame] [check-ins using] [diff]

Without this, there would be no indication of the error when using -q. file: [39d0dcb133] check-in: [9c506fc995] user: js, branch: trunk, size: 28316 [annotate] [blame] [check-ins using] [diff]

Additionally, only use _length for progress. file: [fb786804a8] check-in: [283aece9e8] user: js, branch: trunk, size: 28064 [annotate] [blame] [check-ins using] [diff]

This temporarily doesn't use the search domains anymore and makes CNAMEs
slightly more inefficient. The next commits will fix both. file: [749d02c708] check-in: [ee592cf603] user: js, branch: trunk, size: 28113 [annotate] [blame] [check-ins using] [diff]

This is now in alignment with the terminology of the RFC. file: [77758e69da] check-in: [d69f7bc1ff] user: js, branch: trunk, size: 28098 [annotate] [blame] [check-ins using] [diff]

This also fixes trying to print the name when it has not been detected
yet. file: [6159de2c20] check-in: [a7872e1065] user: js, branch: trunk, size: 26791 [annotate] [blame] [check-ins using] [diff]

It was not very useful as for any OFHTTPClient there can only be one
active request. file: [5aba4f761b] check-in: [eaf458c1e6] user: js, branch: trunk, size: 26839 [annotate] [blame] [check-ins using] [diff]

Otherwise, there would be two methods for every operation: One for
success and one for failure. It also makes it easy to forget about
handling failure, so it's better to always pass an optional exception. file: [c4c7ef8326] check-in: [064dbe5127] user: js, branch: trunk, size: 26963 [annotate] [blame] [check-ins using] [diff]

The target / selector approach had several drawbacks:

* It was inconvenient to use, as for every read or write, a target,
selector and context would need to be specified.
* It lacked any kind of type-safety and would not even warn about using
a callback method with the wrong number of parameters.
* It encouraged using a different callback method for each read or
write call, which results in code that is hard to follow and also
slower (as it needs to recreate the async operation with a new
callback every time). file: [31817d3b24] check-in: [d16ad96cbd] user: js, branch: trunk, size: 26966 [annotate] [blame] [check-ins using] [diff]

This is to make sure that the same URL is only tried again after we
successfully detected the file name, as otherwise we'd end up in an
infinite loop if we fail to detect the file name. file: [075e25cbdb] check-in: [ba6cb57178] user: js, branch: trunk, size: 26796 [annotate] [blame] [check-ins using] [diff]

This allows printing all headers of redirects in verbose mode. file: [3e501ee1e4] check-in: [892fbf97ac] user: js, branch: trunk, size: 26699 [annotate] [blame] [check-ins using] [diff]

This makes it more clear that this has nothing to do with the body of
the response, as the body of the response is read from the
OFHTTPResponse itself. file: [20b438d92f] check-in: [d375061886] user: js, branch: trunk, size: 26838 [annotate] [blame] [check-ins using] [diff]

This is in preparation for removing the body from OFHTTPRequest.
Having it as OFData that is part of the OFHTTPRequest was a bad idea, as
it does not allow streaming. file: [cdc79122cb] check-in: [8681bba25e] user: js, branch: trunk, size: 26836 [annotate] [blame] [check-ins using] [diff]

This is required as they now use attributesOfItemAtPath:, which reads
the user database. file: [de5b9ca60c] check-in: [904d0f429b] user: js, branch: trunk, size: 26385 [annotate] [blame] [check-ins using] [diff]

This removes all query methods and replaces them by a single one that
returns a dictionary. Not only does this allow querying multiple
attributes at once, it is also more extensible, as the previous
attributes were specific to file URLs. file: [e43d76979b] check-in: [34fe205b84] user: js, branch: trunk, size: 26314 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [7674e4cd26] check-in: [2f4e0df8be] user: js, branch: trunk, size: 26277 [annotate] [blame] [check-ins using] [diff]

This makes it clear that the request is handled asynchronously and makes
it possible to reintroduce a synchronous version later. file: [7ea7ca97c5] check-in: [0319fe1eb9] user: js, branch: trunk, size: 26106 [annotate] [blame] [check-ins using] [diff]

This does not make OFHTTPClientResponse completely asynchronous yet.

Since -[initWithURL:] does not work well with an asynchronous API, it no
longer supports HTTP URLs. However, a new, asynchronous API will be
added as a replacement later on. file: [725d764e14] check-in: [56a18442e2] user: js, branch: trunk, size: 26096 [annotate] [blame] [check-ins using] [diff]

This removes "b" for binary and always uses binary, as there is no good
reason to not use binary. file: [492c8ebbc8] check-in: [23e57c5040] user: js, branch: trunk, size: 25097 [annotate] [blame] [check-ins using] [diff]

This reduces the ifdef hell and makes much more sense, as with ixemul,
no native calls are allowed. file: [09fa3de57a] check-in: [c9621825fc] user: js, branch: trunk, size: 25120 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [fd3994865b] check-in: [4af49a13c3] user: js, branch: trunk, size: 25024 [annotate] [blame] [check-ins using] [diff]

Only OpenBSD's pledge() is supported so far. file: [9d1be742e3] check-in: [40cf53506a] user: js, branch: trunk, size: 24999 [annotate] [blame] [check-ins using] [diff]

This creates a conflict on Windows. file: [b07f7b6ae5] check-in: [e3e38ed68d] user: js, branch: trunk, size: 23986 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [2334e6806d] check-in: [44f45c2e35] user: js, branch: trunk, size: 23930 [annotate] [blame] [check-ins using] [diff]

This singleton gives access to all things locale, including the ability
to get localized strings.

This also adds the OF_LOCALIZED() macro. Its first argument is an ID for
the string to be localized and its second argument is the fallback
string to be used if it cannot retrieve the localized string. Following
that are variable name / value pairs to be replaced in the localized
string.

Getting translated strings is not implemented yet: Instead, it always
uses the fallback string.

This also switches ofhttp to localized strings. file: [6d271e2d00] check-in: [06bcb21fc7] user: js, branch: trunk, size: 23924 [annotate] [blame] [check-ins using] [diff]

This is achieved by replacing the locale's decimal point with "." after
formatting and replacing "." with the locale's decimal point before
parsing.

To still use the decimal point from the locale for formatting, the new
flag "," is introduced to formats. This is useful for just printing a
string to the user that is not saved to a file or sent via a network.

While this is an ugly hack, there is no better way to do this other than
implementing the functionality of printf and strtod myself, as POSIX
does not specify versions of these that take a locale as an argument.
While this is a lot of work and error-prone, I will most likely end up
doing this eventually.

This commit also enables the locale in OFApplication to notice when
things break. As a nice side effect, ofhttp now uses the locale's
decimal point in its user interface. file: [3ef2bcb62b] check-in: [6dff0f5922] user: js, branch: trunk, size: 20848 [annotate] [blame] [check-ins using] [diff]

This allows ofhttp to display all headers for the redirect in verbose
mode (the change for this is included). file: [e8263f7476] check-in: [a509ab7e91] user: js, branch: trunk, size: 20701 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [20c2c916a8] check-in: [cec0f072f8] user: js, branch: 0.8, size: 18704 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [ed4e5bef24] check-in: [2a27cf3000] user: js, branch: trunk, size: 20105 [annotate] [blame] [check-ins using] [diff]

Now that we can require GCC >= 4.6, we no longer need to have a category
on OFObject that adds the optional protocol to it. file: [545bac3fa9] check-in: [ba62f00fac] user: js, branch: trunk, size: 19765 [annotate] [blame] [check-ins using] [diff]

The new API allows long options and requires less manual parsing. file: [bdce356a5d] check-in: [bfa913aebe] user: js, branch: trunk, size: 19742 [annotate] [blame] [check-ins using] [diff]

This makes it possible to add support for delegates for file management
operations and on top makes it easier to add support for file management
operations on URLs. file: [45b5064c67] check-in: [f3c452dfef] user: js, branch: trunk, size: 18805 [annotate] [blame] [check-ins using] [diff]

It can still be overridden with -HUser-Agent:. file: [e352c0cdcc] check-in: [625377fca5] user: js, branch: trunk, size: 14140 [annotate] [blame] [check-ins using] [diff]

This is a small tool to download files via HTTP(S). file: [f40132b96b] check-in: [486073790c] user: js, branch: trunk, size: 8135 [annotate] [blame] [check-ins using]