ObjFW  History of src/exceptions/OFOpenFileFailedException.m of e1eea29286696526

The old behaviour where the exception would access errno directly on
creation of the exception was very fragile. The two main problems with
it were that sometimes it would pick up an errno even though none had
been set and in other cases that when the exception was created errno
had already been overridden.

This also greatly increases errno handling on Win32, especially in
conjunction with sockets. It can still be improved further, though. file: [195f94c4ef] check-in: [62e2de30b9] user: js, branch: trunk, size: 2055 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [4f20d070a7] check-in: [13ee56edf3] user: js, branch: trunk, size: 1496 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [81dda45767] check-in: [3d16a30f41] user: js, branch: trunk, size: 1601 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [1c310618be] check-in: [c5ef582958] user: js, branch: trunk, size: 1742 [annotate] [blame] [check-ins using] [diff]

This was pretty pointless, as it's usually only used once. file: [4e0dc54767] check-in: [d9ddc4d06e] user: js, branch: trunk, size: 1736 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [8c923f326e] check-in: [e1e7ffa903] user: js, branch: trunk, size: 1787 [annotate] [blame] [check-ins using] [diff]