ObjFW  History of src/OFArray.m of bd05eb8de3b181c3

This replaces the hack of OFAdjacentData being able to keep a pointer to
the parent. file: [9b0a605b93] check-in: [d1a8c88dc6] user: js, branch: trunk, size: 17579 [annotate] [blame] [check-ins using] [diff]

The Apple runtime can store the retain count in isa, so
retaining/releasing an object would suddenly make it seem like it was
mutated. file: [b025a39cbb] check-in: [27d8eb922d] user: js, branch: trunk, size: 17476 [annotate] [blame] [check-ins using] [diff]

While the idea sounds nice that the tag name is the class, this means the
serialization includes whether something is mutable or immutable. This means
doing as much as making something immutable changes the serialization, which
can then cause issues after being deserialized. file: [79e2c56f24] check-in: [6ce0093f8d] user: js, branch: trunk, size: 17444 [annotate] [blame] [check-ins using] [diff]

This uses the same format as OFEnsure(). file: [26b9b812f3] check-in: [c86b8f10f0] user: js, branch: trunk, size: 18025 [annotate] [blame] [check-ins using] [diff]

This is only migrating some places, others will be migrated as they are
touched. file: [e8aa9a3165] check-in: [a0fd103a0b] user: js, branch: trunk, size: 18007 [annotate] [blame] [check-ins using] [diff]

The new names should be more accurate. file: [5b6a2f3354] check-in: [627511b032] user: js, branch: trunk, size: 18216 [annotate] [blame] [check-ins using] [diff]

While -[OFData initWithDataNoCopy:count:itemSize:freeWhenDone:] can
currently never throw, it might in the future, and when it does so in
the future, these would be memory leaks then. file: [a1c992248d] check-in: [a2b4238850] user: js, branch: trunk, size: 18215 [annotate] [blame] [check-ins using] [diff]

-[allocMemoryWithSize:] has book keeping overhead that is unnecessary
for temporary memory. file: [e881543a8d] check-in: [0ddaac3f5b] user: js, branch: trunk, size: 18170 [annotate] [blame] [check-ins using] [diff]

The internal hash is still 32 bit in most places, but this way, it is at
least not baked into the API and ABI and can be upgraded later, should
that ever be necessary. file: [3a99f337b3] check-in: [aeb403a1ed] user: js, branch: trunk, size: 18308 [annotate] [blame] [check-ins using] [diff]

It's not very useful and is a problem for the Foundation bridge, as
NSEnumerator does not have it. file: [b12c539371] check-in: [7214a2c7af] user: js, branch: trunk, size: 18272 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [5414c26349] check-in: [2f4e0df8be] user: js, branch: trunk, size: 18865 [annotate] [blame] [check-ins using] [diff]

This matches Apple's style. file: [75d72d0a96] check-in: [6b77a5dd8b] user: js, branch: trunk, size: 17992 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [acebabe718] check-in: [4af49a13c3] user: js, branch: trunk, size: 17992 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [5b8c0b589b] check-in: [44f45c2e35] user: js, branch: trunk, size: 17943 [annotate] [blame] [check-ins using] [diff]

Contrary to what the documentation stated, it did not actually call
super when the key was starting with an @. file: [b96b2adef7] check-in: [134c19b100] user: js, branch: trunk, size: 17993 [annotate] [blame] [check-ins using] [diff]

If the key starts with an @, the @ is stripped and the super method is
called. Otherwise, this returns the value for all objects / sets the
value for all objects. file: [2d002f2918] check-in: [05196e511a] user: js, branch: trunk, size: 17497 [annotate] [blame] [check-ins using] [diff]

Also improves the test to prevent this from happening again. file: [a01924feba] check-in: [8a14ad35aa] user: js, branch: trunk, size: 17011 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [db139bebf1] check-in: [cec0f072f8] user: js, branch: 0.8, size: 17851 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [55b9badbf0] check-in: [2a27cf3000] user: js, branch: trunk, size: 17568 [annotate] [blame] [check-ins using] [diff]

Now that we can require GCC >= 4.6, we no longer need to fall back to
using a category on old compilers. file: [1d6d7edd47] check-in: [2aca549d60] user: js, branch: trunk, size: 17564 [annotate] [blame] [check-ins using] [diff]

Now that we require GCC >= 4.6 anyway, there's no more reason to not use
it anymore. file: [2be2e1c20f] check-in: [6b13727ce0] user: js, branch: trunk, size: 17583 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [c3b70333fd] check-in: [13ee56edf3] user: js, branch: trunk, size: 17841 [annotate] [blame] [check-ins using] [diff]

After all, this might (and does for OFArray_adjacent!) return an
internal representation that must not be changed, so changes should be
prevented at compile-time. file: [1814e666e5] check-in: [68d32a92c1] user: js, branch: trunk, size: 17885 [annotate] [blame] [check-ins using] [diff]

LLP64 was mostly fast enumeration using an unsigned long for the state,
which can't store a pointer or a size_t on LLP64. This is now solved by
either throwing an OFOutOfRangeException if the value of the size_t is
bigger than ULONG_MAX or storing the pointer in the extra field (copied
using memcpy, as it's an array of unsigned long, which again would be
too small to store a pointer).

Win64 was mostly Microsoft not being able to decide whether a length is
a size_t, a DWORD, an int or an unsigned int (thus the different types
in places that seem to be almost the same). But since that would not be
confusing enough, a file descriptor is an int if it's for a file, but a
long long if it is for a socket. But of course, for ReadFile and friends
it's a DWORD instead of an int then. file: [ff677666a5] check-in: [4e59d2692f] user: js, branch: trunk, size: 17849 [annotate] [blame] [check-ins using] [diff]

This also adds OF_JSON_REPRESENTATION_PRETTY. file: [ef5fe152e1] check-in: [eaa612ad50] user: js, branch: trunk, size: 17739 [annotate] [blame] [check-ins using] [diff]

This has the advantage of being faster. file: [752e762054] check-in: [3dac86b429] user: js, branch: trunk, size: 16329 [annotate] [blame] [check-ins using] [diff]

This allows to skip empty components. file: [38f8d86997] check-in: [f975b722df] user: js, branch: trunk, size: 16841 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [1b7e4a8b63] check-in: [3d16a30f41] user: js, branch: trunk, size: 16114 [annotate] [blame] [check-ins using] [diff]

No support for extensions yet.

This obsoletes BinaryPack. file: [3ddd9aa2f7] check-in: [cba771824e] user: js, branch: trunk, size: 16327 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [65b65f023d] check-in: [c5ef582958] user: js, branch: trunk, size: 16325 [annotate] [blame] [check-ins using] [diff]

This greatly improves performance, as it gets rid of the overhead of
OFAutoreleasePool. file: [208e599910] check-in: [1255f3a11a] user: js, branch: trunk, size: 14502 [annotate] [blame] [check-ins using] [diff]

OFArray:
* +[arrayByAddingObject:]
* +[arrayByAddingObjectsFromArray:]

OFMutableArray:
* -[addObjectsFromArray:]
* -[insertObjectsFromArray:atIndex:] file: [7b45e24981] check-in: [95e8e1e486] user: js, branch: trunk, size: 14254 [annotate] [blame] [check-ins using] [diff]

Also fix a bug where OFBigDataArray would waste memory. file: [5ae87127d9] check-in: [f7576a66ce] user: js, branch: trunk, size: 13903 [annotate] [blame] [check-ins using] [diff]

This is required for the new array literals. file: [f4dee3f63a] check-in: [008be86a16] user: js, branch: trunk, size: 13794 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [9d67fa5621] check-in: [e1e7ffa903] user: js, branch: trunk, size: 13172 [annotate] [blame] [check-ins using] [diff]

These will prevent a copy of an immutable array when using
-[objectsInRange:]. file: [de78bb7da7] check-in: [9e0ca2f627] user: js, branch: trunk, size: 13117 [annotate] [blame] [check-ins using] [diff]

This would make it impossible to use autoreleased objects after the
block has been executed without manually retaining and releasing them. file: [1f143f64a7] check-in: [bfb7745f95] user: js, branch: trunk, size: 13492 [annotate] [blame] [check-ins using] [diff]

Mutations during enumerations using blocks are now always detected,
even for methods such as -[reduceWithBlock:]. file: [720a88390f] check-in: [f9b3ec49f8] user: js, branch: trunk, size: 13605 [annotate] [blame] [check-ins using] [diff]

This way, we don't need a new parser and don't use a new format. file: [7df94bcaeb] check-in: [494dca4ae4] user: js, branch: trunk, size: 11940 [annotate] [blame] [check-ins using] [diff]

We assume now that every object understands retain, release, etc. so
that we can weaken the type from OFObject* to id. This makes it
possible to use different root object classes. file: [1e2bb24ba2] check-in: [e2b06423e0] user: js, branch: trunk, size: 6865 [annotate] [blame] [check-ins using] [diff]

This increases performance and should not need to be handled by the
programmer in most cases. file: [3b7a88e4d4] check-in: [d4b379485a] user: js, branch: trunk, size: 6591 [annotate] [blame] [check-ins using] [diff]

Changesets:
* 4122c2fe2aaa
* 5280d39d0a1a
* 7dcedafb43a4
* 1a7bc2049db1
* 12cc1ee22047 file: [38df47daa4] check-in: [cb2058b0d8] user: js, branch: 0.3, size: 6661 [annotate] [blame] [check-ins using] [diff]

ivars are now named like this: thisIsAnIVar. If an accessor exists for
the ivar, the ivar is named like the accessor. This is required for
@property to work. file: [af5a656bb6] check-in: [37db8f0fb3] user: js, branch: trunk, size: 6631 [annotate] [blame] [check-ins using] [diff]

Changesets:
* b95fcaa6d694
* 804c68d222b4
* da8cd738da3d
* 1109d5ce3419
* d03f5c1ca95d
* 2a7017722165
* 4fccdc79eeb7
* d228149fbc04
* 8782d412a4a6 file: [323e66f686] check-in: [b91a8283fe] user: js, branch: 0.2, size: 6055 [annotate] [blame] [check-ins using] [diff]

* +[conformsTo:] to +[conformsToProtocol:].
* -[isKindOf:] to -[isKindOfClass:].
* -[respondsTo:] to -[respondsToSelector:].
* -[conformsTo:] to -[conformsToProtocol:].
* -[methodFor:] to -[methodForSelector:]. file: [88c47b37c1] check-in: [67bb344ba6] user: js, branch: trunk, size: 3462 [annotate] [blame] [check-ins using] [diff]

OFArray:
* -[add:] to -[addObject:].
* -[last] to -[lastObject].

OFAutoreleasePool:
* +[addToPool:] to +[addObjectToTopmostPool:].
* -[addToPool:] to -[addObject:].

OFDataArray:
* -[add:] to -[addItem:].
* -[last] to -[lastItem].

OFObject:
* -[addToMemoryPool:] to -[addItemToMemoryPool:]. file: [c29a774dc8] check-in: [526d04018d] user: js, branch: trunk, size: 3456 [annotate] [blame] [check-ins using] [diff]

OFArray:
* Rename - object: to - objectAtIndex:.

OFDataArray:
* Rename - item: to - itemAtIndex:.

OFDictionary:
* Rename - get: to - objectForKey:.
* Rename - set:to: to - setObject:forKey:.
* Rename - remove: to - removeObjectForKey:. file: [dbe234c97f] check-in: [a29d403286] user: js, branch: trunk, size: 3424 [annotate] [blame] [check-ins using] [diff]

Actually, directly retaining them is required, as dealloc will release
them. file: [47830eac24] check-in: [cc6d2d3987] user: js, branch: trunk, size: 3410 [annotate] [blame] [check-ins using] [diff]

When using OFObject*, you have to cast to get rid of a warning when
calling methods on the returned object. file: [340e813c87] check-in: [9338313079] user: js, branch: trunk, size: 1779 [annotate] [blame] [check-ins using] [diff]

And while at it, change #import <config.h> in some files to
#import "config.h". file: [37d0e0f0dd] check-in: [2a4aa05a84] user: js, branch: trunk, size: 1793 [annotate] [blame] [check-ins using] [diff]

Reason is that - free might free stuff which is allocated during the
initialization, which might not be allocated when an error occurred. file: [5aad2dc149] check-in: [e9d48d0beb] user: js, branch: trunk, size: 4872 [annotate] [blame] [check-ins using] [diff]

getMemWithSize: -> allocWithSize:
getMemForNItems:ofSize: -> allocNItems:withSize:
resizeMem:toNItems:ofSize: -> resizeMem:toNItems:withSize: file: [91667fe0ee] check-in: [e959fed010] user: js, branch: trunk, size: 4871 [annotate] [blame] [check-ins using] [diff]

Since we don't use Object anymore and define isa in OFObject, we can
rely on it. file: [3315367580] check-in: [139591afe1] user: js, branch: trunk, size: 4758 [annotate] [blame] [check-ins using] [diff]

* Add OFComparable protocol.
* Add OFInvalidArgument exception - needs that sel_getName vs.
sel_get_name stuff again, therefore reintroduce it.
* Implement proper copy method for OFString and OFArray.
* Add isEqual: and compare: for OFString and OFArray. file: [99432f285e] check-in: [61a6ac873a] user: js, branch: trunk, size: 4645 [annotate] [blame] [check-ins using] [diff]

Additionally, interface for OFArray. file: [4b7e261931] check-in: [49859c2bcc] user: js, branch: trunk, size: 958 [annotate] [blame] [check-ins using]