ObjFW  History of src/OFMD5Hash.m of bbe4040126690c19

Before, -[digest] would do the final calculation, however, this would
mean a property modifies state, which is bad. file: [190d96fa7c] check-in: [82801897d3] user: js, branch: trunk, size: 6487 [annotate] [blame] [check-ins using] [diff]

With this property, it's possible to specify whether the memory should
be protected from swapping or not. This makes it easier for e.g. the
crypto hash classes: They can now just always use OFSecureData without
wasting unswappable memory if it's not needed. file: [cf3dfa1284] check-in: [e629dc83a9] user: js, branch: trunk, size: 6426 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [2136f8a2ba] check-in: [2f4e0df8be] user: js, branch: trunk, size: 5157 [annotate] [blame] [check-ins using] [diff]

This matches Apple's style. file: [5fa8ef5288] check-in: [6b77a5dd8b] user: js, branch: trunk, size: 5139 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [003b801911] check-in: [4af49a13c3] user: js, branch: trunk, size: 5086 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [43550851b7] check-in: [44f45c2e35] user: js, branch: trunk, size: 5082 [annotate] [blame] [check-ins using] [diff]

While in practice they are usually the same, the C standard says that
only char does not have any alignment requirements. As (u)int*_t is
defined to be an integer type of the specified size, it does not mean
(u)int8_t needs to be char. file: [8b5373705c] check-in: [19f7dc67af] user: js, branch: trunk, size: 4755 [annotate] [blame] [check-ins using] [diff]

OFHash is too generic, as this protocol is for cryptographic hashes. It
also solves the ambiguity of the +[hash] method (which is now
+[cryptoHash]), which conflicted with -[hash] on the class itself,
resulting in classes conforming to OFHash not being able to be used as a
key in an OFDictionary. file: [c7952ff29f] check-in: [951f530aee] user: js, branch: trunk, size: 4749 [annotate] [blame] [check-ins using] [diff]

(U)INT_FAST*_MAX is broken on Android, which makes (u)int_fast*_t
dangerous to use while it does not provide any real speed benefit. file: [76a6936277] check-in: [d3158d091f] user: js, branch: trunk, size: 4746 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [474dff4b31] check-in: [cec0f072f8] user: js, branch: 0.8, size: 4769 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [e0bf0902f7] check-in: [2a27cf3000] user: js, branch: trunk, size: 4761 [annotate] [blame] [check-ins using] [diff]

This increases the required GCC version from 4.0 to 4.6 (exception:
Apple GCC, which already supports this with >= 4.0 starting with OS X
10.5). Since even GCC 4.6 is really old by now, there is no point in
still supporting something even older and making the code ugly because
of that. While some hardware and OS support was dropped from GCC 4.6
compared to GCC 4.0, there is nothing in there that would be an
interesting target with the exception of BeOS maybe - but a port to BeOS
can also be achieved using the Haiku support. The other dropped OSes are
mostly old versions of OSes while newer ones are still being supported
(and those newer versions of those OSes still support the same
hardware). file: [353f7b18b1] check-in: [48980f2297] user: js, branch: trunk, size: 4757 [annotate] [blame] [check-ins using] [diff]

This is useful to calculate many hashes without allocating new objects. file: [3333d71ead] check-in: [7c27db9fe0] user: js, branch: trunk, size: 4765 [annotate] [blame] [check-ins using] [diff]

This has more resemblance to the implementation of the other hashes,
while the old method had more resemblance to how the algorithm is
described in the RFC.

It turns out that Clang generates better code when re-assigning all
variables to rotate them by one instead of accessing the variables by an
iteration-dependent index. file: [38980867ce] check-in: [b29adaf0bb] user: js, branch: trunk, size: 4542 [annotate] [blame] [check-ins using] [diff]

Took me some time to figure out the RFC is buggy and SSIG0(t-15) should
be SSIG0(W(t-15))... file: [8c6a093adf] check-in: [46af1252a5] user: js, branch: trunk, size: 4648 [annotate] [blame] [check-ins using] [diff]

This way, possibly sensitive information is discarded from memory as
soon as possible. file: [210a4456e6] check-in: [23dc2c7ff8] user: js, branch: trunk, size: 4654 [annotate] [blame] [check-ins using] [diff]

The old one was based on a public domain implementation, which is
optimized for old compilers and quite unreadable. The new one is written
from scratch and designed to be readable and to exploit optimizations of
modern compilers. file: [307a03b74d] check-in: [c4d2f177cb] user: js, branch: trunk, size: 4615 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [9801b1cb04] check-in: [13ee56edf3] user: js, branch: trunk, size: 7157 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [ae6cec6554] check-in: [3d16a30f41] user: js, branch: trunk, size: 7159 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [621cd607df] check-in: [c5ef582958] user: js, branch: trunk, size: 7185 [annotate] [blame] [check-ins using] [diff]

This makes it clear that multiple evaluation of parameters is possible. file: [233d143bc4] check-in: [1cb8fee5c3] user: js, branch: trunk, size: 7035 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [65056dd7ed] check-in: [e1e7ffa903] user: js, branch: trunk, size: 6836 [annotate] [blame] [check-ins using] [diff]