ObjFW  History of src/OFThread.m of abbed5c00896ca3c

It doesn't seem to be needed anymore. file: [ce6ddb874b] check-in: [cf0effe834] user: js, branch: trunk, size: 11118 [annotate] [blame] [check-ins using] [diff]

This is yet another function that would need to be passed from the
linklib to the .library. file: [05e44b8885] check-in: [d6050881b4] user: js, branch: trunk, size: 11142 [annotate] [blame] [check-ins using] [diff]

errno is problematic for Amiga libraries and is also not thread-safe on
some systems, even though it should. file: [7d209d5958] check-in: [5b37fbeb82] user: js, branch: trunk, size: 10869 [annotate] [blame] [check-ins using] [diff]

MorphOS allows sharing a single socket base between tasks, so having a
per-task socket base is unnecessary. file: [fe4bfba4ee] check-in: [b45a563f2b] user: js, branch: trunk, size: 10804 [annotate] [blame] [check-ins using] [diff]

Still miscompiles things. file: [690c42ccaa] check-in: [9e9ce6aa1c] user: js, branch: trunk, size: 10780 [annotate] [blame] [check-ins using] [diff]

Getting a pointer and increasing it until we reach the top pointer does
not work: Releasing an object can temporarily create new autorelease
pools, which can trigger resizing of "objects" using realloc, which can
move it to a different address, which will then lead to continuing to
iterate on a now invalid pointer.

This is now solved by using an index into "objects" instead. Since we're
now indexing for the pop, let's use indexes everywhere, as they're more
readable anyway.

While debugging this, I noticed that the last pool is popped quite
frequently, only for a new pool to be pushed immediately again. This
resulted in a free followed by a malloc every time. Instead, keep the
pool, but let OFThread explicitly say when to free everything. file: [5a3f2982c0] check-in: [e7f4f80e23] user: js, branch: trunk, size: 10770 [annotate] [blame] [check-ins using] [diff]

OFAutoreleasePools have long been discouraged in favor of the runtime's
autorelease pools. file: [3758706d1f] check-in: [09be825f88] user: js, branch: trunk, size: 10669 [annotate] [blame] [check-ins using] [diff]

It was used to convert a time interval into seconds and microseconds or
seconds and nanoseconds and introduced inaccuracies. file: [590ace3cab] check-in: [e702135e17] user: js, branch: trunk, size: 10588 [annotate] [blame] [check-ins using] [diff]

This allows specifying a name before the thread gets started, so that
the name can be decided by whoever starts the thread, rather than just
by the thread itself once it's running.

This is especially useful as some operating systems do not support
changing the name of the thread once it's running. file: [67276b0c18] check-in: [77780c7596] user: js, branch: trunk, size: 10645 [annotate] [blame] [check-ins using] [diff]

This allows the runtime to only link against the parts it needs, without
pulling in unnecessary parts like thread spawning, TLS and conditions. file: [6c09ccf959] check-in: [5358e9ea6a] user: js, branch: trunk, size: 10469 [annotate] [blame] [check-ins using] [diff]

Some systems do not provide the functionality. file: [0906d8e684] check-in: [b5430ac44f] user: js, branch: trunk, size: 10472 [annotate] [blame] [check-ins using] [diff]

It exists, but it just crashes. file: [3b2a0f4201] check-in: [06255a6aa8] user: js, branch: trunk, size: 10559 [annotate] [blame] [check-ins using] [diff]

libauto loads the libraries too late. file: [b00f8ab9a5] check-in: [d71abc5366] user: js, branch: trunk, size: 10559 [annotate] [blame] [check-ins using] [diff]

This returns the DNS resolver for the current thread. file: [0be3da0cb6] check-in: [2fb0769744] user: js, branch: trunk, size: 9765 [annotate] [blame] [check-ins using] [diff]

This has been fixed upstream in amiga-gcc. file: [5bd8a09d91] check-in: [b31bd48f90] user: js, branch: trunk, size: 9221 [annotate] [blame] [check-ins using] [diff]

floor() does not have the desired effect here when the number is
negative. file: [a7a9564a2b] check-in: [3c20dd5f95] user: js, branch: trunk, size: 9283 [annotate] [blame] [check-ins using] [diff]

The reason for this is that, in theory, this also supports versions
older than 3. file: [9adc83c2c8] check-in: [5831626f68] user: js, branch: trunk, size: 9283 [annotate] [blame] [check-ins using] [diff]

As we define the ABI, we can just replace BOOL with bool everywhere,
including in ObjFW itself. For the Apple platforms where BOOL and bool
are different, this is not a problem as BOOL and bool are passed and
returned the same way in the ABI.

This still defines BOOL to bool for compatibility, except on AmigaOS and
Wii, which both have its own BOOL type. file: [87b40649c1] check-in: [fe2cbe0021] user: js, branch: trunk, size: 9221 [annotate] [blame] [check-ins using] [diff]

This improves Swift compatibility. file: [5ec927c6f3] check-in: [a2e849c681] user: js, branch: trunk, size: 9271 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [2b6b7f737c] check-in: [2f4e0df8be] user: js, branch: trunk, size: 9236 [annotate] [blame] [check-ins using] [diff]

This time for real. file: [3fc1c7c412] check-in: [1a502ac38c] user: js, branch: 0.90, size: 8775 [annotate] [blame] [check-ins using] [diff]

This time for real. file: [41a9132f9a] check-in: [c211f691e7] user: js, branch: trunk, size: 9190 [annotate] [blame] [check-ins using] [diff]

The name of the thread may only be set from the thread itself. So the
thread should read the property on start and set its name. file: [e0cab8357e] check-in: [1d0042a040] user: js, branch: 0.90, size: 8737 [annotate] [blame] [check-ins using] [diff]

The name of the thread may only be set from the thread itself. So the
thread should read the property on start and set its name. file: [e635f40c39] check-in: [1494d3f6f1] user: js, branch: trunk, size: 8775 [annotate] [blame] [check-ins using] [diff]

This reduces the ifdef hell and makes much more sense, as with ixemul,
no native calls are allowed. file: [3ff1e2b592] check-in: [c9621825fc] user: js, branch: trunk, size: 9030 [annotate] [blame] [check-ins using] [diff]

This matches Apple's style. file: [b1f565231d] check-in: [6b77a5dd8b] user: js, branch: trunk, size: 8921 [annotate] [blame] [check-ins using] [diff]

useconds_t isn't always available and an unsigned int always satisfies
the range we require here. file: [3b9d6bd50a] check-in: [8e84561642] user: js, branch: trunk, size: 8921 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [a839633991] check-in: [4af49a13c3] user: js, branch: trunk, size: 8975 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [44538b1550] check-in: [44f45c2e35] user: js, branch: trunk, size: 8966 [annotate] [blame] [check-ins using] [diff]

This was only a problem with --disable-sockets, as sockets pull in
OFString.h via OFRunLoop.h. file: [f54c089de2] check-in: [ad9813cef0] user: js, branch: 0.8, size: 8743 [annotate] [blame] [check-ins using] [diff]

This was only a problem with --disable-sockets, as sockets pull in
OFString.h via OFRunLoop.h. file: [b9ed17bd65] check-in: [e630807216] user: js, branch: trunk, size: 8960 [annotate] [blame] [check-ins using] [diff]

This makes ObjFW compile for the Nintendo 3DS. file: [d451c32cdd] check-in: [032bfb52ed] user: js, branch: trunk, size: 8939 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [9d8e398251] check-in: [cec0f072f8] user: js, branch: 0.8, size: 8722 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [b26e7541e7] check-in: [2a27cf3000] user: js, branch: trunk, size: 8711 [annotate] [blame] [check-ins using] [diff]

This increases the required GCC version from 4.0 to 4.6 (exception:
Apple GCC, which already supports this with >= 4.0 starting with OS X
10.5). Since even GCC 4.6 is really old by now, there is no point in
still supporting something even older and making the code ugly because
of that. While some hardware and OS support was dropped from GCC 4.6
compared to GCC 4.0, there is nothing in there that would be an
interesting target with the exception of BeOS maybe - but a port to BeOS
can also be achieved using the Haiku support. The other dropped OSes are
mostly old versions of OSes while newer ones are still being supported
(and those newer versions of those OSes still support the same
hardware). file: [ed37db867b] check-in: [48980f2297] user: js, branch: trunk, size: 8707 [annotate] [blame] [check-ins using] [diff]

This changes the return type to void, as the return type of a thread's
main depends on the threading implementation used. For pthreads, it adds
a wrapper function which returns NULL to avoid problems with bogus
return values. For WinAPI threads, the function is just casted, as bogus
return values don't seem to matter there. file: [e9af0aca95] check-in: [52e02c06ca] user: js, branch: trunk, size: 8593 [annotate] [blame] [check-ins using] [diff]

It causes just too much trouble: It breaks with some old versions of
Clang, where noreturn does not work correctly, and OS X headers break if
noreturn is defined, requiring an ugly and fragile workaround. It's just
not worth the trouble it causes, as the same functionality is available
through __attribute__((__noreturn__)). file: [4615b52a3c] check-in: [716b1fc2b3] user: js, branch: trunk, size: 7976 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [fc3b904999] check-in: [13ee56edf3] user: js, branch: trunk, size: 7968 [annotate] [blame] [check-ins using] [diff]

Instead, just define _GNU_SOURCE when __GLIBC__ is defined. After all,
that's the only libc that doesn't work properly without any defines. file: [96b5d11fcf] check-in: [17be12b6e5] user: js, branch: trunk, size: 7920 [annotate] [blame] [check-ins using] [diff]

This actually caused more trouble than it fixed. The real reason was
that _POSIX_TIMERS wasn't defined and thus nanosleep() would not be
declared by time.h. libogc however also provides nanosleep(), but an
incompatible one that we don't really want. So after _POSIX_TIMERS has
been defined, it would actually conflict, as both declarations would be
used then. This removes the special handling for Wii and uses the
nanosleep() from time.h, which has a declaration that is compatible with
POSIX. file: [21b3bcf0e5] check-in: [82b11a2992] user: js, branch: trunk, size: 7486 [annotate] [blame] [check-ins using] [diff]

FreeBSD needs this. file: [3d7fca1f63] check-in: [30f95ecdf5] user: js, branch: trunk, size: 7464 [annotate] [blame] [check-ins using] [diff]

This also removes #include <time.h> from OFHTTPClientTests, as this
would cause <time.h> to be included without _POSIX_C_SOURCE set to
199309L and thus struct timespec would be missing. file: [ccb97c5ea7] check-in: [bfc762c6d8] user: js, branch: trunk, size: 7464 [annotate] [blame] [check-ins using] [diff]

Not using -std=gnu11 means _GNU_SOURCE does not get defined anymore,
therefore this commit also adds the required feature defines for glibc.

Additionally, this adds of_strdup in macros.h, as strdup is an
extension. file: [621dd2e5a4] check-in: [2f5af58573] user: js, branch: trunk, size: 7487 [annotate] [blame] [check-ins using] [diff]

This is used instead for time intervals now instead of doubles. file: [bbc593cb97] check-in: [dc31ce3d34] user: js, branch: trunk, size: 7455 [annotate] [blame] [check-ins using] [diff]

A file documenting the coding style will be written soon. This will
hopefully prevent conflicts in the future, such as whether static
functions are written in camelCase or_with_underscores, like was the
case here. file: [8a5ecd213c] check-in: [fa6496efc7] user: js, branch: trunk, size: 7375 [annotate] [blame] [check-ins using] [diff]

The port was much easier than expected. The only changes that were
required were defining the missing lrint() and useconds_t, the rest was
optional (like using backslashes for paths, even though slashes work
fine). file: [d3db130196] check-in: [a0b63a8df4] user: js, branch: trunk, size: 7383 [annotate] [blame] [check-ins using] [diff]

The reason is that the symbol nanosleep is available now on Win32, but
is part of the pthreads wrapper, which we don't use. file: [b5e162fd36] check-in: [bd2389b6b8] user: js, branch: trunk, size: 7299 [annotate] [blame] [check-ins using] [diff]

It is now called -[initWithThreadBlock:] in order to prevent method
signature conflicts.

This also fixes a missing release for the thread block. file: [076ba07ad1] check-in: [a3639589d3] user: js, branch: trunk, size: 7768 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [6bf58b8f5f] check-in: [3d16a30f41] user: js, branch: trunk, size: 7640 [annotate] [blame] [check-ins using] [diff]

This means that even if --disable-threads has been specified, it is
possible to use +[OFThread sleep*] to sleep the current (and only)
thread. file: [426c027f93] check-in: [71d45a29d1] user: js, branch: trunk, size: 7825 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [36c4793f97] check-in: [c5ef582958] user: js, branch: trunk, size: 7421 [annotate] [blame] [check-ins using] [diff]

On Haiku, this even renames the Haiku thread so that in a process
manager the thread's name can be seen. If no name has been set, it uses
the class name as name for the Haiku thread. file: [eb2ad7e37f] check-in: [debba8efb6] user: js, branch: trunk, size: 7249 [annotate] [blame] [check-ins using] [diff]

Blocks don't allow passing it anymore and without blocks, subclassing is
necessary anyway so that an ivar with the correct type can be added
(instead of id) if required. file: [378318c425] check-in: [0639a351db] user: js, branch: trunk, size: 6766 [annotate] [blame] [check-ins using] [diff]

It was time to finally have one file per class. file: [94dbbf6fa0] check-in: [0a55edad35] user: js, branch: trunk, size: 6997 [annotate] [blame] [check-ins using] [diff]

This way, it's not possible to set the status after the thread has
already set it, though this should only happen if the thread instantly
terminates. file: [b522bb5862] check-in: [e8f12e5de9] user: js, branch: trunk, size: 10494 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [475603ba84] check-in: [e1e7ffa903] user: js, branch: trunk, size: 9810 [annotate] [blame] [check-ins using] [diff]

This is almost never done, and was made impossible in ARC-compatible
code. file: [b865223801] check-in: [2e484248de] user: js, branch: trunk, size: 9665 [annotate] [blame] [check-ins using] [diff]

nearbyint() is missing on some systems, even though it is part of C99
and POSIX. file: [a10047f5e7] check-in: [45b499fb11] user: js, branch: trunk, size: 9663 [annotate] [blame] [check-ins using] [diff]

Also fixes the forgotten change to double in +[sleepForTimeInterval:]
and fixes two warnings due to missing casts from double to uint32_t. file: [95ced5e160] check-in: [c19b2b5726] user: js, branch: trunk, size: 9659 [annotate] [blame] [check-ins using] [diff]

Without this, the headers try to declare functions that use __block as
an argument name and thus fail to compile when using -fblocks. file: [e52975424c] check-in: [59e52af26d] user: js, branch: 0.5, size: 9210 [annotate] [blame] [check-ins using] [diff]

Without this, the headers try to declare functions that use __block as
an argument name and thus fail to compile when using -fblocks. file: [8d6289db16] check-in: [da2701ad14] user: js, branch: trunk, size: 11372 [annotate] [blame] [check-ins using] [diff]

We assume now that every object understands retain, release, etc. so
that we can weaken the type from OFObject* to id. This makes it
possible to use different root object classes. file: [4035170a3e] check-in: [e2b06423e0] user: js, branch: trunk, size: 5332 [annotate] [blame] [check-ins using] [diff]

We also want to be able to join a thread that is still running, this
change allows that. file: [12d687f3c9] check-in: [cc17787021] user: js, branch: trunk, size: 4978 [annotate] [blame] [check-ins using] [diff]