ObjFW  History of src/OFKernelEventObserver_kqueue.m of 780d0963712b39e5

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [a4cb76e207] check-in: [2f4e0df8be] user: js, branch: trunk, size: 5194 [annotate] [blame] [check-ins using] [diff]

This matches Apple's style. file: [4a787d392f] check-in: [6b77a5dd8b] user: js, branch: trunk, size: 5168 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [ab8ff7a52e] check-in: [44f45c2e35] user: js, branch: trunk, size: 5168 [annotate] [blame] [check-ins using] [diff]

_readObjects must only be changed from the thread running the observer
and not from a thread adding or removing objects to observe. This is
already handled by the locked queue used by poll and select, so the best
way to solve this is to use the locked queue for kqueue and epoll as
well. file: [6587f7a7e4] check-in: [85917ea0dd] user: js, branch: 0.8, size: 5152 [annotate] [blame] [check-ins using] [diff]

_readObjects must only be changed from the thread running the observer
and not from a thread adding or removing objects to observe. This is
already handled by the locked queue used by poll and select, so the best
way to solve this is to use the locked queue for kqueue and epoll as
well. file: [1f47484a4e] check-in: [45518ae7b7] user: js, branch: trunk, size: 5151 [annotate] [blame] [check-ins using] [diff]

This was broken by 88f2f03. The problem only existed when something was
in the read buffer, but not processed completely, as after processing
the read buffer, it would go on to wait for data - but since not the
entire read buffer had been processed, it meant there was still data
left there that needed to be handled first. file: [80c8d89772] check-in: [b84490ab4f] user: js, branch: 0.8, size: 5923 [annotate] [blame] [check-ins using] [diff]

This was broken by 88f2f03. The problem only existed when something was
in the read buffer, but not processed completely, as after processing
the read buffer, it would go on to wait for data - but since not the
entire read buffer had been processed, it meant there was still data
left there that needed to be handled first. file: [240d5f78f9] check-in: [7ae17af9f0] user: js, branch: trunk, size: 5922 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [a6eed99dff] check-in: [cec0f072f8] user: js, branch: 0.8, size: 5969 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [c7ba665a18] check-in: [2a27cf3000] user: js, branch: trunk, size: 5967 [annotate] [blame] [check-ins using] [diff]

kqueue and epoll were not updating _readObjects and _writeObjects
anymore, since this was done by the queue handling code, which they no
longer use after the refactorization. file: [d2b671d56c] check-in: [d1c4c46706] user: js, branch: 0.8, size: 5965 [annotate] [blame] [check-ins using] [diff]

kqueue and epoll were not updating _readObjects and _writeObjects
anymore, since this was done by the queue handling code, which they no
longer use after the refactorization. file: [8f67672c8e] check-in: [258b8a4944] user: js, branch: trunk, size: 5963 [annotate] [blame] [check-ins using] [diff]

This moves the locked queue for actions to
OFKernelEventObserver_LockedQueue, which is now used for select and
poll, but skipped for kqueue and epoll, as they natively support changes
from another thread.

This fixes the problem that removing an object is delayed until the next
observe call - at which point it might have already been closed, meaning
the fd is no longer available. This was mainly a problem with kqueue, as
closing the fd already removed it from the kqueue, which then resulted
in an error being returned when trying to manually remove the fd from
the kqueue. file: [9085a7dddc] check-in: [c5f0c5f9ba] user: js, branch: 0.8, size: 5125 [annotate] [blame] [check-ins using] [diff]

This moves the locked queue for actions to
OFKernelEventObserver_LockedQueue, which is now used for select and
poll, but skipped for kqueue and epoll, as they natively support changes
from another thread.

This fixes the problem that removing an object is delayed until the next
observe call - at which point it might have already been closed, meaning
the fd is no longer available. This was mainly a problem with kqueue, as
closing the fd already removed it from the kqueue, which then resulted
in an error being returned when trying to manually remove the fd from
the kqueue. file: [3ad5dffb1b] check-in: [e9b4700cb6] user: js, branch: trunk, size: 5123 [annotate] [blame] [check-ins using] [diff]

This was necessary because select(), poll() and kevent() on FreeBSD and
OS X would sometimes return 0 events, even if there are some, and
sometimes return the correct number of events that were pending, meaning
the number of events returned is unreliable. To make things worse,
whether it returns 0 or the number of events that were pending is
completely non-deterministic on both FreeBSD and OS X (running the same
tests multiple times in a row would make it sometimes work and sometimes
fail).

In order to prevent code from depending on the return value of
-[observeForTimeInterval:] (which would depend on select(), poll() and
kevent() returning the correct number), OFKernelObserver no longer
returns whether there were pending events. It is expected that
-[observe] or -[observeForTimeInterval:] is just called in a loop as
long as events should be handled.

The tests have been changed as well to reflect this. What they do now is
set a deadline and call -[observeForTimeInterval:] with a small timeout
in a loop until the deadline is reached or all events have been handled.

Note: DragonFlyBSD has not been tested, but will most likely behave like
FreeBSD and OS X. file: [306f8337d7] check-in: [220513a3f5] user: js, branch: trunk, size: 5089 [annotate] [blame] [check-ins using] [diff]

The old behaviour where the exception would access errno directly on
creation of the exception was very fragile. The two main problems with
it were that sometimes it would pick up an errno even though none had
been set and in other cases that when the exception was created errno
had already been overridden.

This also greatly increases errno handling on Win32, especially in
conjunction with sockets. It can still be improved further, though. file: [d49b28d198] check-in: [62e2de30b9] user: js, branch: trunk, size: 4432 [annotate] [blame] [check-ins using] [diff]

Not retaining them caused kevent() to be called on an invalid fd. file: [70736e006a] check-in: [1dbe9a4e4e] user: js, branch: trunk, size: 4137 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [76859e1d9d] check-in: [13ee56edf3] user: js, branch: trunk, size: 4845 [annotate] [blame] [check-ins using] [diff]

Removed file descriptors were returned in the event list with EBADF if
the file descriptor has been closed before removing them. Interpreting
that as a read event caused problems, as the file descriptor could not
be mapped to an object anymore, thus the entry in the event list is
skipped now if there was a EBADF error. file: [79faaa634a] check-in: [41ca862453] user: js, branch: trunk, size: 4888 [annotate] [blame] [check-ins using] [diff]

It is no longer limited to streams now. file: [d4951ca160] check-in: [c694569d86] user: js, branch: trunk, size: 3880 [annotate] [blame] [check-ins using] [diff]