Differences From Artifact [7f61e0c7f4]:
- File src/exceptions/OFSetOptionFailedException.h — part of check-in [cfd374b906] at 2015-01-03 20:57:18 on branch trunk — Update copyright (user: js, size: 1634) [annotate] [blame] [check-ins using]
To Artifact [de749ff86f]:
- File
src/exceptions/OFSetOptionFailedException.h
— part of check-in
[62e2de30b9]
at
2015-02-16 08:39:17
on branch trunk
— Explicitly pass errno to exceptions
The old behaviour where the exception would access errno directly on
creation of the exception was very fragile. The two main problems with
it were that sometimes it would pick up an errno even though none had
been set and in other cases that when the exception was created errno
had already been overridden.This also greatly increases errno handling on Win32, especially in
conjunction with sockets. It can still be improved further, though. (user: js, size: 1954) [annotate] [blame] [check-ins using]
︙ | ︙ | |||
23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 | * OFSetOptionFailedException.h ObjFW/OFSetOptionFailedException.h * * @brief An exception indicating that setting an option for a stream failed. */ @interface OFSetOptionFailedException: OFException { OFStream *_stream; } #ifdef OF_HAVE_PROPERTIES @property (readonly, retain) OFStream *stream; #endif /*! * @brief Creates a new, autoreleased set option failed exception. * * @param stream The stream for which the option could not be set * @return A new, autoreleased set option failed exception */ | > > > | > > | > > > > > > > > | 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 | * OFSetOptionFailedException.h ObjFW/OFSetOptionFailedException.h * * @brief An exception indicating that setting an option for a stream failed. */ @interface OFSetOptionFailedException: OFException { OFStream *_stream; int _errNo; } #ifdef OF_HAVE_PROPERTIES @property (readonly, retain) OFStream *stream; @property (readonly) int errNo; #endif /*! * @brief Creates a new, autoreleased set option failed exception. * * @param stream The stream for which the option could not be set * @param errNo The errno of the error * @return A new, autoreleased set option failed exception */ + (instancetype)exceptionWithStream: (OFStream*)stream errNo: (int)errNo; /*! * @brief Initializes an already allocated set option failed exception. * * @param stream The stream for which the option could not be set * @param errNo The errno of the error * @return An initialized set option failed exception */ - initWithStream: (OFStream*)stream errNo: (int)errNo; /*! * @brief Returns the stream for which the option could not be set. * * @return The stream for which the option could not be set */ - (OFStream*)stream; /*! * @brief Returns the errno from when the exception was created. * * @return The errno from when the exception was created */ - (int)errNo; @end |