Artifact ee03dade0c412492db1fe1e9a3e20005fe04623cec695c1a69b5748ff30f8367:
- File
src/exceptions/OFStillLockedException.m
— part of check-in
[3d16a30f41]
at
2013-06-22 12:12:36
on branch trunk
— Rework exceptions.
This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. (user: js, size: 1307) [annotate] [blame] [check-ins using]
/* * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013 * Jonathan Schleifer <js@webkeks.org> * * All rights reserved. * * This file is part of ObjFW. It may be distributed under the terms of the * Q Public License 1.0, which can be found in the file LICENSE.QPL included in * the packaging of this file. * * Alternatively, it may be distributed under the terms of the GNU General * Public License, either version 2 or 3, which can be found in the file * LICENSE.GPLv2 or LICENSE.GPLv3 respectively included in the packaging of this * file. */ #include "config.h" #import "OFStillLockedException.h" #import "OFString.h" #import "common.h" @implementation OFStillLockedException + (instancetype)exceptionWithLock: (id <OFLocking>)lock { return [[[self alloc] initWithLock: lock] autorelease]; } - initWithLock: (id <OFLocking>)lock { self = [super init]; _lock = [lock retain]; return self; } - (void)dealloc { [_lock release]; [super dealloc]; } - (OFString*)description { if (_lock != nil) return [OFString stringWithFormat: @"Deallocation of a lock of type %@ even though it was " @"still locked!", [_lock class]]; else return @"Deallocation of a lock even though it was still " @"locked!"; } - (id <OFLocking>)lock { OF_GETTER(_lock, false) } @end