Artifact ba733f14be28cee57db2590a85b8baaf1efee276355793d6fbfd1794f07528a2:
- File
src/macros.h
- 2012-12-06 00:14:47 — part of check-in [ac51f5f0cf] on branch trunk — Improve -[hash] of OFNumber and OFObject. (user: js, size: 8886) [annotate] [blame] [check-ins using]
-
2012-12-07 13:57:13
— part of check-in
[6712442fad]
on branch trunk
— Revert several OFHashMap related commits.
This reverts:
* "Add a per-hashtable seed."
(cd49c7fcb4b8dca62dccdbf6545d37d86b639eef)
* "OFMapTable: Reseed on resize."
(5b545165691cd9ad838c9125b02ff7c857bd4b99)
* "Add of_random()."
(9810f191b4e8c1612e7e55095c87e589660fbdba)
* "OFMapTable: Rotate hash by a random number of bits"
(3bef412217232d01f202794f7175c130afa1df8f)It turned out that these were slowing down all classes based on
OFHashMap significantly. As there is still no proof that the seeded
one-at-a-time hash is vulnerable to DoS, these changes were overly
paranoid. While overly paranoid is usually ok, it is not if it severely
impacts performance. (user: js, size: 8886) [annotate] [blame] [check-ins using]