Index: src/objc_sync.m ================================================================== --- src/objc_sync.m +++ src/objc_sync.m @@ -9,11 +9,11 @@ * the packaging of this file. */ #include "config.h" -#include +#include #include #include #ifndef _WIN32 #include @@ -71,21 +71,12 @@ mutex_unlock(pthread_mutex_t *m) { return (pthread_mutex_unlock(m) ? NO : YES); } -static OF_INLINE BOOL -thread_is_current(pthread_t t) -{ - return (pthread_equal(t, pthread_self()) ? YES : NO); -} - -static OF_INLINE pthread_t -thread_current() -{ - return pthread_self(); -} +#define thread_is_current(t) pthread_equal(t, pthread_self()) +#define thread_current() pthread_self() #else static OF_INLINE BOOL mutex_new(CRITICAL_SECTION *m) { InitializeCriticalSection(m); @@ -111,22 +102,21 @@ { LeaveCriticalSection(m); return YES; } -static OF_INLINE BOOL -thread_is_current(DWORD t) -{ - return (t == GetCurrentThreadId() ? YES : NO); -} - -static OF_INLINE DWORD -thread_current() -{ - return GetCurrentThreadId(); -} +#define thread_is_current(t) (t == GetCurrentThreadId()) +#define thread_current() GetCurrentThreadId() #endif + +#define ERROR(f) \ + { \ + fprintf(stderr, "WARNING: %s failed in line %d!\n" \ + "WARNING: This might result in a race " \ + "condition!\n", f, __LINE__); \ + return 1; \ + } BOOL objc_sync_init() { return (mutex_new(&mutex) ? YES : NO); @@ -139,11 +129,11 @@ if (obj == nil) return 0; if (!mutex_lock(&mutex)) - return 1; + ERROR("mutex_lock(&mutex)"); for (i = num_locks - 1; i >= 0; i--) { if (locks[i].obj == obj) { if (thread_is_current(locks[i].thread)) locks[i].recursion++; @@ -151,45 +141,45 @@ /* Make sure objc_sync_exit doesn't free it */ locks[i].count++; /* Unlock so objc_sync_exit can return */ if (!mutex_unlock(&mutex)) - return 1; + ERROR("mutex_unlock(&mutex)"); if (!mutex_lock(&locks[i].mutex)) { mutex_unlock(&mutex); - return 1; + ERROR("mutex_lock(&locks[i].mutex"); } if (!mutex_lock(&mutex)) - return 1; + ERROR("mutex_lock(&mutex)"); assert(locks[i].recursion == 0); /* Update lock's active thread */ locks[i].thread = thread_current(); } if (!mutex_unlock(&mutex)) - return 1; + ERROR("mutex_unlock(&mutex)"); return 0; } } if (locks == NULL) { if ((locks = malloc(sizeof(struct locks_s))) == NULL) { mutex_unlock(&mutex); - return 1; + ERROR("malloc(...)"); } } else { struct locks_s *new_locks; if ((new_locks = realloc(locks, (num_locks + 1) * sizeof(struct locks_s))) == NULL) { mutex_unlock(&mutex); - return 1; + ERROR("realloc(...)"); } locks = new_locks; } @@ -198,22 +188,22 @@ locks[num_locks].recursion = 0; locks[num_locks].thread = thread_current(); if (!mutex_new(&locks[num_locks].mutex)) { mutex_unlock(&mutex); - return 1; + ERROR("mutex_new(&locks[num_locks].mutex"); } if (!mutex_lock(&locks[num_locks].mutex)) { mutex_unlock(&mutex); - return 1; + ERROR("mutex_lock(&locks[num_locks].mutex"); } num_locks++; if (!mutex_unlock(&mutex)) - return 1; + ERROR("mutex_unlock(&mutex)"); return 0; } int @@ -223,37 +213,37 @@ if (obj == nil) return 0; if (!mutex_lock(&mutex)) - return 1; + ERROR("mutex_lock(&mutex)"); for (i = num_locks - 1; i >= 0; i--) { if (locks[i].obj == obj) { if (locks[i].recursion > 0 && thread_is_current(locks[i].thread)) { locks[i].recursion--; if (!mutex_unlock(&mutex)) - return 1; + ERROR("mutex_unlock(&mutex)"); return 0; } if (!mutex_unlock(&locks[i].mutex)) { mutex_unlock(&mutex); - return 1; + ERROR("mutex_unlock(&locks[i].mutex)"); } locks[i].count--; if (locks[i].count == 0) { struct locks_s *new_locks = NULL; if (!mutex_free(&locks[i].mutex)) { mutex_unlock(&mutex); - return 1; + ERROR("mutex_free(&locks[i].mutex"); } num_locks--; locks[i] = locks[num_locks]; @@ -262,21 +252,21 @@ new_locks = NULL; } else if ((new_locks = realloc(locks, num_locks * sizeof(struct locks_s))) == NULL) { mutex_unlock(&mutex); - return 1; + ERROR("realloc(...)"); } locks = new_locks; } if (!mutex_unlock(&mutex)) - return 1; + ERROR("mutex_unlock(&mutex)"); return 0; } } mutex_unlock(&mutex); - return 1; + ERROR("objc_sync_exit()"); }