Overview
| Comment: | Fix nullability issues found by clang-analyzer |
|---|---|
| Downloads: | Tarball | ZIP archive | SQL archive |
| Timelines: | family | ancestors | descendants | both | trunk |
| Files: | files | file ages | folders |
| SHA3-256: |
d93bcda0b2935a28a7b89e2bca865b3c |
| User & Date: | js on 2023-08-25 23:32:14 |
| Other Links: | manifest | tags |
Context
|
2023-08-26
| ||
| 10:44 | ofhttp: Add error message for failed TLS handshake (check-in: 579dd0a7ee user: js tags: trunk) | |
|
2023-08-25
| ||
| 23:32 | Fix nullability issues found by clang-analyzer (check-in: d93bcda0b2 user: js tags: trunk) | |
| 17:02 | Fix build on Windows (check-in: 5f897cae6d user: js tags: trunk) | |
Changes
Modified src/OFHTTPResponse.m from [dd8060da94] to [089b720c12].
| ︙ | ︙ | |||
210 211 212 213 214 215 216 | length: length - last]; value = value.stringByDeletingTrailingWhitespaces; if ([name isEqual: @"charset"]) charset = value; } | > > | | | < > | 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 |
length: length - last];
value = value.stringByDeletingTrailingWhitespaces;
if ([name isEqual: @"charset"])
charset = value;
}
ret = OFStringEncodingAutodetect;
if (charset != nil) {
@try {
ret = OFStringEncodingParseName(charset);
} @catch (OFInvalidArgumentException *e) {
}
}
return ret;
}
@implementation OFHTTPResponse
@synthesize statusCode = _statusCode, headers = _headers;
|
| ︙ | ︙ |
Modified src/OFXMLParser.h from [e18365e7c0] to [a3f7893b62].
| ︙ | ︙ | |||
39 40 41 42 43 44 45 | * * @param parser The parser which found a processing instruction * @param target The target of the processing instruction * @param text The text of the processing instruction */ - (void)parser: (OFXMLParser *)parser foundProcessingInstructionWithTarget: (OFString *)target | | | 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 | * * @param parser The parser which found a processing instruction * @param target The target of the processing instruction * @param text The text of the processing instruction */ - (void)parser: (OFXMLParser *)parser foundProcessingInstructionWithTarget: (OFString *)target text: (nullable OFString *)text; /** * @brief This callback is called when the XML parser found the start of a new * tag. * * @param parser The parser which found a new tag * @param name The name of the tag which just started |
| ︙ | ︙ |
Modified src/exceptions/OFBindUNIXSocketFailedException.h from [ada45067d6] to [0339e89f3b].
| ︙ | ︙ | |||
39 40 41 42 43 44 45 | * @brief Creates a new, autoreleased bind UNIX socket failed exception. * * @param path The path on which binding failed * @param socket The socket which could not be bound * @param errNo The errno of the error that occurred * @return A new, autoreleased bind UNIX socket failed exception */ | | | | 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 | * @brief Creates a new, autoreleased bind UNIX socket failed exception. * * @param path The path on which binding failed * @param socket The socket which could not be bound * @param errNo The errno of the error that occurred * @return A new, autoreleased bind UNIX socket failed exception */ + (instancetype)exceptionWithPath: (nullable OFString *)path socket: (id)socket errNo: (int)errNo; + (instancetype)exceptionWithSocket: (id)socket errNo: (int)errNo OF_UNAVAILABLE; /** * @brief Initializes an already allocated bind UNIX socket failed exception. * * @param path The path on which binding failed * @param socket The socket which could not be bound * @param errNo The errno of the error that occurred * @return An initialized bind UNIX socket failed exception */ - (instancetype)initWithPath: (nullable OFString *)path socket: (id)socket errNo: (int)errNo OF_DESIGNATED_INITIALIZER; - (instancetype)initWithSocket: (id)socket errNo: (int)errNo OF_UNAVAILABLE; @end OF_ASSUME_NONNULL_END |
Modified src/runtime/private.h from [7ee10f418d] to [af11dd9f17].
| ︙ | ︙ | |||
35 36 37 38 39 40 41 | Class _Nullable superclass; const char *_Nonnull name; unsigned long version; unsigned long info; long instanceSize; struct objc_ivar_list *_Nullable ivars; struct objc_method_list *_Nullable methodList; | | | 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 | Class _Nullable superclass; const char *_Nonnull name; unsigned long version; unsigned long info; long instanceSize; struct objc_ivar_list *_Nullable ivars; struct objc_method_list *_Nullable methodList; struct objc_dtable *_Nullable dTable; Class _Nullable *_Nullable subclassList; void *_Nullable siblingClass; struct objc_protocol_list *_Nullable protocols; void *_Nullable GCObjectType; unsigned long ABIVersion; int32_t *_Nonnull *_Nullable ivarOffsets; struct objc_property_list *_Nullable propertyList; |
| ︙ | ︙ |
Modified utils/ofarc/Archive.h from [41439c3fd1] to [ca9ef12a7d].
| ︙ | ︙ | |||
16 17 18 19 20 21 22 | #import "OFObject.h" #import "OFFile.h" #import "OFArray.h" OF_ASSUME_NONNULL_BEGIN @protocol Archive <OFObject> | | | | 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 | #import "OFObject.h" #import "OFFile.h" #import "OFArray.h" OF_ASSUME_NONNULL_BEGIN @protocol Archive <OFObject> + (instancetype)archiveWithPath: (nullable OFString *)path stream: (OF_KINDOF(OFStream *))stream mode: (OFString *)mode encoding: (OFStringEncoding)encoding; - (instancetype)initWithPath: (nullable OFString *)path stream: (OF_KINDOF(OFStream *))stream mode: (OFString *)mode encoding: (OFStringEncoding)encoding; - (void)listFiles; - (void)extractFiles: (OFArray OF_GENERIC(OFString *) *)files; - (void)printFiles: (OFArray OF_GENERIC(OFString *) *)files; @optional - (void)addFiles: (OFArray OF_GENERIC(OFString *) *)files; @end OF_ASSUME_NONNULL_END |
Modified utils/ofarc/OFArc.m from [5c5bcb3795] to [732031f459].
| ︙ | ︙ | |||
484 485 486 487 488 489 490 | help(OFStdErr, true, 1); break; } [OFApplication terminateWithStatus: _exitStatus]; } | | > > | 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 |
help(OFStdErr, true, 1);
break;
}
[OFApplication terminateWithStatus: _exitStatus];
}
- (id <Archive>)openArchiveWithPath: (OFString *)path_
type: (OFString *)type
mode: (char)mode
encoding: (OFStringEncoding)encoding
{
/* To make clang-analyzer happy about assigning nil to path later. */
OFString *path = path_;
OFString *modeString, *fileModeString;
OFStream *file = nil;
id <Archive> archive = nil;
[_archivePath release];
_archivePath = [path copy];
|
| ︙ | ︙ | |||
643 644 645 646 647 648 649 | writingNotSupported(type); goto error; } return archive; error: | | | | 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 |
writingNotSupported(type);
goto error;
}
return archive;
error:
if (mode == 'c' && path != nil)
[[OFFileManager defaultManager] removeItemAtPath: path];
[OFApplication terminateWithStatus: 1];
abort();
}
- (bool)shouldExtractFile: (OFString *)fileName
outFileName: (OFString *)outFileName
{
OFString *line;
|
| ︙ | ︙ |