ObjFW  History of src/OFKernelEventObserver_poll.m of 07e630588d3cebb1

History of the file that is called src/OFKernelEventObserver_poll.m at check-in 07e630588d3cebb1

2019-06-17
02:33
Deleted: Remove underscores from class names (check-in: [17d57e01ff] user: js, branch: trunk, size: 0)
2019-03-08
00:35
[e0fcf68d56] part of check-in [bceb7ed4c9] Use dot syntax (check-in: [bceb7ed4c9] user: js, branch: trunk, size: 4730) [annotate] [blame] [check-ins using] [diff]
2019-01-03
19:13
[f7752f3f82] part of check-in [0509d7a844] Update copyright (check-in: [0509d7a844] user: js, branch: trunk, size: 4729) [annotate] [blame] [check-ins using] [diff]
2018-01-03
19:49
[a8b510bdb6] part of check-in [7e5c81e186] Update copyright notice (check-in: [7e5c81e186] user: js, branch: trunk, size: 4723) [annotate] [blame] [check-ins using] [diff]
2017-10-17
00:33
[5cc8f8bde7] part of check-in [2f4e0df8be] Do not use implicit method return types

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. (check-in: [2f4e0df8be] user: js, branch: trunk, size: 4700) [annotate] [blame] [check-ins using] [diff]

2017-07-22
20:50
[5ae2fd3232] part of check-in [c8f7b90082] Split OFDataArray into OFData and OFMutableData (check-in: [c8f7b90082] user: js, branch: trunk, size: 4686) [annotate] [blame] [check-ins using] [diff]
2017-05-21
21:28
[d87bf7dc93] part of check-in [6b77a5dd8b] Prefix private methods with of_ instead of OF_

This matches Apple's style. (check-in: [6b77a5dd8b] user: js, branch: trunk, size: 4689) [annotate] [blame] [check-ins using] [diff]

2017-01-09
17:36
[5c00bd3414] part of check-in [44f45c2e35] Update copyright

Forgot to add 2017, even though I already did quite some changes in
2017. (check-in: [44f45c2e35] user: js, branch: trunk, size: 4689) [annotate] [blame] [check-ins using] [diff]

2016-05-06
20:39
[d2e1efd541] part of check-in [2a2e17d8d0] Enable -Wsign-compare (check-in: [2a2e17d8d0] user: js, branch: trunk, size: 4683) [annotate] [blame] [check-ins using] [diff]
2016-03-20
14:19
[4d1ce4c7a3] part of check-in [85917ea0dd] Use the locked queue for kqueue and epoll as well

_readObjects must only be changed from the thread running the observer
and not from a thread adding or removing objects to observe. This is
already handled by the locked queue used by poll and select, so the best
way to solve this is to use the locked queue for kqueue and epoll as
well. (check-in: [85917ea0dd] user: js, branch: 0.8, size: 4656) [annotate] [blame] [check-ins using] [diff]

14:07
[faa844312a] part of check-in [45518ae7b7] Use the locked queue for kqueue and epoll as well

_readObjects must only be changed from the thread running the observer
and not from a thread adding or removing objects to observe. This is
already handled by the locked queue used by poll and select, so the best
way to solve this is to use the locked queue for kqueue and epoll as
well. (check-in: [45518ae7b7] user: js, branch: trunk, size: 4667) [annotate] [blame] [check-ins using] [diff]

12:05
[7dfa12138b] part of check-in [b84490ab4f] Never block when the read buffer is non-empty

This was broken by 88f2f03. The problem only existed when something was
in the read buffer, but not processed completely, as after processing
the read buffer, it would go on to wait for data - but since not the
entire read buffer had been processed, it meant there was still data
left there that needed to be handled first. (check-in: [b84490ab4f] user: js, branch: 0.8, size: 4526) [annotate] [blame] [check-ins using] [diff]

11:57
[365c8917fd] part of check-in [7ae17af9f0] Never block when the read buffer is non-empty

This was broken by 88f2f03. The problem only existed when something was
in the read buffer, but not processed completely, as after processing
the read buffer, it would go on to wait for data - but since not the
entire read buffer had been processed, it meant there was still data
left there that needed to be handled first. (check-in: [7ae17af9f0] user: js, branch: trunk, size: 4537) [annotate] [blame] [check-ins using] [diff]

2016-02-21
15:37
[bb3d801549] part of check-in [e0b9167693] Make use of C99-style for loops (check-in: [e0b9167693] user: js, branch: trunk, size: 4575) [annotate] [blame] [check-ins using] [diff]
2016-01-03
00:43
[71e7c91e05] part of check-in [cec0f072f8] Update copyright

While at it, also update the mail address. (check-in: [cec0f072f8] user: js, branch: 0.8, size: 4564) [annotate] [blame] [check-ins using] [diff]

00:41
[4a4c51ed64] part of check-in [2a27cf3000] Update copyright

While at it, also update the mail address. (check-in: [2a27cf3000] user: js, branch: trunk, size: 4563) [annotate] [blame] [check-ins using] [diff]

2015-12-29
21:42
[b1a6d909cb] part of check-in [c5f0c5f9ba] Refactor OFKernelEventObserver

This moves the locked queue for actions to
OFKernelEventObserver_LockedQueue, which is now used for select and
poll, but skipped for kqueue and epoll, as they natively support changes
from another thread.

This fixes the problem that removing an object is delayed until the next
observe call - at which point it might have already been closed, meaning
the fd is no longer available. This was mainly a problem with kqueue, as
closing the fd already removed it from the kqueue, which then resulted
in an error being returned when trying to manually remove the fd from
the kqueue. (check-in: [c5f0c5f9ba] user: js, branch: 0.8, size: 4560) [annotate] [blame] [check-ins using] [diff]

21:33
[66c27474d9] part of check-in [e9b4700cb6] Refactor OFKernelEventObserver

This moves the locked queue for actions to
OFKernelEventObserver_LockedQueue, which is now used for select and
poll, but skipped for kqueue and epoll, as they natively support changes
from another thread.

This fixes the problem that removing an object is delayed until the next
observe call - at which point it might have already been closed, meaning
the fd is no longer available. This was mainly a problem with kqueue, as
closing the fd already removed it from the kqueue, which then resulted
in an error being returned when trying to manually remove the fd from
the kqueue. (check-in: [e9b4700cb6] user: js, branch: trunk, size: 4559) [annotate] [blame] [check-ins using] [diff]

2015-10-19
22:15
[14102c57fc] part of check-in [1ba08eebc5] Add platform.h & make platform defines consistent (check-in: [1ba08eebc5] user: js, branch: trunk, size: 4595) [annotate] [blame] [check-ins using] [diff]
2015-10-04
11:11
[85d67fd51b] part of check-in [4cecf82254] Special cases for the Wii's weird network stack

This fixes the tests on Wii. (check-in: [4cecf82254] user: js, branch: trunk, size: 4596) [annotate] [blame] [check-ins using] [diff]

2015-05-16
18:28
[948bc3a27e] part of check-in [13d72034ed] OFKernelEventObserver_poll: Exception -> assert (check-in: [13d72034ed] user: js, branch: trunk, size: 4484) [annotate] [blame] [check-ins using] [diff]
2015-05-09
18:13
[6db686d146] part of check-in [220513a3f5] More OFKernelEventObserver refactoring

This was necessary because select(), poll() and kevent() on FreeBSD and
OS X would sometimes return 0 events, even if there are some, and
sometimes return the correct number of events that were pending, meaning
the number of events returned is unreliable. To make things worse,
whether it returns 0 or the number of events that were pending is
completely non-deterministic on both FreeBSD and OS X (running the same
tests multiple times in a row would make it sometimes work and sometimes
fail).

In order to prevent code from depending on the return value of
-[observeForTimeInterval:] (which would depend on select(), poll() and
kevent() returning the correct number), OFKernelObserver no longer
returns whether there were pending events. It is expected that
-[observe] or -[observeForTimeInterval:] is just called in a loop as
long as events should be handled.

The tests have been changed as well to reflect this. What they do now is
set a deadline and call -[observeForTimeInterval:] with a small timeout
in a loop until the deadline is reached or all events have been handled.

Note: DragonFlyBSD has not been tested, but will most likely behave like
FreeBSD and OS X. (check-in: [220513a3f5] user: js, branch: trunk, size: 4504) [annotate] [blame] [check-ins using] [diff]

2015-05-04
20:34
[b1989e4bd7] part of check-in [bbe4040126] Refactor OFKernelEventObserver (check-in: [bbe4040126] user: js, branch: trunk, size: 4703) [annotate] [blame] [check-ins using] [diff]
2015-04-26
10:40
[87d84638ba] part of check-in [bd05eb8de3] OFKernelEventObserver: Rename a private method (check-in: [bd05eb8de3] user: js, branch: trunk, size: 4043) [annotate] [blame] [check-ins using] [diff]
2015-04-14
19:34
[c6c9ef266d] part of check-in [5924cc3a92] OFKernelEventObserver*.m: Minor cleanup (check-in: [5924cc3a92] user: js, branch: trunk, size: 4037) [annotate] [blame] [check-ins using] [diff]
2015-04-12
20:04
[5e6cfe7441] part of check-in [97da88f926] Add OFObserveFailedException (check-in: [97da88f926] user: js, branch: trunk, size: 3995) [annotate] [blame] [check-ins using] [diff]
2015-01-03
20:57
[3c5b778962] part of check-in [cfd374b906] Update copyright (check-in: [cfd374b906] user: js, branch: trunk, size: 3800) [annotate] [blame] [check-ins using] [diff]
2014-08-22
19:09
[ab4899dd72] part of check-in [1dbe9a4e4e] Retain sockets until after removal from observer

Not retaining them caused kevent() to be called on an invalid fd. (check-in: [1dbe9a4e4e] user: js, branch: trunk, size: 3794) [annotate] [blame] [check-ins using] [diff]

2014-06-21
21:43
[daca96d316] part of check-in [13ee56edf3] Move all macros from OFObject.h to macros.h

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. (check-in: [13ee56edf3] user: js, branch: trunk, size: 3772) [annotate] [blame] [check-ins using] [diff]

2014-02-18
00:22
[0822c7de55] part of check-in [f9d12201f8] Move around a few defines to be more consistent (check-in: [f9d12201f8] user: js, branch: trunk, size: 3815) [annotate] [blame] [check-ins using] [diff]
2014-01-29
15:54
[b0a53ca94b] part of check-in [c694569d86] Generalize OFKernelEventObserver

It is no longer limited to streams now. (check-in: [c694569d86] user: js, branch: trunk, size: 3815) [annotate] [blame] [check-ins using] [diff]

2014-01-28
22:50
Added: [928947a9f6] part of check-in [96e20b8093] Rename OFStreamObserver -> OFKernelEventObserver (check-in: [96e20b8093] user: js, branch: trunk, size: 4055) [annotate] [blame] [check-ins using]