ObjFW  History of src/OFDictionary.m of efca87b509d645e6

The Apple runtime can store the retain count in isa, so
retaining/releasing an object would suddenly make it seem like it was
mutated. file: [34eb84dfb7] check-in: [27d8eb922d] user: js, branch: trunk, size: 15965 [annotate] [blame] [check-ins using] [diff]

While the idea sounds nice that the tag name is the class, this means the
serialization includes whether something is mutable or immutable. This means
doing as much as making something immutable changes the serialization, which
can then cause issues after being deserialized. file: [12d43fb634] check-in: [6ce0093f8d] user: js, branch: trunk, size: 15933 [annotate] [blame] [check-ins using] [diff]

This uses the same format as OFEnsure(). file: [cbf5abac37] check-in: [c86b8f10f0] user: js, branch: trunk, size: 18498 [annotate] [blame] [check-ins using] [diff]

It duplicates the functionality of -[OFMutableURI setQueryDictionary:]. file: [9689ae0f89] check-in: [f1bf64ca9f] user: js, branch: trunk, size: 18517 [annotate] [blame] [check-ins using] [diff]

This is only migrating some places, others will be migrated as they are
touched. file: [dca613f5bc] check-in: [a0fd103a0b] user: js, branch: trunk, size: 19395 [annotate] [blame] [check-ins using] [diff]

The internal hash is still 32 bit in most places, but this way, it is at
least not baked into the API and ABI and can be upgraded later, should
that ever be necessary. file: [505aa3e10f] check-in: [aeb403a1ed] user: js, branch: trunk, size: 19534 [annotate] [blame] [check-ins using] [diff]

This avoids leaking the enumerator when terminating the fast enumeration
early. file: [af6bd066da] check-in: [13864f512c] user: js, branch: trunk, size: 19464 [annotate] [blame] [check-ins using] [diff]

This is now unreserved + sub-delims from RFC 3986. file: [26c35d80f1] check-in: [4db6713bda] user: js, branch: trunk, size: 17287 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [21f0c3f7c0] check-in: [2f4e0df8be] user: js, branch: trunk, size: 17199 [annotate] [blame] [check-ins using] [diff]

This matches Apple's style. file: [d620b3bd51] check-in: [6b77a5dd8b] user: js, branch: trunk, size: 16217 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [e4842b5166] check-in: [4af49a13c3] user: js, branch: trunk, size: 16215 [annotate] [blame] [check-ins using] [diff]

These are usually not used, as OFDictionary_hashtable and
OFMutableDictionary_hashtable are used instead. However, they are used
if someone creates their own subclass of OFDictionary /
OFMutableDictionary. As they are rarely used in production, it is
important to run all tests on them. file: [537dc67d0c] check-in: [cfd54bd090] user: js, branch: trunk, size: 16186 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [79c3103a2a] check-in: [44f45c2e35] user: js, branch: trunk, size: 16187 [annotate] [blame] [check-ins using] [diff]

If this is only overridden in OFMutableDictionary, this would lead to
inconsistent behavior, as it could be called on an OFDictionary as well
due to the fact that -[setValue:forKey:] is defined in OFObject.
Instead, if the dictionary is immutable, an OFUndefinedKeyException is
thrown. file: [034710c781] check-in: [f816d1ec7c] user: js, branch: trunk, size: 16237 [annotate] [blame] [check-ins using] [diff]

If the key starts with an @, the @ is stripped and the super method is
called. Otherwise, this is equivalent to -[objectForKey:] /
-[setValue:forKey:]. file: [3204259101] check-in: [cbacea7ca3] user: js, branch: trunk, size: 15678 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [a8e28196f4] check-in: [cec0f072f8] user: js, branch: 0.8, size: 15366 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [8f1dc3b962] check-in: [2a27cf3000] user: js, branch: trunk, size: 15346 [annotate] [blame] [check-ins using] [diff]

Now that we can require GCC >= 4.6, we no longer need to fall back to
using a category on old compilers. file: [4d31711ac3] check-in: [2aca549d60] user: js, branch: trunk, size: 15342 [annotate] [blame] [check-ins using] [diff]

Now that we require GCC >= 4.6 anyway, there's no more reason to not use
it anymore. file: [f9d2ed8c00] check-in: [6b13727ce0] user: js, branch: trunk, size: 15361 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [cc9eebbd4d] check-in: [13ee56edf3] user: js, branch: trunk, size: 15356 [annotate] [blame] [check-ins using] [diff]

After all, this might (and does for OFArray_adjacent!) return an
internal representation that must not be changed, so changes should be
prevented at compile-time. file: [64a914391d] check-in: [68d32a92c1] user: js, branch: trunk, size: 15400 [annotate] [blame] [check-ins using] [diff]

This also adds OF_JSON_REPRESENTATION_PRETTY. file: [a7500a2644] check-in: [eaa612ad50] user: js, branch: trunk, size: 15018 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [65bfd85485] check-in: [3d16a30f41] user: js, branch: trunk, size: 14079 [annotate] [blame] [check-ins using] [diff]

No support for extensions yet.

This obsoletes BinaryPack. file: [903db74406] check-in: [cba771824e] user: js, branch: trunk, size: 14161 [annotate] [blame] [check-ins using] [diff]

This is possible now since +[OFArray arrayWithCapacity:] has been added. file: [ff91f774b0] check-in: [bff98a6244] user: js, branch: trunk, size: 14158 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [b5ab4c9ae4] check-in: [c5ef582958] user: js, branch: trunk, size: 14518 [annotate] [blame] [check-ins using] [diff]

This greatly improves performance, as it gets rid of the overhead of
OFAutoreleasePool. file: [5774d8a182] check-in: [1255f3a11a] user: js, branch: trunk, size: 12775 [annotate] [blame] [check-ins using] [diff]

Also fix a bug where OFBigDataArray would waste memory. file: [170550a25e] check-in: [f7576a66ce] user: js, branch: trunk, size: 12743 [annotate] [blame] [check-ins using] [diff]

This is required for the new array literals. file: [29eff2abae] check-in: [008be86a16] user: js, branch: trunk, size: 11891 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [9dbdf6b2a1] check-in: [e1e7ffa903] user: js, branch: trunk, size: 11019 [annotate] [blame] [check-ins using] [diff]

This would make it impossible to use autoreleased objects after the
block has been executed without manually retaining and releasing them. file: [39169fee1e] check-in: [bfb7745f95] user: js, branch: trunk, size: 20540 [annotate] [blame] [check-ins using] [diff]

Mutations during enumerations using blocks are now always detected,
even for methods such as -[filteredDictionaryUsingBlock:]. file: [95bb1cf3d0] check-in: [6214a3be25] user: js, branch: trunk, size: 20656 [annotate] [blame] [check-ins using] [diff]

It is still implemented by all classes implementing OFCollection so far,
but new classes are not required to implement it anymore.

This is required to add OFCountedSet later, which can't support it. file: [58ee7d242e] check-in: [8ff55bf218] user: js, branch: trunk, size: 19689 [annotate] [blame] [check-ins using] [diff]

When a key already exists, it means the precalculated count is wrong.
Therefore, decrease count if the key already exists. file: [0776706270] check-in: [448a35dd9b] user: js, branch: 0.5, size: 15980 [annotate] [blame] [check-ins using] [diff]

When a key already exists, it means the precalculated count is wrong.
Therefore, decrease count if the key already exists. file: [10ad77a11e] check-in: [50457cd1fd] user: js, branch: trunk, size: 19847 [annotate] [blame] [check-ins using] [diff]

This way, we don't need a new parser and don't use a new format. file: [5f45c17283] check-in: [494dca4ae4] user: js, branch: trunk, size: 18060 [annotate] [blame] [check-ins using] [diff]

We assume now that every object understands retain, release, etc. so
that we can weaken the type from OFObject* to id. This makes it
possible to use different root object classes. file: [f2f7830f20] check-in: [e2b06423e0] user: js, branch: trunk, size: 14253 [annotate] [blame] [check-ins using] [diff]

This increases performance and should not need to be handled by the
programmer in most cases. file: [3d989f9035] check-in: [d4b379485a] user: js, branch: trunk, size: 14017 [annotate] [blame] [check-ins using] [diff]

ivars are now named like this: thisIsAnIVar. If an accessor exists for
the ivar, the ivar is named like the accessor. This is required for
@property to work. file: [0083ef4288] check-in: [37db8f0fb3] user: js, branch: trunk, size: 14033 [annotate] [blame] [check-ins using] [diff]

Changesets:
* b95fcaa6d694
* 804c68d222b4
* da8cd738da3d
* 1109d5ce3419
* d03f5c1ca95d
* 2a7017722165
* 4fccdc79eeb7
* d228149fbc04
* 8782d412a4a6 file: [b35f643373] check-in: [b91a8283fe] user: js, branch: 0.2, size: 12381 [annotate] [blame] [check-ins using] [diff]

This includes the following revisions:
* f91d3a18db7b
* dbe7a578af42
* 95545a36ed0e
* 7806af1b171a
* cacc8353b5c2 file: [7dfec004d5] check-in: [98f171212d] user: js, branch: 0.1, size: 10850 [annotate] [blame] [check-ins using] [diff]

The new implementation is easier to use as it does automatic resizing,
but therefore it's not realtime-capable anymore. The new implementation
should also be a little bit faster.

I decided to change the implementation as only very few need a
realtime-capable dictionary and those few will most likely write their
own implementation for their specific case anyway.

As the new implementation no longer uses OFList, this also made it
possible to remove a hack from OFList. file: [3ddd956ea4] check-in: [bbf1f79b8f] user: js, branch: trunk, size: 5389 [annotate] [blame] [check-ins using] [diff]

OFDictionary:
* More optimized way to internally store the data.
* Faster resizing of dictionaries (no rehashing anymore).

OFIterator:
* Return a key/object pair rather than first the key and then the
object.

OFList:
* Support for list objects with a different size so you can have your
own list object structs. file: [9fa2393e86] check-in: [24ecf55297] user: js, branch: trunk, size: 7621 [annotate] [blame] [check-ins using] [diff]

OFExceptions:
* OFNoMemException to OFOutOfMemoryException.
* OFMemNotPartOfObjException to OFMemoryNotPartOfObjectException.

OFObject:
* -[addItemToMemoryPool:] to -[addMemoryToPool:].
* -[allocWithSize:] to -[allocMemoryWithSize:].
* -[allocNItems:withSize] to -[allocMemoryForNItems:withSize:].
* -[resizeMem:toSize] to -[resizeMemory:toSize:].
* -[resizeMem:toNItems:withSize:] to
-[resizeMemoryToNItems:withSize:].
* -[freeMem] to -[freeMemory:].

OFString:
* -[urlencode] to -[urlEncodedString].
* -[urldecode] to -[urlDecodedString]. file: [2b0ed74966] check-in: [033054ad75] user: js, branch: trunk, size: 6750 [annotate] [blame] [check-ins using] [diff]

OFArray:
* Rename - object: to - objectAtIndex:.

OFDataArray:
* Rename - item: to - itemAtIndex:.

OFDictionary:
* Rename - get: to - objectForKey:.
* Rename - set:to: to - setObject:forKey:.
* Rename - remove: to - removeObjectForKey:. file: [232cbc945d] check-in: [a29d403286] user: js, branch: trunk, size: 6727 [annotate] [blame] [check-ins using] [diff]

When using OFObject*, you have to cast to get rid of a warning when
calling methods on the returned object. file: [8b4c9a4782] check-in: [9338313079] user: js, branch: trunk, size: 4574 [annotate] [blame] [check-ins using] [diff]

It seems super has the wrong type (struct _objc_super*) inside a
@try block. file: [e7cc2d1d1a] check-in: [06ad922132] user: js, branch: trunk, size: 3416 [annotate] [blame] [check-ins using] [diff]

Reason is that - free might free stuff which is allocated during the
initialization, which might not be allocated when an error occurred. file: [84c38f0c0c] check-in: [e9d48d0beb] user: js, branch: trunk, size: 3146 [annotate] [blame] [check-ins using] [diff]

getMemWithSize: -> allocWithSize:
getMemForNItems:ofSize: -> allocNItems:withSize:
resizeMem:toNItems:ofSize: -> resizeMem:toNItems:withSize: file: [a34c760d2b] check-in: [e959fed010] user: js, branch: trunk, size: 3143 [annotate] [blame] [check-ins using] [diff]

Since we don't use Object anymore and define isa in OFObject, we can
rely on it. file: [ae861b76c6] check-in: [139591afe1] user: js, branch: trunk, size: 2742 [annotate] [blame] [check-ins using] [diff]

This allows libobjfw to run on ObjC2-only runtimes like the one on the
iPhone. However, it's still relying on objc_msgSendv for plugins, which
is unavailable in ObjC2-only runtimes, thus OFPlugins are unavailable
on the iPhone until I write a replacement for objc_msgSendv. file: [065f154d58] check-in: [cbdd534337] user: js, branch: trunk, size: 2751 [annotate] [blame] [check-ins using] [diff]