ObjFW  History of src/OFFile.m of ff29e35344764aa2

Just defining it isn't enough on QNX, it needs to have a value. file: [4b56e559f4] check-in: [fba60b6967] user: js, branch: trunk, size: 11995 [annotate] [blame] [check-ins using] [diff]

This uses the same format as OFEnsure(). file: [c784d31e2e] check-in: [c86b8f10f0] user: js, branch: trunk, size: 11893 [annotate] [blame] [check-ins using] [diff]

This doesn't work yet (it crashes on recvfrom), so it's not enabled in
configure for now. file: [6bda5c55f7] check-in: [a30a0ab261] user: js, branch: nintendo-switch, size: 11491 [annotate] [blame] [check-ins using] [diff]

With TYPEDEF_HIDES_STRUCT set, Doxygen properly handles anonymous
structs and enums that are typedef'd. file: [e28a8564db] check-in: [2fcf5a3052] user: js, branch: trunk, size: 11676 [annotate] [blame] [check-ins using] [diff]

This is only migrating some places, others will be migrated as they are
touched. file: [1933c9d596] check-in: [a0fd103a0b] user: js, branch: trunk, size: 11690 [annotate] [blame] [check-ins using] [diff]

The new names should be more accurate. file: [23492381a4] check-in: [627511b032] user: js, branch: trunk, size: 11823 [annotate] [blame] [check-ins using] [diff]

While it makes sense to wrap malloc and calloc to replace the error
checking with exceptions, it does not make sense to wrap free. file: [edd10634f5] check-in: [3d8286feee] user: js, branch: trunk, size: 11824 [annotate] [blame] [check-ins using] [diff]

This means refusing to close twice, calling -[close] from -[dealloc] and
not calling -[cancelAsyncRequests].

Calling -[cancelAsyncRequests] in -[close] is too dangerous, as -[close]
gets called by -[dealloc]: If the queue is the last reference to the
object, at the point where -[cancelAsyncRequests] removes it from the
queue, the object will start to deallocate and call into
-[cancelAsyncRequests] again, which is still in the middle of removing
it and now finds itself with an inconsistent state. file: [1f08d5d8ea] check-in: [3b43d51006] user: js, branch: trunk, size: 11853 [annotate] [blame] [check-ins using] [diff]

libauto loads the libraries too late. file: [4a58ba6ba6] check-in: [d71abc5366] user: js, branch: trunk, size: 12438 [annotate] [blame] [check-ins using] [diff]

This has been fixed upstream in amiga-gcc. file: [9880062333] check-in: [b31bd48f90] user: js, branch: trunk, size: 11427 [annotate] [blame] [check-ins using] [diff]

The reason for this is that, in theory, this also supports versions
older than 3. file: [994cdd90a3] check-in: [5831626f68] user: js, branch: trunk, size: 11489 [annotate] [blame] [check-ins using] [diff]

As we define the ABI, we can just replace BOOL with bool everywhere,
including in ObjFW itself. For the Apple platforms where BOOL and bool
are different, this is not a problem as BOOL and bool are passed and
returned the same way in the ABI.

This still defines BOOL to bool for compatibility, except on AmigaOS and
Wii, which both have its own BOOL type. file: [77e3c3a21e] check-in: [fe2cbe0021] user: js, branch: trunk, size: 10973 [annotate] [blame] [check-ins using] [diff]

When using self = [self init…], this already releases self on an
exception, so using it inside of a @try / @catch block that releases
self would lead to a double-release. file: [1cab20f522] check-in: [81156ee75a] user: js, branch: trunk, size: 11009 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [3ace3f34b9] check-in: [2f4e0df8be] user: js, branch: trunk, size: 10411 [annotate] [blame] [check-ins using] [diff]

This was an oversight when the b modes were removed. file: [44dc0ec6b9] check-in: [18d04d2fd4] user: js, branch: trunk, size: 10526 [annotate] [blame] [check-ins using] [diff]

This removes "b" for binary and always uses binary, as there is no good
reason to not use binary. file: [afef5a8ffe] check-in: [23e57c5040] user: js, branch: trunk, size: 11065 [annotate] [blame] [check-ins using] [diff]

This allows retrieving the number of bytes already written before the
write failed, allowing to retry without writing data that has already
been written. file: [72431db710] check-in: [2ae01218ef] user: js, branch: trunk, size: 11711 [annotate] [blame] [check-ins using] [diff]

The previous one didn't work, as the index was part of the handle, but
the index could change. file: [b2ec5b887b] check-in: [a9b2bd12eb] user: js, branch: trunk, size: 11334 [annotate] [blame] [check-ins using] [diff]

This removes several initializers that omitted the errNo. Removing those
forces to think about whether there is a meaningful errNo to set instead
of just omitting it. file: [89ce8091b7] check-in: [4f36894ce7] user: js, branch: trunk, size: 11089 [annotate] [blame] [check-ins using] [diff]

Instead, let reads return 0 and let writes append after the end. file: [c3e373372b] check-in: [f9cd4f9cab] user: js, branch: trunk, size: 10565 [annotate] [blame] [check-ins using] [diff]

This reduces the ifdef hell and makes much more sense, as with ixemul,
no native calls are allowed. file: [4cea821d7a] check-in: [c9621825fc] user: js, branch: trunk, size: 10653 [annotate] [blame] [check-ins using] [diff]

As a nice side effect, this adds a designated initializer to OFFile. file: [1d857a1710] check-in: [29403cc56a] user: js, branch: trunk, size: 10096 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [018b6789b8] check-in: [4af49a13c3] user: js, branch: trunk, size: 6625 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [c9a19755a7] check-in: [44f45c2e35] user: js, branch: trunk, size: 6619 [annotate] [blame] [check-ins using] [diff]

This singleton gives access to all things locale, including the ability
to get localized strings.

This also adds the OF_LOCALIZED() macro. Its first argument is an ID for
the string to be localized and its second argument is the fallback
string to be used if it cannot retrieve the localized string. Following
that are variable name / value pairs to be replaced in the localized
string.

Getting translated strings is not implemented yet: Instead, it always
uses the fallback string.

This also switches ofhttp to localized strings. file: [6d0086e491] check-in: [06bcb21fc7] user: js, branch: trunk, size: 6613 [annotate] [blame] [check-ins using] [diff]

Right now, this is only useful for OFTCPSocket, as this is the only
class so far not establishing the stream in the init method. However,
this adds the general infrastructure to allow reuse to all subclasses of
OFStream. file: [70abf75d98] check-in: [1de551cb5f] user: js, branch: trunk, size: 6627 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [adc8a96b76] check-in: [cec0f072f8] user: js, branch: 0.8, size: 26724 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [a34749abe1] check-in: [2a27cf3000] user: js, branch: trunk, size: 6610 [annotate] [blame] [check-ins using] [diff]

This makes it possible to add support for delegates for file management
operations and on top makes it easier to add support for file management
operations on URLs. file: [9fe26dc5db] check-in: [f3c452dfef] user: js, branch: trunk, size: 6467 [annotate] [blame] [check-ins using] [diff]

The old behaviour where the exception would access errno directly on
creation of the exception was very fragile. The two main problems with
it were that sometimes it would pick up an errno even though none had
been set and in other cases that when the exception was created errno
had already been overridden.

This also greatly increases errno handling on Win32, especially in
conjunction with sockets. It can still be improved further, though. file: [43dd30c121] check-in: [62e2de30b9] user: js, branch: trunk, size: 26006 [annotate] [blame] [check-ins using] [diff]

The reason for this is that some systems, for example Android, use
32 bits for off_t while having size related fields like st_size as
long long. file: [10eb8531ab] check-in: [46b89b1c8e] user: js, branch: trunk, size: 22810 [annotate] [blame] [check-ins using] [diff]

This replaces +[OFString nativeOSEncoding]. file: [aaab12c640] check-in: [ec66e49dca] user: js, branch: trunk, size: 22799 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [282630ecb7] check-in: [13ee56edf3] user: js, branch: trunk, size: 21767 [annotate] [blame] [check-ins using] [diff]

Instead, just define _GNU_SOURCE when __GLIBC__ is defined. After all,
that's the only libc that doesn't work properly without any defines. file: [f31c61d4b5] check-in: [17be12b6e5] user: js, branch: trunk, size: 21720 [annotate] [blame] [check-ins using] [diff]

LLP64 was mostly fast enumeration using an unsigned long for the state,
which can't store a pointer or a size_t on LLP64. This is now solved by
either throwing an OFOutOfRangeException if the value of the size_t is
bigger than ULONG_MAX or storing the pointer in the extra field (copied
using memcpy, as it's an array of unsigned long, which again would be
too small to store a pointer).

Win64 was mostly Microsoft not being able to decide whether a length is
a size_t, a DWORD, an int or an unsigned int (thus the different types
in places that seem to be almost the same). But since that would not be
confusing enough, a file descriptor is an int if it's for a file, but a
long long if it is for a socket. But of course, for ReadFile and friends
it's a DWORD instead of an int then. file: [c90f56e169] check-in: [4e59d2692f] user: js, branch: trunk, size: 21261 [annotate] [blame] [check-ins using] [diff]

No functional change intended. file: [fd77a17f17] check-in: [9da9b2b64c] user: js, branch: trunk, size: 20661 [annotate] [blame] [check-ins using] [diff]

FreeBSD needs this. file: [419342bfc8] check-in: [30f95ecdf5] user: js, branch: trunk, size: 20592 [annotate] [blame] [check-ins using] [diff]

OS X needs this. file: [eec4f1303b] check-in: [e30269f87e] user: js, branch: trunk, size: 20593 [annotate] [blame] [check-ins using] [diff]

Not using -std=gnu11 means _GNU_SOURCE does not get defined anymore,
therefore this commit also adds the required feature defines for glibc.

Additionally, this adds of_strdup in macros.h, as strdup is an
extension. file: [3c2eb32352] check-in: [2f5af58573] user: js, branch: trunk, size: 20567 [annotate] [blame] [check-ins using] [diff]

This is in preparation for adding UDP sockets, as UDP sockets and TCP
sockets have no common superclass, as one is stream-oriented while the
other is packet-oriented.

Read and write exceptions are for any object now, as they are useful for
a lot more than just for streams, while the others (bind, listen, etc.)
are for any socket now (the type is id in this case, though, as there is
no common superclass). file: [79751d7dbc] check-in: [8d2a5052fd] user: js, branch: trunk, size: 20463 [annotate] [blame] [check-ins using] [diff]

This replaces OF_STRING_ENCODING_NATIVE, as a define was not flexible
enough (determining the native OS encoding at startup was not possible). file: [71494b29e0] check-in: [e54c8c0368] user: js, branch: trunk, size: 20463 [annotate] [blame] [check-ins using] [diff]

This was forgotten when copy and move were changed. file: [e46a299ae7] check-in: [feaf3faad5] user: js, branch: trunk, size: 20519 [annotate] [blame] [check-ins using] [diff]

This replaces +[OFFile renameItemAtPath:toPath:] and supports moving
files to different logical devices. file: [95c6f11fb5] check-in: [260391fc1c] user: js, branch: trunk, size: 21737 [annotate] [blame] [check-ins using] [diff]

Also slightly decreases memory footprint. file: [952a84375d] check-in: [aefb143a8d] user: js, branch: trunk, size: 20432 [annotate] [blame] [check-ins using] [diff]

This replaces +[OFFile copyFileAtPath:toPath:]. file: [0ee3c33822] check-in: [169f06e1ec] user: js, branch: trunk, size: 20239 [annotate] [blame] [check-ins using] [diff]

The arguments were inverted. file: [0e60eafa58] check-in: [ba2b4661de] user: js, branch: trunk, size: 17758 [annotate] [blame] [check-ins using] [diff]

A file documenting the coding style will be written soon. This will
hopefully prevent conflicts in the future, such as whether static
functions are written in camelCase or_with_underscores, like was the
case here. file: [c8979c52b6] check-in: [fa6496efc7] user: js, branch: trunk, size: 17758 [annotate] [blame] [check-ins using] [diff]

Includes:
* Check environ against NULL before using it, since Android sets it to
NULL.
* Cast st_size of struct stat to off_t. Android uses long long for
st_size as its off_t is only 32 bit, but st_size should be off_t
according to POSIX.
* Android's strtod() does not accept 0x, as specified by C99. Thus,
the test is disabled if __ANDROID__ is defined. file: [1f1aa20392] check-in: [c5e7dd679b] user: js, branch: trunk, size: 17848 [annotate] [blame] [check-ins using] [diff]

This removes -[initWithPath:,...], so that it's finally possible to use
-[initWithPath:] for many places where a workaround like
-[initWithDirectoryPath:] was required before. file: [e0f0d0594a] check-in: [7c4179ab9b] user: js, branch: trunk, size: 17802 [annotate] [blame] [check-ins using] [diff]

-[seekToOffset:whence:] now works correctly when whence is SEEK_CUR.
Additionally, the new offset is returned now. file: [f060fd2dab] check-in: [d101b6f8b4] user: js, branch: trunk, size: 17665 [annotate] [blame] [check-ins using] [diff]

This only affects exceptions. file: [0c8ee7ced6] check-in: [f3654b5cc6] user: js, branch: trunk, size: 16449 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [d114dfb10e] check-in: [3d16a30f41] user: js, branch: trunk, size: 16168 [annotate] [blame] [check-ins using] [diff]

It's not available on all systems which have chmod(). file: [c7437b1fa1] check-in: [06443a3ae9] user: js, branch: trunk, size: 16694 [annotate] [blame] [check-ins using] [diff]

Threads and sockets still missing. file: [4b255af215] check-in: [2713b481a1] user: js, branch: trunk, size: 16668 [annotate] [blame] [check-ins using] [diff]

This is used for of_std{in,out,err} now instead of OFFile. file: [8a99cd99a6] check-in: [085bfc12a0] user: js, branch: trunk, size: 16470 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [6182cd74e1] check-in: [c5ef582958] user: js, branch: trunk, size: 18073 [annotate] [blame] [check-ins using] [diff]

Actually, this seems to do exactly what was done manually with
{Get,Set}FileAttributesW before. file: [7dcc3acfc8] check-in: [06c0c98e78] user: js, branch: trunk, size: 18048 [annotate] [blame] [check-ins using] [diff]

Unlike MoveFileW(), _wrename() sets errno. file: [214e7cf8ea] check-in: [55d99d15e3] user: js, branch: trunk, size: 18503 [annotate] [blame] [check-ins using] [diff]

This reverts 5362941.

Even though *UsingEncoding: is what Foundation uses, *WithEncoding: is
more natural and is more consistent with the rest. Also, this means this
restores it to the API of 0.7. file: [25d73bc7b8] check-in: [9ddd33a258] user: js, branch: trunk, size: 18480 [annotate] [blame] [check-ins using] [diff]

It is now -[fileDescriptorForReading] and -[fileDescriptorForWriting].
The split was necessary as some stream types (e.g. OFProcess) don't have
a single file descriptor, but two. This allows to use those stream types
with OFStreamObserver as well. file: [f9e4a0a447] check-in: [440e95fd4a] user: js, branch: trunk, size: 18903 [annotate] [blame] [check-ins using] [diff]

This greatly improves performance, as it gets rid of the overhead of
OFAutoreleasePool. file: [9427d5f441] check-in: [1255f3a11a] user: js, branch: trunk, size: 19053 [annotate] [blame] [check-ins using] [diff]

Referencing subclasses of the current class in +[load] sounds like a bad
idea. file: [69833cd0ab] check-in: [b7cf59038a] user: js, branch: trunk, size: 18992 [annotate] [blame] [check-ins using] [diff]

+[load] creates 3 instances of OFFile and thus +[initialize] is also
called. This causes problems if OFMutex has not been registered with
the runtime yet. It had been fixed by changing the order of .o files,
but this is too fragile and thus it has been changed to use of_mutex_t. file: [ec14d28310] check-in: [36434923ad] user: js, branch: trunk, size: 17671 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [c6a9166c97] check-in: [e1e7ffa903] user: js, branch: trunk, size: 17041 [annotate] [blame] [check-ins using] [diff]

Without this, the headers try to declare functions that use __block as
an argument name and thus fail to compile when using -fblocks. file: [6ef70328cc] check-in: [59e52af26d] user: js, branch: 0.5, size: 14700 [annotate] [blame] [check-ins using] [diff]

Without this, the headers try to declare functions that use __block as
an argument name and thus fail to compile when using -fblocks. file: [5aa0f12b35] check-in: [da2701ad14] user: js, branch: trunk, size: 16089 [annotate] [blame] [check-ins using] [diff]

Does compile with --disable-threads --disable-shared, but does not link
yet. file: [ab8f876cd6] check-in: [d230ac577d] user: js, branch: trunk, size: 15396 [annotate] [blame] [check-ins using] [diff]

Uses OFConstantString* for the format to prevent users from doing stupid
things like of_log([of_stdin readLine]). file: [00f92e27f7] check-in: [17338ef1d5] user: js, branch: trunk, size: 15273 [annotate] [blame] [check-ins using] [diff]

This fixes reading from stdin. file: [cdb8ca685b] check-in: [5f4f207266] user: js, branch: trunk, size: 5948 [annotate] [blame] [check-ins using] [diff]

Since we don't use Object anymore and define isa in OFObject, we can
rely on it. file: [de67b84ef2] check-in: [139591afe1] user: js, branch: trunk, size: 2939 [annotate] [blame] [check-ins using] [diff]

Endianess, size etc. may differ from system to system. While this might
be ok when writing files that are only read local again, this is
definitely not ok with sockets. So it's better to remove it from the
OFStream protocol. file: [44934e3ad8] check-in: [70874cf3c5] user: js, branch: trunk, size: 3196 [annotate] [blame] [check-ins using] [diff]

Additionally, interface for OFArray. file: [b1dd678aec] check-in: [49859c2bcc] user: js, branch: trunk, size: 2651 [annotate] [blame] [check-ins using] [diff]

* Use config.h.
* Check whether to use sel_get_name or sel_getName.
* Rename freeWithData to freeIncludingData. file: [2de0039279] check-in: [7a49441656] user: js, branch: trunk, size: 2706 [annotate] [blame] [check-ins using] [diff]

* OFObject getMem: renamd to getMemWithSize:.
* OFString compare: renamed to compareTo:.
* Exceptions don't throw itself anymore.
* Exceptions include an error string now.
* Exceptions now got raise and string.
* New methods for OFFile:
* changeModeOfFile:toMode:
* changeOwnerOfFile:toOwner:andGroup:
* delete:
* link:to:
* symlink:to:
* OFFile isEndOfFile renamd to atEndOfFile
* OFNotImplementedExeception newWithObject:andMethod renamed to
newWithObject:andSelector:.
* Tests updated accordingly.
* TODO list added. file: [ab4b7dd898] check-in: [b597d49f43] user: js, branch: trunk, size: 2686 [annotate] [blame] [check-ins using] [diff]