ObjFW  History of src/OFMutableString.m of ed598fd8487309d3

While the idea sounds nice that the tag name is the class, this means the
serialization includes whether something is mutable or immutable. This means
doing as much as making something immutable changes the serialization, which
can then cause issues after being deserialized. file: [6babdf726b] check-in: [6ce0093f8d] user: js, branch: trunk, size: 12993 [annotate] [blame] [check-ins using] [diff]

Even when there is neither files nor sockets, a scheme could still be
registered, for example for files embedded into the binary. file: [e8ac978dc5] check-in: [1a49ef773d] user: js, branch: trunk, size: 13658 [annotate] [blame] [check-ins using] [diff]

There is no reliable way to check if C++ already defined those, as Clang
now defines char{16,32}_t even when it is not in C++ 11 mode. So we
cannot check if we are not in C++ 11 and then define them and otherwise
rely on the C++ 11 types. file: [188469b5c0] check-in: [505137f25f] user: js, branch: trunk, size: 14137 [annotate] [blame] [check-ins using] [diff]

This improves Swift compatibility. file: [1a24b0bb52] check-in: [a2e849c681] user: js, branch: trunk, size: 14090 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [8288a048e9] check-in: [2f4e0df8be] user: js, branch: trunk, size: 14099 [annotate] [blame] [check-ins using] [diff]

This matches Apple's style. file: [f5a01a1e43] check-in: [6b77a5dd8b] user: js, branch: trunk, size: 14058 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [8db593635a] check-in: [4af49a13c3] user: js, branch: trunk, size: 14082 [annotate] [blame] [check-ins using] [diff]

This only fixes the generic one in OFMutableString, the specific one in
OFMutableString_UTF8 (that was used for all strings) was not broken. file: [4ce1d99820] check-in: [c7f593793e] user: js, branch: trunk, size: 14003 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [39a9726c51] check-in: [44f45c2e35] user: js, branch: trunk, size: 13696 [annotate] [blame] [check-ins using] [diff]

These are independent of the locale and work on the ASCII character set.

Unlike the C ones, these are 8-bit safe, meaning if a character > 0x7F
is passed, is{alpha,alnum} returns false and to{upper,lower} returns the
original character. file: [3b4d8b06cc] check-in: [d9eb7b50b3] user: js, branch: trunk, size: 13690 [annotate] [blame] [check-ins using] [diff]

This is only useful for size-constrained systems and changes the
behavior as follows:

* Case-insensitive comparisons only work as expected for ASCII
characters. This means that while a and A compare equal, ä and Ä do
not.

* -[OFMutableString {upper,lower}] and
-[OFString {upper,lower}caseString] only work on ASCII characters;
all other characters are left as they are. This means that the upper
version of a is A, but the upper version of ä is still ä (and vice
versa for lower). file: [7c949926c1] check-in: [b7b33247d6] user: js, branch: trunk, size: 13923 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [4c381c3b4d] check-in: [2a27cf3000] user: js, branch: trunk, size: 12577 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [f4c986f8d9] check-in: [13ee56edf3] user: js, branch: trunk, size: 12493 [annotate] [blame] [check-ins using] [diff]

No functional change intended. file: [6564d3d79b] check-in: [9da9b2b64c] user: js, branch: trunk, size: 12551 [annotate] [blame] [check-ins using] [diff]

This removes -[initWithPath:,...], so that it's finally possible to use
-[initWithPath:] for many places where a workaround like
-[initWithDirectoryPath:] was required before. file: [ad91789f29] check-in: [7c4179ab9b] user: js, branch: trunk, size: 12567 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [8d0822912d] check-in: [3d16a30f41] user: js, branch: trunk, size: 13008 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [ab8d403b2b] check-in: [c5ef582958] user: js, branch: trunk, size: 13113 [annotate] [blame] [check-ins using] [diff]

For ObjC++, these are defined to char{16,32}_t if C++11 is used. This
means passing e.g. a C++11 UTF-16 string to -[initWithUTF16String:]
works without a warning.

For C11, this is not necessary, as char{16,32}_t are just typedef'd to
uint_least{16,32}_t in <uchar.h> and thus compatible to the definition
of of_char{16,32}_t. The reason for not defining of_char{16,32}_t to
char{16,32}_t when using C11 is that <uchar.h> might be missing and that
char{16,32}_t are not required to be UTF-{16,32}, whereas in C++, they
are required to be UTF-{16,32}. file: [bfd221d698] check-in: [545b6f740e] user: js, branch: trunk, size: 13108 [annotate] [blame] [check-ins using] [diff]

With this change, there is a clear separation between characters and
UTF-32 strings now. Characters are just an array of characters in the
native endianess, with no BOM prepended. UTF-32 on the other hand may
have a BOM and can be swapped and is optionally zero-terminated.

This also fixes a few missing UTF-16 init methods in OFMutableString. file: [086c316216] check-in: [50916b8dbe] user: js, branch: trunk, size: 13084 [annotate] [blame] [check-ins using] [diff]

* Instead of Unicode "strings", it uses the term "Unicode character
array".
* No terminating 0 character anymore, as these are not C strings
anyway. file: [5f0048c446] check-in: [640b225ba7] user: js, branch: trunk, size: 11992 [annotate] [blame] [check-ins using] [diff]

The only method that needs to be implemented by a subclass now is
-[replaceCharactersInRange:withString:]. file: [b484829d75] check-in: [9e8c825616] user: js, branch: trunk, size: 12655 [annotate] [blame] [check-ins using] [diff]

This should make it more future-proof, as adding new options is easier
than adding new methods for each and every combination of options. file: [c4f091786b] check-in: [fcaa549324] user: js, branch: trunk, size: 12701 [annotate] [blame] [check-ins using] [diff]

This greatly improves performance, as it gets rid of the overhead of
OFAutoreleasePool. file: [808aebc7d8] check-in: [1255f3a11a] user: js, branch: trunk, size: 12619 [annotate] [blame] [check-ins using] [diff]

It is a class cluster now, but there is still much to improve. file: [b1a528232d] check-in: [301ee63212] user: js, branch: trunk, size: 11046 [annotate] [blame] [check-ins using] [diff]

It turns out the overhead of calling madvise() is bigger than the gain
of using it. file: [a718ee6404] check-in: [6cbbd7c39c] user: js, branch: trunk, size: 15227 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [471b2f9466] check-in: [e1e7ffa903] user: js, branch: trunk, size: 15789 [annotate] [blame] [check-ins using] [diff]

Also removes -[appendCStringWithoutUTF8Checking:] as it is dangerous and
not compatible with this optimization. file: [3c8f4c2bc5] check-in: [36e8a94f34] user: js, branch: trunk, size: 16105 [annotate] [blame] [check-ins using] [diff]

When passing a string without \0-termination, strlen would access the
passed string out of bounds. file: [bb152a87a3] check-in: [e6c5c90751] user: js, branch: trunk, size: 12194 [annotate] [blame] [check-ins using] [diff]

ivars are now named like this: thisIsAnIVar. If an accessor exists for
the ivar, the ivar is named like the accessor. This is required for
@property to work. file: [920953956a] check-in: [37db8f0fb3] user: js, branch: trunk, size: 10749 [annotate] [blame] [check-ins using] [diff]

Changesets:
* b95fcaa6d694
* 804c68d222b4
* da8cd738da3d
* 1109d5ce3419
* d03f5c1ca95d
* 2a7017722165
* 4fccdc79eeb7
* d228149fbc04
* 8782d412a4a6 file: [6ba90ce87d] check-in: [b91a8283fe] user: js, branch: 0.2, size: 10986 [annotate] [blame] [check-ins using] [diff]

The recent optimization had a bug in the range check and thus did not
notice that an int16_t is not enough to store the difference, thus
leading to broken results. This reverts it to the old way the Unicode
table was stored. file: [5bfa0023ae] check-in: [13f2a20288] user: js, branch: trunk, size: 10973 [annotate] [blame] [check-ins using] [diff]

OFExceptions:
* OFNoMemException to OFOutOfMemoryException.
* OFMemNotPartOfObjException to OFMemoryNotPartOfObjectException.

OFObject:
* -[addItemToMemoryPool:] to -[addMemoryToPool:].
* -[allocWithSize:] to -[allocMemoryWithSize:].
* -[allocNItems:withSize] to -[allocMemoryForNItems:withSize:].
* -[resizeMem:toSize] to -[resizeMemory:toSize:].
* -[resizeMem:toNItems:withSize:] to
-[resizeMemoryToNItems:withSize:].
* -[freeMem] to -[freeMemory:].

OFString:
* -[urlencode] to -[urlEncodedString].
* -[urldecode] to -[urlDecodedString]. file: [fb06bc791e] check-in: [033054ad75] user: js, branch: trunk, size: 6049 [annotate] [blame] [check-ins using] [diff]