ObjFW  History of tests/OFDictionaryTests.m of d473ceacbe537678

The hash was stable after all, the problem was that everything gets
XOR'd together and thus a dictionary with the objects for keys and keys
for objects has the same hash. file: [9cb3005942] check-in: [7b21071996] user: js, branch: objfwtest, size: 6328 [annotate] [blame] [check-ins using] [diff]

It duplicates the functionality of -[OFMutableURI setQueryDictionary:]. file: [856ca278b2] check-in: [f1bf64ca9f] user: js, branch: trunk, size: 9955 [annotate] [blame] [check-ins using] [diff]

ObjFW's style changed over the years, but the tests were never adjusted
to it. file: [1f9b9cab2d] check-in: [14f1e22d79] user: js, branch: trunk, size: 10152 [annotate] [blame] [check-ins using] [diff]

Since C guarantees minimum sizes for char, short, int, long and long
long, these can be used instead. file: [a25483183f] check-in: [25c985fec1] user: js, branch: trunk, size: 10075 [annotate] [blame] [check-ins using] [diff]

OFAutoreleasePools have long been discouraged in favor of the runtime's
autorelease pools. file: [912a668d02] check-in: [09be825f88] user: js, branch: trunk, size: 10073 [annotate] [blame] [check-ins using] [diff]

It's not very useful and is a problem for the Foundation bridge, as
NSEnumerator does not have it. file: [71910a92f2] check-in: [7214a2c7af] user: js, branch: trunk, size: 10075 [annotate] [blame] [check-ins using] [diff]

This prevents forgetting to add an import to ObjFW.h, as the tests would
then not compile. file: [c54892547e] check-in: [dc0c6c34ab] user: js, branch: trunk, size: 9922 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [ca0fda1cc3] check-in: [2f4e0df8be] user: js, branch: trunk, size: 10091 [annotate] [blame] [check-ins using] [diff]

Clang didn't complain about these, but GCC did. file: [ed8d42f32f] check-in: [7e29a62cc6] user: js, branch: trunk, size: 10049 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [b05d0d80fb] check-in: [4af49a13c3] user: js, branch: trunk, size: 9543 [annotate] [blame] [check-ins using] [diff]

These are usually not used, as OFDictionary_hashtable and
OFMutableDictionary_hashtable are used instead. However, they are used
if someone creates their own subclass of OFDictionary /
OFMutableDictionary. As they are rarely used in production, it is
important to run all tests on them. file: [6cb38442bb] check-in: [cfd54bd090] user: js, branch: trunk, size: 9537 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [0918022e86] check-in: [44f45c2e35] user: js, branch: trunk, size: 7251 [annotate] [blame] [check-ins using] [diff]

If this is only overridden in OFMutableDictionary, this would lead to
inconsistent behavior, as it could be called on an OFDictionary as well
due to the fact that -[setValue:forKey:] is defined in OFObject.
Instead, if the dictionary is immutable, an OFUndefinedKeyException is
thrown. file: [c47931a3b5] check-in: [f816d1ec7c] user: js, branch: trunk, size: 7224 [annotate] [blame] [check-ins using] [diff]

If the key starts with an @, the @ is stripped and the super method is
called. Otherwise, this is equivalent to -[objectForKey:] /
-[setValue:forKey:]. file: [b3dcaccc4e] check-in: [cbacea7ca3] user: js, branch: trunk, size: 7031 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [b01b142448] check-in: [cec0f072f8] user: js, branch: 0.8, size: 6886 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [6682fa3a80] check-in: [2a27cf3000] user: js, branch: trunk, size: 6847 [annotate] [blame] [check-ins using] [diff]

Now that we require GCC >= 4.6, those features are always available. file: [3cc771ecbe] check-in: [be8db49635] user: js, branch: trunk, size: 6843 [annotate] [blame] [check-ins using] [diff]

Clang now warns if the enumeration variable of a fast enumeration is not
used. file: [45630b47b6] check-in: [6143baaaee] user: js, branch: trunk, size: 6874 [annotate] [blame] [check-ins using] [diff]

This also removes "bool *stop" from some blocks where it does not make
sense. file: [d16af2dca7] check-in: [e8473b9db8] user: js, branch: trunk, size: 6853 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [e04f963308] check-in: [c5ef582958] user: js, branch: trunk, size: 6870 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [04d0bf130a] check-in: [e1e7ffa903] user: js, branch: trunk, size: 6791 [annotate] [blame] [check-ins using] [diff]