ObjFW  History of src/OFConstantString.m of c9a01cc901dbe36f

In order to not accidentally have C strings with \0, an
OFInvalidEncodingException is thrown when trying to get a C string for a
string that contains \0.

In order to get a C string with \0 anyway, a new method
-[insecureCStringWithEncoding:] is added. file: [03e8d1030f] check-in: [6fbc3b18c7] user: js, branch: trunk, size: 12551 [annotate] [blame] [check-ins using] [diff]

It has been moved to the "unicode-normalization" branch until it is
ready. file: [a848ea510b] check-in: [149874777c] user: js, branch: trunk, size: 12287 [annotate] [blame] [check-ins using] [diff]

The same can be achieved using -[OFString stringByAppendingString:] and
swapping the order of arguments. file: [d0c2668f14] check-in: [114576fe94] user: js, branch: trunk, size: 12990 [annotate] [blame] [check-ins using] [diff]

The new names should be more accurate. file: [1a5c26a192] check-in: [627511b032] user: js, branch: trunk, size: 13146 [annotate] [blame] [check-ins using] [diff]

The internal hash is still 32 bit in most places, but this way, it is at
least not baked into the API and ABI and can be upgraded later, should
that ever be necessary. file: [0adc85a65a] check-in: [aeb403a1ed] user: js, branch: trunk, size: 13913 [annotate] [blame] [check-ins using] [diff]

This solves the old signed vs. unsigned problem and allows for more
bases than just 8, 10 and 16, as well as auto-detection of the base (if
base is 0). file: [0761b10d3a] check-in: [b6ee372b98] user: js, branch: trunk, size: 13908 [annotate] [blame] [check-ins using] [diff]

This requires a slight API change to OFWindowsRegistryKey, as the
previous API was depending on RegGetValueW(), which is not available on
Windows XP. file: [1a9a1e4686] check-in: [94f1f0f479] user: js, branch: trunk, size: 13694 [annotate] [blame] [check-ins using] [diff]

There is no reliable way to check if C++ already defined those, as Clang
now defines char{16,32}_t even when it is not in C++ 11 mode. So we
cannot check if we are not in C++ 11 and then define them and otherwise
rely on the C++ 11 types. file: [32fee23859] check-in: [505137f25f] user: js, branch: trunk, size: 13272 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [aaf59fe08c] check-in: [2f4e0df8be] user: js, branch: trunk, size: 12163 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [606ccc29ff] check-in: [4af49a13c3] user: js, branch: trunk, size: 11617 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [5483ae8a87] check-in: [44f45c2e35] user: js, branch: trunk, size: 11569 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [3401be807a] check-in: [2a27cf3000] user: js, branch: trunk, size: 11588 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [340ec99b9c] check-in: [13ee56edf3] user: js, branch: trunk, size: 11578 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [7d49a47280] check-in: [3d16a30f41] user: js, branch: trunk, size: 11937 [annotate] [blame] [check-ins using] [diff]

This way, it's possible to use the same constant string from multiple
threads without having to make sure it's initialized first. file: [8447dff468] check-in: [abb7536cdd] user: js, branch: trunk, size: 11993 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [9960343709] check-in: [c5ef582958] user: js, branch: trunk, size: 11851 [annotate] [blame] [check-ins using] [diff]

This reverts 5362941.

Even though *UsingEncoding: is what Foundation uses, *WithEncoding: is
more natural and is more consistent with the rest. Also, this means this
restores it to the API of 0.7. file: [eeb9601efb] check-in: [9ddd33a258] user: js, branch: trunk, size: 10921 [annotate] [blame] [check-ins using] [diff]

This should make it more future-proof, as adding new options is easier
than adding new methods for each and every combination of options. file: [4bef6d21b7] check-in: [fcaa549324] user: js, branch: trunk, size: 10055 [annotate] [blame] [check-ins using] [diff]

A linked-list is put before each memory chunk allocated instead of
having an array of all memory chunks. This means only one malloc now
instead of one malloc and one realloc. This also means that when
checking reallocs and frees, it's no longer necessary to iterate through
all memory chunks, as the linked list also contains the owner, meaning
realloc and free are no longer O(n), but O(1) now.

As allocating bigger chunks seems to be a little bit slower than smaller
chunks, it seems that this is slightly slower in benchmarks if only very small
chunks are allocated. However, measuring real world usage, it's a lot faster. file: [e6c815e41d] check-in: [28170f5f65] user: js, branch: trunk, size: 9959 [annotate] [blame] [check-ins using] [diff]

It is a class cluster now, but there is still much to improve. file: [878ad12e02] check-in: [301ee63212] user: js, branch: trunk, size: 9225 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [c74b1f841a] check-in: [e1e7ffa903] user: js, branch: trunk, size: 13342 [annotate] [blame] [check-ins using] [diff]

Also removes -[appendCStringWithoutUTF8Checking:] as it is dangerous and
not compatible with this optimization. file: [87992a22fc] check-in: [36e8a94f34] user: js, branch: trunk, size: 12798 [annotate] [blame] [check-ins using] [diff]