ObjFW  History of src/OFString+URLEncoding.m of c70b66a22872d295

The new names should be more accurate. file: [387a1fe7bd] check-in: [627511b032] user: js, branch: trunk, size: 3583 [annotate] [blame] [check-ins using] [diff]

While -[OFData initWithDataNoCopy:count:itemSize:freeWhenDone:] can
currently never throw, it might in the future, and when it does so in
the future, these would be memory leaks then. file: [329955234f] check-in: [a2b4238850] user: js, branch: trunk, size: 3584 [annotate] [blame] [check-ins using] [diff]

-[allocMemoryWithSize:] has book keeping overhead that is unnecessary
for temporary memory. file: [4c3b80addf] check-in: [0ddaac3f5b] user: js, branch: trunk, size: 3519 [annotate] [blame] [check-ins using] [diff]

While it makes sense to wrap malloc and calloc to replace the error
checking with exceptions, it does not make sense to wrap free. file: [7714669373] check-in: [3d8286feee] user: js, branch: trunk, size: 3519 [annotate] [blame] [check-ins using] [diff]

This is now unreserved + sub-delims from RFC 3986. file: [92e75db2c6] check-in: [4db6713bda] user: js, branch: trunk, size: 3389 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [9ad96294d0] check-in: [4af49a13c3] user: js, branch: trunk, size: 3566 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [1829498619] check-in: [44f45c2e35] user: js, branch: trunk, size: 3581 [annotate] [blame] [check-ins using] [diff]

These are independent of the locale and work on the ASCII character set.

Unlike the C ones, these are 8-bit safe, meaning if a character > 0x7F
is passed, is{alpha,alnum} returns false and to{upper,lower} returns the
original character. file: [6c61b62a6b] check-in: [d9eb7b50b3] user: js, branch: trunk, size: 3575 [annotate] [blame] [check-ins using] [diff]

URL decoding and reencoding is not lossless: For example, if the query
was foo=bar&qux=foo%25bar, it will be decoded to foo=bar&qux=foo&bar and
then reencoded to foo=bar%25qux=foo%25bar, which is a different thing.

The only way to solve this is to let the application handle the URL
decoding and encoding according to its own rules, as those might be
different depending on the application. file: [9b57fed9b2] check-in: [516517deb3] user: js, branch: trunk, size: 3583 [annotate] [blame] [check-ins using] [diff]

This should only be done for the query string. file: [134edb9cf7] check-in: [32bc855af9] user: js, branch: trunk, size: 3695 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [2cd0023e53] check-in: [2a27cf3000] user: js, branch: trunk, size: 3821 [annotate] [blame] [check-ins using] [diff]

Those were only a problem if the user created its own OFString subclass,
as calls to -[UTF8String] could then create a new, autoreleased C
string. As OFString_UTF8 simply returns the internal C string, this
hasn't been a problem when not subclassing OFString. file: [89405889ad] check-in: [b5c8b62533] user: js, branch: trunk, size: 3627 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [5d54dc5328] check-in: [3d16a30f41] user: js, branch: trunk, size: 3158 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [cfd7bec6c2] check-in: [e1e7ffa903] user: js, branch: trunk, size: 3218 [annotate] [blame] [check-ins using] [diff]