ObjFW  History of src/OFMutableArray_adjacent.m of 90d8affe472c28b7

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [5cf73c1314] check-in: [2f4e0df8be] user: js, branch: trunk, size: 7772 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [6496c63550] check-in: [4af49a13c3] user: js, branch: trunk, size: 7698 [annotate] [blame] [check-ins using] [diff]

These are usually not used, as OFArray_adjacent and
OFMutableArray_adjacent are used instead. However, they are used if
someone creates their own subclass of OFArray / OFMutableArray. As they
are rarely used in production, it is important to run all tests on them. file: [55b87bb47c] check-in: [7fec2ef57e] user: js, branch: trunk, size: 7694 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [6ee14e3c8a] check-in: [44f45c2e35] user: js, branch: trunk, size: 7667 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [9319ae3a70] check-in: [2a27cf3000] user: js, branch: trunk, size: 7625 [annotate] [blame] [check-ins using] [diff]

After all, this might (and does for OFArray_adjacent!) return an
internal representation that must not be changed, so changes should be
prevented at compile-time. file: [873b95dc7f] check-in: [68d32a92c1] user: js, branch: trunk, size: 7615 [annotate] [blame] [check-ins using] [diff]

LLP64 was mostly fast enumeration using an unsigned long for the state,
which can't store a pointer or a size_t on LLP64. This is now solved by
either throwing an OFOutOfRangeException if the value of the size_t is
bigger than ULONG_MAX or storing the pointer in the extra field (copied
using memcpy, as it's an array of unsigned long, which again would be
too small to store a pointer).

Win64 was mostly Microsoft not being able to decide whether a length is
a size_t, a DWORD, an int or an unsigned int (thus the different types
in places that seem to be almost the same). But since that would not be
confusing enough, a file descriptor is an int if it's for a file, but a
long long if it is for a socket. But of course, for ReadFile and friends
it's a DWORD instead of an int then. file: [1c77ed7f95] check-in: [4e59d2692f] user: js, branch: trunk, size: 7609 [annotate] [blame] [check-ins using] [diff]

This restores the previous behaviour for OFArray_adjacent. It was lost
when OFArray's fast enumeration was changed to be better optimized for
huge arrays that aren't adjacent in memory. I forgot that
OFArray_adjacent just used the implementation from OFArray, as OFArray
had the ideal implementation for OFArray_adjacent, but now that OFArray
is optimized for huge, non-adjacent arrays, this wasn't the case
anymore. file: [dd32892024] check-in: [4dbca9fc06] user: js, branch: trunk, size: 7594 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [190fb95780] check-in: [3d16a30f41] user: js, branch: trunk, size: 7371 [annotate] [blame] [check-ins using] [diff]

This also removes "bool *stop" from some blocks where it does not make
sense. file: [4bdaba029a] check-in: [e8473b9db8] user: js, branch: trunk, size: 7794 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [1c467efbfe] check-in: [c5ef582958] user: js, branch: trunk, size: 7834 [annotate] [blame] [check-ins using] [diff]

This way, the error message will show the called class instead of the
class used internally. file: [a8ef885aa6] check-in: [2de15db195] user: js, branch: trunk, size: 7828 [annotate] [blame] [check-ins using] [diff]

This greatly improves performance, as it gets rid of the overhead of
OFAutoreleasePool. file: [b8f5cd2bb5] check-in: [1255f3a11a] user: js, branch: trunk, size: 6392 [annotate] [blame] [check-ins using] [diff]

OFArray:
* +[arrayByAddingObject:]
* +[arrayByAddingObjectsFromArray:]

OFMutableArray:
* -[addObjectsFromArray:]
* -[insertObjectsFromArray:atIndex:] file: [e388818b36] check-in: [95e8e1e486] user: js, branch: trunk, size: 6351 [annotate] [blame] [check-ins using] [diff]

Also fix a bug where OFBigDataArray would waste memory. file: [489af893ca] check-in: [f7576a66ce] user: js, branch: trunk, size: 6049 [annotate] [blame] [check-ins using] [diff]

Also adds more checks. file: [168c402c93] check-in: [d5ddb2cb48] user: js, branch: trunk, size: 6600 [annotate] [blame] [check-ins using] [diff]

For consistency with Foundation. file: [725da742e3] check-in: [26f2ffa908] user: js, branch: trunk, size: 6570 [annotate] [blame] [check-ins using] [diff]

For consistency with Foundation. file: [998a7318fe] check-in: [13e6e99067] user: js, branch: trunk, size: 6564 [annotate] [blame] [check-ins using] [diff]

This is required for the new array literals. file: [a923c5af53] check-in: [008be86a16] user: js, branch: trunk, size: 6556 [annotate] [blame] [check-ins using] [diff]

This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.

So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. file: [cacb4ce363] check-in: [e1e7ffa903] user: js, branch: trunk, size: 5759 [annotate] [blame] [check-ins using] [diff]