ObjFW  History of src/OFKernelEventObserver.h of 869f4db10719d140

These places are not super performance critical and the code becomes a
lot more readable.

Actually using @synchronized in ObjFW itself is also a good motivation
to optimize it further. file: [15425300f6] check-in: [ff3a60cc12] user: js, branch: trunk, size: 7913 [annotate] [blame] [check-ins using] [diff]

Check for AmigaOS first, as we have a special implementation for it that
uses WaitSelect() instead. This way, we no longer need to match $host_os
to manually disable the pipe() check, which would break if one of the
AmigaOS variants adds pipe() later on. file: [e557d74842] check-in: [d76213374e] user: js, branch: trunk, size: 7086 [annotate] [blame] [check-ins using] [diff]

__COUNTER__ does not exist in GCC 4.2, and Apple GCC 4.2 is still the
newest compiler available for macOS 10.5. file: [2919da30f1] check-in: [ef614a225d] user: js, branch: trunk, size: 7086 [annotate] [blame] [check-ins using] [diff]

This removes the ability to let a thread add or remove objects for
another thread. This features wasn't used at all, but caused significant
problems with kqueue and epoll, as this often resulted in removing a
file descriptor after it had already been closed. file: [f3b368ad12] check-in: [24eff635db] user: js, branch: trunk, size: 7063 [annotate] [blame] [check-ins using] [diff]

This allows ABI stability with the fragile ABI. file: [b2d4e300e7] check-in: [496695d778] user: js, branch: trunk, size: 7054 [annotate] [blame] [check-ins using] [diff]

Instead of letting OFStream conform to it, which itself does not really
conform to it, let all the subclasses that actually do conform to it. file: [ee35836078] check-in: [69749b6a5b] user: js, branch: trunk, size: 6427 [annotate] [blame] [check-ins using] [diff]

This improves Swift compatibility. file: [81ef5bf556] check-in: [f3ccf14461] user: js, branch: trunk, size: 6341 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [e653f3b4a2] check-in: [4af49a13c3] user: js, branch: trunk, size: 6500 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [316e90db78] check-in: [44f45c2e35] user: js, branch: trunk, size: 6499 [annotate] [blame] [check-ins using] [diff]

_readObjects must only be changed from the thread running the observer
and not from a thread adding or removing objects to observe. This is
already handled by the locked queue used by poll and select, so the best
way to solve this is to use the locked queue for kqueue and epoll as
well. file: [705ced3614] check-in: [85917ea0dd] user: js, branch: 0.8, size: 7000 [annotate] [blame] [check-ins using] [diff]

_readObjects must only be changed from the thread running the observer
and not from a thread adding or removing objects to observe. This is
already handled by the locked queue used by poll and select, so the best
way to solve this is to use the locked queue for kqueue and epoll as
well. file: [dd46f03e3d] check-in: [45518ae7b7] user: js, branch: trunk, size: 6493 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [b2db698d51] check-in: [cec0f072f8] user: js, branch: 0.8, size: 6919 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [a975466b61] check-in: [2a27cf3000] user: js, branch: trunk, size: 6412 [annotate] [blame] [check-ins using] [diff]

kqueue and epoll were not updating _readObjects and _writeObjects
anymore, since this was done by the queue handling code, which they no
longer use after the refactorization. file: [f92733e89e] check-in: [d1c4c46706] user: js, branch: 0.8, size: 6915 [annotate] [blame] [check-ins using] [diff]

kqueue and epoll were not updating _readObjects and _writeObjects
anymore, since this was done by the queue handling code, which they no
longer use after the refactorization. file: [72e7bbbce5] check-in: [258b8a4944] user: js, branch: trunk, size: 6408 [annotate] [blame] [check-ins using] [diff]

This moves the locked queue for actions to
OFKernelEventObserver_LockedQueue, which is now used for select and
poll, but skipped for kqueue and epoll, as they natively support changes
from another thread.

This fixes the problem that removing an object is delayed until the next
observe call - at which point it might have already been closed, meaning
the fd is no longer available. This was mainly a problem with kqueue, as
closing the fd already removed it from the kqueue, which then resulted
in an error being returned when trying to manually remove the fd from
the kqueue. file: [b0b3935794] check-in: [c5f0c5f9ba] user: js, branch: 0.8, size: 6821 [annotate] [blame] [check-ins using] [diff]

This moves the locked queue for actions to
OFKernelEventObserver_LockedQueue, which is now used for select and
poll, but skipped for kqueue and epoll, as they natively support changes
from another thread.

This fixes the problem that removing an object is delayed until the next
observe call - at which point it might have already been closed, meaning
the fd is no longer available. This was mainly a problem with kqueue, as
closing the fd already removed it from the kqueue, which then resulted
in an error being returned when trying to manually remove the fd from
the kqueue. file: [4fe6de3289] check-in: [e9b4700cb6] user: js, branch: trunk, size: 6314 [annotate] [blame] [check-ins using] [diff]

Now that we can require GCC >= 4.6, we no longer need to have a category
on OFObject that adds the optional protocol to it. file: [44498ce7a3] check-in: [ba62f00fac] user: js, branch: trunk, size: 6542 [annotate] [blame] [check-ins using] [diff]

This increases the required GCC version from 4.0 to 4.6 (exception:
Apple GCC, which already supports this with >= 4.0 starting with OS X
10.5). Since even GCC 4.6 is really old by now, there is no point in
still supporting something even older and making the code ugly because
of that. While some hardware and OS support was dropped from GCC 4.6
compared to GCC 4.0, there is nothing in there that would be an
interesting target with the exception of BeOS maybe - but a port to BeOS
can also be achieved using the Haiku support. The other dropped OSes are
mostly old versions of OSes while newer ones are still being supported
(and those newer versions of those OSes still support the same
hardware). file: [9901acfc70] check-in: [48980f2297] user: js, branch: trunk, size: 6677 [annotate] [blame] [check-ins using] [diff]

This is necessary to make GCC (>= 4.6 and Apple GCC) happy as they don't
like the list of property attributes ending in a comma. file: [dd8f6e2345] check-in: [80e1a9655b] user: js, branch: trunk, size: 7049 [annotate] [blame] [check-ins using] [diff]

This was necessary because select(), poll() and kevent() on FreeBSD and
OS X would sometimes return 0 events, even if there are some, and
sometimes return the correct number of events that were pending, meaning
the number of events returned is unreliable. To make things worse,
whether it returns 0 or the number of events that were pending is
completely non-deterministic on both FreeBSD and OS X (running the same
tests multiple times in a row would make it sometimes work and sometimes
fail).

In order to prevent code from depending on the return value of
-[observeForTimeInterval:] (which would depend on select(), poll() and
kevent() returning the correct number), OFKernelObserver no longer
returns whether there were pending events. It is expected that
-[observe] or -[observeForTimeInterval:] is just called in a loop as
long as events should be handled.

The tests have been changed as well to reflect this. What they do now is
set a deadline and call -[observeForTimeInterval:] with a small timeout
in a loop until the deadline is reached or all events have been handled.

Note: DragonFlyBSD has not been tested, but will most likely behave like
FreeBSD and OS X. file: [c48f1a2944] check-in: [220513a3f5] user: js, branch: trunk, size: 6805 [annotate] [blame] [check-ins using] [diff]

LLP64 was mostly fast enumeration using an unsigned long for the state,
which can't store a pointer or a size_t on LLP64. This is now solved by
either throwing an OFOutOfRangeException if the value of the size_t is
bigger than ULONG_MAX or storing the pointer in the extra field (copied
using memcpy, as it's an array of unsigned long, which again would be
too small to store a pointer).

Win64 was mostly Microsoft not being able to decide whether a length is
a size_t, a DWORD, an int or an unsigned int (thus the different types
in places that seem to be almost the same). But since that would not be
confusing enough, a file descriptor is an int if it's for a file, but a
long long if it is for a socket. But of course, for ReadFile and friends
it's a DWORD instead of an int then. file: [001fd5d024] check-in: [4e59d2692f] user: js, branch: trunk, size: 7004 [annotate] [blame] [check-ins using] [diff]

Removed file descriptors were returned in the event list with EBADF if
the file descriptor has been closed before removing them. Interpreting
that as a read event caused problems, as the file descriptor could not
be mapped to an object anymore, thus the entry in the event list is
skipped now if there was a EBADF error. file: [5b1f9ce35e] check-in: [41ca862453] user: js, branch: trunk, size: 6542 [annotate] [blame] [check-ins using] [diff]

It is no longer limited to streams now. file: [2129421b71] check-in: [c694569d86] user: js, branch: trunk, size: 6549 [annotate] [blame] [check-ins using] [diff]