ObjFW  History of src/OFSubprocess.m of 69a0cfcb13506b5f

This means refusing to close twice, calling -[close] from -[dealloc] and
not calling -[cancelAsyncRequests].

Calling -[cancelAsyncRequests] in -[close] is too dangerous, as -[close]
gets called by -[dealloc]: If the queue is the last reference to the
object, at the point where -[cancelAsyncRequests] removes it from the
queue, the object will start to deallocate and call into
-[cancelAsyncRequests] again, which is still in the middle of removing
it and now finds itself with an inconsistent state. file: [dc3506687f] check-in: [3b43d51006] user: js, branch: trunk, size: 14308 [annotate] [blame] [check-ins using] [diff]

There is no reliable way to check if C++ already defined those, as Clang
now defines char{16,32}_t even when it is not in C++ 11 mode. So we
cannot check if we are not in C++ 11 and then define them and otherwise
rely on the C++ 11 types. file: [bf28fd0153] check-in: [505137f25f] user: js, branch: trunk, size: 14267 [annotate] [blame] [check-ins using] [diff]

Instead of letting OFStream conform to it, which itself does not really
conform to it, let all the subclasses that actually do conform to it. file: [b38c51b4de] check-in: [69749b6a5b] user: js, branch: trunk, size: 14223 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [47e26e30a9] check-in: [2f4e0df8be] user: js, branch: trunk, size: 14313 [annotate] [blame] [check-ins using] [diff]

This allows retrieving the number of bytes already written before the
write failed, allowing to retry without writing data that has already
been written. file: [b2487462e5] check-in: [2ae01218ef] user: js, branch: trunk, size: 14385 [annotate] [blame] [check-ins using] [diff]

This removes several initializers that omitted the errNo. Removing those
forces to think about whether there is a meaningful errNo to set instead
of just omitting it. file: [a980832db2] check-in: [4f36894ce7] user: js, branch: trunk, size: 14117 [annotate] [blame] [check-ins using] [diff]

Instead, let reads return 0 and let writes append after the end. file: [ea4c0fa50a] check-in: [f9cd4f9cab] user: js, branch: trunk, size: 14093 [annotate] [blame] [check-ins using] [diff]

This matches Apple's style. file: [57b3b6c720] check-in: [6b77a5dd8b] user: js, branch: trunk, size: 14339 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [08732d57f8] check-in: [4af49a13c3] user: js, branch: trunk, size: 14360 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [e88047c399] check-in: [44f45c2e35] user: js, branch: trunk, size: 14320 [annotate] [blame] [check-ins using] [diff]

This singleton gives access to all things locale, including the ability
to get localized strings.

This also adds the OF_LOCALIZED() macro. Its first argument is an ID for
the string to be localized and its second argument is the fallback
string to be used if it cannot retrieve the localized string. Following
that are variable name / value pairs to be replaced in the localized
string.

Getting translated strings is not implemented yet: Instead, it always
uses the fallback string.

This also switches ofhttp to localized strings. file: [b11627a172] check-in: [06bcb21fc7] user: js, branch: trunk, size: 14314 [annotate] [blame] [check-ins using] [diff]

Right now, this is only useful for OFTCPSocket, as this is the only
class so far not establishing the stream in the init method. However,
this adds the general infrastructure to allow reuse to all subclasses of
OFStream. file: [273ab6b21b] check-in: [1de551cb5f] user: js, branch: trunk, size: 14342 [annotate] [blame] [check-ins using] [diff]

This makes sure to return NULL if the passed environment is nil and
makes sure that the environment is always terminated with 4 zero bytes,
even if the environment is empty. file: [e8f32c52e1] check-in: [0c7c53dd58] user: js, branch: trunk, size: 14325 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [5507b0fea2] check-in: [cec0f072f8] user: js, branch: 0.8, size: 14296 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [03cde41f41] check-in: [2a27cf3000] user: js, branch: trunk, size: 14251 [annotate] [blame] [check-ins using] [diff]

Now that we can require GCC >= 4.6, we no longer need to fall back to
using a category on old compilers. file: [b05e103aab] check-in: [2aca549d60] user: js, branch: trunk, size: 14247 [annotate] [blame] [check-ins using] [diff]

Now that we require GCC >= 4.6 anyway, there's no more reason to not use
it anymore. file: [3256a71833] check-in: [6b13727ce0] user: js, branch: trunk, size: 14266 [annotate] [blame] [check-ins using] [diff]

SIGKILL was a little bit too much. file: [dc696d6c83] check-in: [3ff339cf42] user: js, branch: trunk, size: 14204 [annotate] [blame] [check-ins using] [diff]

The old behaviour where the exception would access errno directly on
creation of the exception was very fragile. The two main problems with
it were that sometimes it would pick up an errno even though none had
been set and in other cases that when the exception was created errno
had already been overridden.

This also greatly increases errno handling on Win32, especially in
conjunction with sockets. It can still be improved further, though. file: [5b951c5966] check-in: [62e2de30b9] user: js, branch: trunk, size: 14203 [annotate] [blame] [check-ins using] [diff]

This replaces +[OFString nativeOSEncoding]. file: [940798f49a] check-in: [ec66e49dca] user: js, branch: trunk, size: 11983 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [486d495193] check-in: [13ee56edf3] user: js, branch: trunk, size: 11946 [annotate] [blame] [check-ins using] [diff]

After all, this might (and does for OFArray_adjacent!) return an
internal representation that must not be changed, so changes should be
prevented at compile-time. file: [bf59320c7a] check-in: [68d32a92c1] user: js, branch: trunk, size: 11990 [annotate] [blame] [check-ins using] [diff]

Instead, just define _GNU_SOURCE when __GLIBC__ is defined. After all,
that's the only libc that doesn't work properly without any defines. file: [816fb9bfe7] check-in: [17be12b6e5] user: js, branch: trunk, size: 11893 [annotate] [blame] [check-ins using] [diff]

LLP64 was mostly fast enumeration using an unsigned long for the state,
which can't store a pointer or a size_t on LLP64. This is now solved by
either throwing an OFOutOfRangeException if the value of the size_t is
bigger than ULONG_MAX or storing the pointer in the extra field (copied
using memcpy, as it's an array of unsigned long, which again would be
too small to store a pointer).

Win64 was mostly Microsoft not being able to decide whether a length is
a size_t, a DWORD, an int or an unsigned int (thus the different types
in places that seem to be almost the same). But since that would not be
confusing enough, a file descriptor is an int if it's for a file, but a
long long if it is for a socket. But of course, for ReadFile and friends
it's a DWORD instead of an int then. file: [f1314df72d] check-in: [4e59d2692f] user: js, branch: trunk, size: 11916 [annotate] [blame] [check-ins using] [diff]

Not using -std=gnu11 means _GNU_SOURCE does not get defined anymore,
therefore this commit also adds the required feature defines for glibc.

Additionally, this adds of_strdup in macros.h, as strdup is an
extension. file: [69b09cd9ef] check-in: [2f5af58573] user: js, branch: trunk, size: 11542 [annotate] [blame] [check-ins using] [diff]

This is in preparation for adding UDP sockets, as UDP sockets and TCP
sockets have no common superclass, as one is stream-oriented while the
other is packet-oriented.

Read and write exceptions are for any object now, as they are useful for
a lot more than just for streams, while the others (bind, listen, etc.)
are for any socket now (the type is id in this case, though, as there is
no common superclass). file: [754335c8dd] check-in: [8d2a5052fd] user: js, branch: trunk, size: 11519 [annotate] [blame] [check-ins using] [diff]

This replaces OF_STRING_ENCODING_NATIVE, as a define was not flexible
enough (determining the native OS encoding at startup was not possible). file: [8b087c9ef5] check-in: [e54c8c0368] user: js, branch: trunk, size: 11519 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [6a59691f03] check-in: [3d16a30f41] user: js, branch: trunk, size: 11311 [annotate] [blame] [check-ins using] [diff]

It is now called -[readDataArrayWithCount:]. file: [499c5dab3d] check-in: [eceebefeab] user: js, branch: trunk, size: 11368 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [c2449bdcce] check-in: [c5ef582958] user: js, branch: trunk, size: 11354 [annotate] [blame] [check-ins using] [diff]

This reverts 5362941.

Even though *UsingEncoding: is what Foundation uses, *WithEncoding: is
more natural and is more consistent with the rest. Also, this means this
restores it to the API of 0.7. file: [8542470fa0] check-in: [9ddd33a258] user: js, branch: trunk, size: 11279 [annotate] [blame] [check-ins using] [diff]

It is now -[fileDescriptorForReading] and -[fileDescriptorForWriting].
The split was necessary as some stream types (e.g. OFProcess) don't have
a single file descriptor, but two. This allows to use those stream types
with OFStreamObserver as well. file: [fe517b8418] check-in: [440e95fd4a] user: js, branch: trunk, size: 7969 [annotate] [blame] [check-ins using] [diff]

This greatly improves performance, as it gets rid of the overhead of
OFAutoreleasePool. file: [769871dec1] check-in: [1255f3a11a] user: js, branch: trunk, size: 7808 [annotate] [blame] [check-ins using] [diff]

Also fix a bug where OFBigDataArray would waste memory. file: [6f88407ce3] check-in: [f7576a66ce] user: js, branch: trunk, size: 7734 [annotate] [blame] [check-ins using] [diff]

This is required for the new array literals. file: [53a70ada66] check-in: [008be86a16] user: js, branch: trunk, size: 7728 [annotate] [blame] [check-ins using] [diff]

Win32 implementation following later. file: [a1d37f278e] check-in: [02ab9aa8a9] user: js, branch: trunk, size: 2901 [annotate] [blame] [check-ins using]