ObjFW  History of src/OFKernelEventObserver_select.m of 462cb8a1087c2d69

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [e0ca96b99e] check-in: [2f4e0df8be] user: js, branch: trunk, size: 5131 [annotate] [blame] [check-ins using] [diff]

This matches Apple's style. file: [ab8bd97091] check-in: [6b77a5dd8b] user: js, branch: trunk, size: 5117 [annotate] [blame] [check-ins using] [diff]

This is required to make it work on MorphOS with -noixemul, as socket
functions take UBYTE * arguments instead then, resulting in a warning
about signedness because char is signed. file: [ca3998cc6e] check-in: [c658e97994] user: js, branch: trunk, size: 5117 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [c61d00fafb] check-in: [44f45c2e35] user: js, branch: trunk, size: 5076 [annotate] [blame] [check-ins using] [diff]

FreeBSD stupidly defines this as 1024U, which breaks -Wsign-compare. file: [8eb037b6d9] check-in: [d9398f2439] user: js, branch: trunk, size: 5070 [annotate] [blame] [check-ins using] [diff]

This makes sure the correct type is used for FD_*. file: [851bfffddf] check-in: [e74fc30f5b] user: js, branch: trunk, size: 5045 [annotate] [blame] [check-ins using] [diff]

_readObjects must only be changed from the thread running the observer
and not from a thread adding or removing objects to observe. This is
already handled by the locked queue used by poll and select, so the best
way to solve this is to use the locked queue for kqueue and epoll as
well. file: [bb7655fa57] check-in: [85917ea0dd] user: js, branch: 0.8, size: 4893 [annotate] [blame] [check-ins using] [diff]

_readObjects must only be changed from the thread running the observer
and not from a thread adding or removing objects to observe. This is
already handled by the locked queue used by poll and select, so the best
way to solve this is to use the locked queue for kqueue and epoll as
well. file: [e66acd4ec0] check-in: [45518ae7b7] user: js, branch: trunk, size: 4955 [annotate] [blame] [check-ins using] [diff]

This was broken by 88f2f03. The problem only existed when something was
in the read buffer, but not processed completely, as after processing
the read buffer, it would go on to wait for data - but since not the
entire read buffer had been processed, it meant there was still data
left there that needed to be handled first. file: [fe3f6e4f8e] check-in: [b84490ab4f] user: js, branch: 0.8, size: 4703 [annotate] [blame] [check-ins using] [diff]

This was broken by 88f2f03. The problem only existed when something was
in the read buffer, but not processed completely, as after processing
the read buffer, it would go on to wait for data - but since not the
entire read buffer had been processed, it meant there was still data
left there that needed to be handled first. file: [c7ee699c53] check-in: [7ae17af9f0] user: js, branch: trunk, size: 4765 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [8f5e338344] check-in: [cec0f072f8] user: js, branch: 0.8, size: 4765 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [c497599b97] check-in: [2a27cf3000] user: js, branch: trunk, size: 4816 [annotate] [blame] [check-ins using] [diff]

This moves the locked queue for actions to
OFKernelEventObserver_LockedQueue, which is now used for select and
poll, but skipped for kqueue and epoll, as they natively support changes
from another thread.

This fixes the problem that removing an object is delayed until the next
observe call - at which point it might have already been closed, meaning
the fd is no longer available. This was mainly a problem with kqueue, as
closing the fd already removed it from the kqueue, which then resulted
in an error being returned when trying to manually remove the fd from
the kqueue. file: [6e6cb25888] check-in: [c5f0c5f9ba] user: js, branch: 0.8, size: 4761 [annotate] [blame] [check-ins using] [diff]

This moves the locked queue for actions to
OFKernelEventObserver_LockedQueue, which is now used for select and
poll, but skipped for kqueue and epoll, as they natively support changes
from another thread.

This fixes the problem that removing an object is delayed until the next
observe call - at which point it might have already been closed, meaning
the fd is no longer available. This was mainly a problem with kqueue, as
closing the fd already removed it from the kqueue, which then resulted
in an error being returned when trying to manually remove the fd from
the kqueue. file: [8f0b3058db] check-in: [e9b4700cb6] user: js, branch: trunk, size: 4812 [annotate] [blame] [check-ins using] [diff]

This fixes the tests on Wii. file: [a5041a4d1e] check-in: [4cecf82254] user: js, branch: trunk, size: 4717 [annotate] [blame] [check-ins using] [diff]

This was necessary because select(), poll() and kevent() on FreeBSD and
OS X would sometimes return 0 events, even if there are some, and
sometimes return the correct number of events that were pending, meaning
the number of events returned is unreliable. To make things worse,
whether it returns 0 or the number of events that were pending is
completely non-deterministic on both FreeBSD and OS X (running the same
tests multiple times in a row would make it sometimes work and sometimes
fail).

In order to prevent code from depending on the return value of
-[observeForTimeInterval:] (which would depend on select(), poll() and
kevent() returning the correct number), OFKernelObserver no longer
returns whether there were pending events. It is expected that
-[observe] or -[observeForTimeInterval:] is just called in a loop as
long as events should be handled.

The tests have been changed as well to reflect this. What they do now is
set a deadline and call -[observeForTimeInterval:] with a small timeout
in a loop until the deadline is reached or all events have been handled.

Note: DragonFlyBSD has not been tested, but will most likely behave like
FreeBSD and OS X. file: [331bf675cd] check-in: [220513a3f5] user: js, branch: trunk, size: 4581 [annotate] [blame] [check-ins using] [diff]

Instead, FD_SETSIZE is the number of file descriptors supported by
select(), independent of the actual file descriptor number.

The default value is 64, even though it seems that Win32 supports much
more than that. Thus, this is defined to 1024 on Win32 now. file: [6084d13774] check-in: [a2738e1a3d] user: js, branch: trunk, size: 4209 [annotate] [blame] [check-ins using] [diff]

Not retaining them caused kevent() to be called on an invalid fd. file: [23f65818a3] check-in: [1dbe9a4e4e] user: js, branch: trunk, size: 3523 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [b091506593] check-in: [13ee56edf3] user: js, branch: trunk, size: 3501 [annotate] [blame] [check-ins using] [diff]

After all, this might (and does for OFArray_adjacent!) return an
internal representation that must not be changed, so changes should be
prevented at compile-time. file: [71a3935230] check-in: [68d32a92c1] user: js, branch: trunk, size: 3544 [annotate] [blame] [check-ins using] [diff]

LLP64 was mostly fast enumeration using an unsigned long for the state,
which can't store a pointer or a size_t on LLP64. This is now solved by
either throwing an OFOutOfRangeException if the value of the size_t is
bigger than ULONG_MAX or storing the pointer in the extra field (copied
using memcpy, as it's an array of unsigned long, which again would be
too small to store a pointer).

Win64 was mostly Microsoft not being able to decide whether a length is
a size_t, a DWORD, an int or an unsigned int (thus the different types
in places that seem to be almost the same). But since that would not be
confusing enough, a file descriptor is an int if it's for a file, but a
long long if it is for a socket. But of course, for ReadFile and friends
it's a DWORD instead of an int then. file: [434ba010aa] check-in: [4e59d2692f] user: js, branch: trunk, size: 3538 [annotate] [blame] [check-ins using] [diff]

It is no longer limited to streams now. file: [d61b6807c3] check-in: [c694569d86] user: js, branch: trunk, size: 3472 [annotate] [blame] [check-ins using] [diff]