ObjFW  History of src/OFMapTable.h of 42ab7308b9337244

This essentially made it a shift rather than a rotate, sometimes
shifting most or even all of the bits out and making all hashes collide. file: [3ab57c4538] check-in: [ae4879fe0d] user: js, branch: trunk, size: 7678 [annotate] [blame] [check-ins using] [diff]

With TYPEDEF_HIDES_STRUCT set, Doxygen properly handles anonymous
structs and enums that are typedef'd. file: [67af88b431] check-in: [2fcf5a3052] user: js, branch: trunk, size: 7688 [annotate] [blame] [check-ins using] [diff]

This is only migrating some places, others will be migrated as they are
touched. file: [428b0aea8c] check-in: [a0fd103a0b] user: js, branch: trunk, size: 7869 [annotate] [blame] [check-ins using] [diff]

The internal hash is still 32 bit in most places, but this way, it is at
least not baked into the API and ABI and can be upgraded later, should
that ever be necessary. file: [7fe069efae] check-in: [aeb403a1ed] user: js, branch: trunk, size: 7956 [annotate] [blame] [check-ins using] [diff]

This allows ABI stability with the fragile ABI. file: [b6dd6c63b6] check-in: [496695d778] user: js, branch: trunk, size: 7905 [annotate] [blame] [check-ins using] [diff]

It's not very useful and is a problem for the Foundation bridge, as
NSEnumerator does not have it. file: [1f1f29d31e] check-in: [7214a2c7af] user: js, branch: trunk, size: 7879 [annotate] [blame] [check-ins using] [diff]

This improves Swift compatibility. file: [36496cd646] check-in: [f3ccf14461] user: js, branch: trunk, size: 7959 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [df99b8af7c] check-in: [2f4e0df8be] user: js, branch: trunk, size: 7998 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [1bd4f42cb6] check-in: [4af49a13c3] user: js, branch: trunk, size: 7573 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [7e670427ae] check-in: [44f45c2e35] user: js, branch: trunk, size: 7558 [annotate] [blame] [check-ins using] [diff]

The reason for this is that -[valueForKey:] could be confused with
Key Value Coding. file: [2c4d7aef99] check-in: [1ba9c051a6] user: js, branch: trunk, size: 7552 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [8c1fa384ac] check-in: [cec0f072f8] user: js, branch: 0.8, size: 7578 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [65a71eea19] check-in: [2a27cf3000] user: js, branch: trunk, size: 7457 [annotate] [blame] [check-ins using] [diff]

This increases the required GCC version from 4.0 to 4.6 (exception:
Apple GCC, which already supports this with >= 4.0 starting with OS X
10.5). Since even GCC 4.6 is really old by now, there is no point in
still supporting something even older and making the code ugly because
of that. While some hardware and OS support was dropped from GCC 4.6
compared to GCC 4.0, there is nothing in there that would be an
interesting target with the exception of BeOS maybe - but a port to BeOS
can also be achieved using the Haiku support. The other dropped OSes are
mostly old versions of OSes while newer ones are still being supported
(and those newer versions of those OSes still support the same
hardware). file: [761c1c436d] check-in: [48980f2297] user: js, branch: trunk, size: 7453 [annotate] [blame] [check-ins using] [diff]

Now that Clang switched to use _Nullable and _Nonnull instead of
__nullable / __nonnull, there is no longer a conflict with glibc, which
means we can just define _Nullable / _Nonnull to nothing if they are not
understood by the compiler (which did not work with __nullable /
__nonnull due to this conflict).

This also defines _Null_unspecified to nothing if unavailable. file: [fa70b8daed] check-in: [d526d938d7] user: js, branch: trunk, size: 7557 [annotate] [blame] [check-ins using] [diff]

Using __nonnull directly doesn't work on systems using glibc, as glibc
defines __nonnull as a parameterized define. While this does not fix the
problem of Clang introducing __nonnull even though it conflicts with
glibc, this at least means it's possible again to compile things with
versions of Clang that don't support __nonnull on systems with glibc. file: [a855386419] check-in: [b7097a67b6] user: js, branch: trunk, size: 7574 [annotate] [blame] [check-ins using] [diff]

This also removes "bool *stop" from some blocks where it does not make
sense. file: [aa28d14053] check-in: [e8473b9db8] user: js, branch: trunk, size: 7652 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [e819467858] check-in: [c5ef582958] user: js, branch: trunk, size: 7234 [annotate] [blame] [check-ins using] [diff]

This was already implemented in OFDictionary_hashtable for internal
usage and is now publicly available. file: [98630c9c0b] check-in: [4fb0f4bf66] user: js, branch: trunk, size: 7234 [annotate] [blame] [check-ins using] [diff]

This makes the map table use the full range of the hash and not only the
least significant bits, making it harder for an attacker to find
collisions. file: [3754665273] check-in: [7cebeaa808] user: js, branch: trunk, size: 7230 [annotate] [blame] [check-ins using] [diff]

By rotating the hash by a random number of bits, an attacker needs to
find collisions on the full 32 bits of the hash and not only on the
lower n bits that are actually used by the map table, as an attacker
can't know which bits are actually used for the map table. file: [91b9317d21] check-in: [4857107479] user: js, branch: trunk, size: 7246 [annotate] [blame] [check-ins using] [diff]

This should make it impossible to retrieve of_hash_seed by inserting
keys into a hashtable and then retrieving the hashtable. Without this
change, the order could be used to make guesses about of_hash_seed,
which could be a problem for long running processes. file: [5b6730706a] check-in: [590fa6ed79] user: js, branch: trunk, size: 7229 [annotate] [blame] [check-ins using] [diff]