ObjFW  History of tests/OFStringTests.m of 3be13d358fb74006

It has been moved to the "unicode-normalization" branch until it is
ready. file: [87480291e6] check-in: [149874777c] user: js, branch: trunk, size: 57924 [annotate] [blame] [check-ins using] [diff]

It's just a less awkward name and also what the BSDs use. file: [4230f34f7e] check-in: [b7a4e61b88] user: js, branch: trunk, size: 58309 [annotate] [blame] [check-ins using] [diff]

ObjFW's style changed over the years, but the tests were never adjusted
to it. file: [ebff40f9d8] check-in: [14f1e22d79] user: js, branch: trunk, size: 57247 [annotate] [blame] [check-ins using] [diff]

This makes it clearer that these return a string and not a hash object. file: [bc3d5b4b0a] check-in: [b5a74319e1] user: js, branch: trunk, size: 54648 [annotate] [blame] [check-ins using] [diff]

strtod() on HP-UX does not accept NaN. file: [27d0709520] check-in: [cd4fd689d6] user: js, branch: trunk, size: 54612 [annotate] [blame] [check-ins using] [diff]

amiga-gcc now has strto(u)ll. file: [1ca0b0e0e8] check-in: [5f494eaf81] user: js, branch: trunk, size: 54264 [annotate] [blame] [check-ins using] [diff]

This solves the old signed vs. unsigned problem and allows for more
bases than just 8, 10 and 16, as well as auto-detection of the base (if
base is 0). file: [1264b0c686] check-in: [b6ee372b98] user: js, branch: trunk, size: 54264 [annotate] [blame] [check-ins using] [diff]

OFAutoreleasePools have long been discouraged in favor of the runtime's
autorelease pools. file: [c26219a4ab] check-in: [09be825f88] user: js, branch: trunk, size: 53972 [annotate] [blame] [check-ins using] [diff]

The idea was to have garbage before and remove it with the + 3, to
prevent compilers from potentially being smart in the future and
stripping the BOM. This hasn't happened, and instead they got smarter
with warnings, so remove that hack. file: [e7c58a38d5] check-in: [efb964a3ae] user: js, branch: trunk, size: 53931 [annotate] [blame] [check-ins using] [diff]

This prevents forgetting to add an import to ObjFW.h, as the tests would
then not compile. file: [0918342cf7] check-in: [dc0c6c34ab] user: js, branch: trunk, size: 48427 [annotate] [blame] [check-ins using] [diff]

The reason for this is that, in theory, this also supports versions
older than 3. file: [9c3fe0a3f0] check-in: [5831626f68] user: js, branch: trunk, size: 43925 [annotate] [blame] [check-ins using] [diff]

Note: There is still some weirdness in the compiler. Instead of
m68k-amigaos-gcc, you need to use m68k-amigaos-g++ as OBJC, as otherwise
exceptions don't work.

Before running the tests, you need to run "stack 8192". file: [e81e35af26] check-in: [49cb6ada5f] user: js, branch: trunk, size: 43917 [annotate] [blame] [check-ins using] [diff]

These were way too simplistic, as paths differ in more than just that on
various operating systems. file: [bb51e4a860] check-in: [156b850131] user: js, branch: trunk, size: 37241 [annotate] [blame] [check-ins using] [diff]

This is the first step to have different versions of those for different
operating systems, rather than #ifdefs everywhere.

This also has the nice side-effect of not having one implementation in
OFString and another one in OFString_UTF8 anymore. The one in OFString
was a generic version, while the one in OFString_UTF8 was one optimized
for UTF-8 strings. Now only the version optimized for UTF-8 strings
exists, as this is by far the most common string implementation used,
and the overhead of converting from something else to UTF-8 is not more
than converting to UTF-32. file: [979ff3e546] check-in: [7a488c3062] user: js, branch: trunk, size: 36099 [annotate] [blame] [check-ins using] [diff]

There is no reliable way to check if C++ already defined those, as Clang
now defines char{16,32}_t even when it is not in C++ 11 mode. So we
cannot check if we are not in C++ 11 and then define them and otherwise
rely on the C++ 11 types. file: [0e68977055] check-in: [505137f25f] user: js, branch: trunk, size: 36031 [annotate] [blame] [check-ins using] [diff]

This now prevents double slashes / backslashes. file: [4115eec41d] check-in: [80ac05eb8f] user: js, branch: trunk, size: 35543 [annotate] [blame] [check-ins using] [diff]

This is now unreserved + sub-delims from RFC 3986. file: [56c53e54e1] check-in: [4db6713bda] user: js, branch: trunk, size: 33881 [annotate] [blame] [check-ins using] [diff]

This removes the special handling dependent on the scheme. file: [e5125c6f6a] check-in: [0f995db06d] user: js, branch: trunk, size: 33881 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [71dce1ac50] check-in: [2f4e0df8be] user: js, branch: trunk, size: 33896 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [1397ae7a5c] check-in: [4af49a13c3] user: js, branch: trunk, size: 33320 [annotate] [blame] [check-ins using] [diff]

These are usually not used, as OFString_UTF8 and OFMutableString_UTF8
are used instead. However, they are used if someone creates their own
subclass of OFString / OFMutableString. As they are rarely used in
production, it is important to run all tests on them. file: [c38d6eca4f] check-in: [7926b47265] user: js, branch: trunk, size: 33312 [annotate] [blame] [check-ins using] [diff]

This allows building a smaller ObjFW if those are not needed. file: [356111a391] check-in: [766eedef4c] user: js, branch: trunk, size: 30055 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [c419daf0e5] check-in: [44f45c2e35] user: js, branch: trunk, size: 29770 [annotate] [blame] [check-ins using] [diff]

This avoids the hacks introduced in the previous commit, if those
functions are available. file: [e6c617fc86] check-in: [0ad678f125] user: js, branch: trunk, size: 29764 [annotate] [blame] [check-ins using] [diff]

This is achieved by replacing the locale's decimal point with "." after
formatting and replacing "." with the locale's decimal point before
parsing.

To still use the decimal point from the locale for formatting, the new
flag "," is introduced to formats. This is useful for just printing a
string to the user that is not saved to a file or sent via a network.

While this is an ugly hack, there is no better way to do this other than
implementing the functionality of printf and strtod myself, as POSIX
does not specify versions of these that take a locale as an argument.
While this is a lot of work and error-prone, I will most likely end up
doing this eventually.

This commit also enables the locale in OFApplication to notice when
things break. As a nice side effect, ofhttp now uses the locale's
decimal point in its user interface. file: [cd4f1dfd47] check-in: [6dff0f5922] user: js, branch: trunk, size: 29298 [annotate] [blame] [check-ins using] [diff]

This is only useful for size-constrained systems and changes the
behavior as follows:

* Case-insensitive comparisons only work as expected for ASCII
characters. This means that while a and A compare equal, ä and Ä do
not.

* -[OFMutableString {upper,lower}] and
-[OFString {upper,lower}caseString] only work on ASCII characters;
all other characters are left as they are. This means that the upper
version of a is A, but the upper version of ä is still ä (and vice
versa for lower). file: [461bffb20c] check-in: [b7b33247d6] user: js, branch: trunk, size: 29529 [annotate] [blame] [check-ins using] [diff]

This should only be done for the query string. file: [fa45237488] check-in: [32bc855af9] user: js, branch: trunk, size: 28544 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [57ac9cdadf] check-in: [cec0f072f8] user: js, branch: 0.8, size: 28351 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [81aaac2175] check-in: [2a27cf3000] user: js, branch: trunk, size: 28361 [annotate] [blame] [check-ins using] [diff]

This creates a common base for OFSHA224Hash and OFSHA256Hash so that all
code (except the different initialization constants) is reused. file: [12160603c8] check-in: [a1931f59a2] user: js, branch: trunk, size: 27644 [annotate] [blame] [check-ins using] [diff]

Took me some time to figure out the RFC is buggy and SSIG0(t-15) should
be SSIG0(W(t-15))... file: [c1024c04d0] check-in: [46af1252a5] user: js, branch: trunk, size: 27511 [annotate] [blame] [check-ins using] [diff]

Additionally, OFXMLParser now uses OFMalformedXMLException instead of
OFInvalidFormatException on invalid entities. file: [08a115e708] check-in: [6e5a920567] user: js, branch: trunk, size: 27364 [annotate] [blame] [check-ins using] [diff]

This is undefined behavior. file: [3e77d0dde3] check-in: [0d37286ccb] user: js, branch: trunk, size: 27328 [annotate] [blame] [check-ins using] [diff]

No functional change intended. file: [aef3727a76] check-in: [9da9b2b64c] user: js, branch: trunk, size: 27270 [annotate] [blame] [check-ins using] [diff]

The port was much easier than expected. The only changes that were
required were defining the missing lrint() and useconds_t, the rest was
optional (like using backslashes for paths, even though slashes work
fine). file: [14295c4581] check-in: [a0b63a8df4] user: js, branch: trunk, size: 24375 [annotate] [blame] [check-ins using] [diff]

Includes:
* Check environ against NULL before using it, since Android sets it to
NULL.
* Cast st_size of struct stat to off_t. Android uses long long for
st_size as its off_t is only 32 bit, but st_size should be off_t
according to POSIX.
* Android's strtod() does not accept 0x, as specified by C99. Thus,
the test is disabled if __ANDROID__ is defined. file: [3c7c95496c] check-in: [c5e7dd679b] user: js, branch: trunk, size: 24162 [annotate] [blame] [check-ins using] [diff]

This removes -[initWithPath:,...], so that it's finally possible to use
-[initWithPath:] for many places where a workaround like
-[initWithDirectoryPath:] was required before. file: [a5ba78df50] check-in: [7c4179ab9b] user: js, branch: trunk, size: 23218 [annotate] [blame] [check-ins using] [diff]

The resizing is now done before the memmove() if the new string is
bigger and after the memmove() if the new string is shorter. The added
comment explains why this is necessary.

This also adds a test for -[replaceCharactersInRange:withString:] that
makes the string bigger and another one that makes it smaller again. file: [fbc369ef09] check-in: [4d892e0db1] user: js, branch: trunk, size: 23140 [annotate] [blame] [check-ins using] [diff]

This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.

This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. file: [a5554c7700] check-in: [3d16a30f41] user: js, branch: trunk, size: 23010 [annotate] [blame] [check-ins using] [diff]

The only places where BOOL is left are those where they are required by
the ABI. file: [5f1c00ddf1] check-in: [c5ef582958] user: js, branch: trunk, size: 23025 [annotate] [blame] [check-ins using] [diff]

This partly reverts e8502c7.

The rationale behind this is that, on some OSes, native APIs (on e.g.
Windows) take UTF-16 strings that are zero-terminated.

However, forcing zero-termination for every string so that -[characters]
returns a zero-terminated UTF-32 string does not make sense. Therefore,
in the future, -[UTF32String] will be added, which will include
zero-termination. OFString subclasses can then just return their
internal representation if it includes a terminating zero or create a
copy that has a terminating zero if not. file: [7f9159fd57] check-in: [9d3cd5e5fe] user: js, branch: trunk, size: 22619 [annotate] [blame] [check-ins using] [diff]

* Instead of Unicode "strings", it uses the term "Unicode character
array".
* No terminating 0 character anymore, as these are not C strings
anyway. file: [e613d6ae06] check-in: [640b225ba7] user: js, branch: trunk, size: 22493 [annotate] [blame] [check-ins using] [diff]

This should make it more future-proof, as adding new options is easier
than adding new methods for each and every combination of options. file: [7769c4140e] check-in: [fcaa549324] user: js, branch: trunk, size: 22277 [annotate] [blame] [check-ins using] [diff]

It is a class cluster now, but there is still much to improve. file: [6206f4255c] check-in: [301ee63212] user: js, branch: trunk, size: 21376 [annotate] [blame] [check-ins using] [diff]

* found* renamed to didFind*.
* Support for parsing CDATA.
* Handle comments with - correctly.
* Don't strip leading and trailing whitespaces in comments.
* Rename a few states for more clarity.
* More OFXMLParser tests. file: [b8a81af19d] check-in: [9d79d92d9a] user: js, branch: trunk, size: 13899 [annotate] [blame] [check-ins using] [diff]