ObjFW  History of src/OFKernelEventObserver.m of 1b09ca22f34e69b9

On game consoles, initializing sockets takes a significant amount of
time. When not delaying socket initializing, that time is spent during
startup even when the application might never use sockets.

Worse yet, on Amiga, sockets might not be available at all and the
application will fail to start up, even when the application might never
use sockets. file: [6e35982883] check-in: [7460d2ccd8] user: js, branch: trunk, size: 6584 [annotate] [blame] [check-ins using] [diff]

It doesn't seem to be needed anymore. file: [d1c33bf38e] check-in: [cf0effe834] user: js, branch: trunk, size: 6244 [annotate] [blame] [check-ins using] [diff]

This allows for a much cleaner solution to avoid the internal read
buffer of e.g. a TLS connection never being processed while waiting for
a delimiter. file: [d1361f5797] check-in: [a61e0594b4] user: js, branch: trunk, size: 6266 [annotate] [blame] [check-ins using] [diff]

Check for AmigaOS first, as we have a special implementation for it that
uses WaitSelect() instead. This way, we no longer need to match $host_os
to manually disable the pipe() check, which would break if one of the
AmigaOS variants adds pipe() later on. file: [451fcb3cdf] check-in: [d76213374e] user: js, branch: trunk, size: 6384 [annotate] [blame] [check-ins using] [diff]

This removes the ability to let a thread add or remove objects for
another thread. This features wasn't used at all, but caused significant
problems with kqueue and epoll, as this often resulted in removing a
file descriptor after it had already been closed. file: [6cc4e842a3] check-in: [24eff635db] user: js, branch: trunk, size: 6160 [annotate] [blame] [check-ins using] [diff]

Instead, explicitly declare them, as OF_ASSUME_NONNULL_{BEGIN,END} does
not apply to implicit return types. This means that after this commit,
all init methods have a nonnull return type, as they should have. file: [10e66eceba] check-in: [2f4e0df8be] user: js, branch: trunk, size: 8944 [annotate] [blame] [check-ins using] [diff]

Previously, socket_helpers.h would just define close() to whatever is
needed to close a socket. However, this makes it possible to
accidentally call a socket-specific close on something that is not a
socket. Having to explicitly call closesocket() (and defining it to
close() on platforms where it's the same) prevents this. file: [01c61511ac] check-in: [b4cd87cd81] user: js, branch: trunk, size: 8919 [annotate] [blame] [check-ins using] [diff]

This matches Apple's style. file: [1a2dbaaf85] check-in: [6b77a5dd8b] user: js, branch: trunk, size: 8794 [annotate] [blame] [check-ins using] [diff]

This is required to make it work on MorphOS with -noixemul, as socket
functions take UBYTE * arguments instead then, resulting in a warning
about signedness because char is signed. file: [75fadf5f06] check-in: [c658e97994] user: js, branch: trunk, size: 8788 [annotate] [blame] [check-ins using] [diff]

Casts are now written like types in variable declarations. file: [687f558fe2] check-in: [4af49a13c3] user: js, branch: trunk, size: 8881 [annotate] [blame] [check-ins using] [diff]

Forgot to add 2017, even though I already did quite some changes in
2017. file: [02536e25d0] check-in: [44f45c2e35] user: js, branch: trunk, size: 8868 [annotate] [blame] [check-ins using] [diff]

This removes the port registry that existed for the Wii and instead
tries binding to random ports in a loop until it succeeds or errno is
not EADDRINUSE. This is done for the Wii and Nintendo 3DS now.

This also includes several other socket-related cleanups. file: [abf69b00a7] check-in: [12b8a7552e] user: js, branch: trunk, size: 8862 [annotate] [blame] [check-ins using] [diff]

_readObjects must only be changed from the thread running the observer
and not from a thread adding or removing objects to observe. This is
already handled by the locked queue used by poll and select, so the best
way to solve this is to use the locked queue for kqueue and epoll as
well. file: [2f243bf470] check-in: [85917ea0dd] user: js, branch: 0.8, size: 8743 [annotate] [blame] [check-ins using] [diff]

_readObjects must only be changed from the thread running the observer
and not from a thread adding or removing objects to observe. This is
already handled by the locked queue used by poll and select, so the best
way to solve this is to use the locked queue for kqueue and epoll as
well. file: [e992bd3e10] check-in: [45518ae7b7] user: js, branch: trunk, size: 8571 [annotate] [blame] [check-ins using] [diff]

This was broken by 88f2f03. The problem only existed when something was
in the read buffer, but not processed completely, as after processing
the read buffer, it would go on to wait for data - but since not the
entire read buffer had been processed, it meant there was still data
left there that needed to be handled first. file: [b44fb07041] check-in: [b84490ab4f] user: js, branch: 0.8, size: 5712 [annotate] [blame] [check-ins using] [diff]

This was broken by 88f2f03. The problem only existed when something was
in the read buffer, but not processed completely, as after processing
the read buffer, it would go on to wait for data - but since not the
entire read buffer had been processed, it meant there was still data
left there that needed to be handled first. file: [1613a72d1b] check-in: [7ae17af9f0] user: js, branch: trunk, size: 5487 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [74500121cd] check-in: [cec0f072f8] user: js, branch: 0.8, size: 5514 [annotate] [blame] [check-ins using] [diff]

While at it, also update the mail address. file: [39f30ed249] check-in: [2a27cf3000] user: js, branch: trunk, size: 5387 [annotate] [blame] [check-ins using] [diff]

kqueue and epoll were not updating _readObjects and _writeObjects
anymore, since this was done by the queue handling code, which they no
longer use after the refactorization. file: [5076db7548] check-in: [d1c4c46706] user: js, branch: 0.8, size: 5510 [annotate] [blame] [check-ins using] [diff]

kqueue and epoll were not updating _readObjects and _writeObjects
anymore, since this was done by the queue handling code, which they no
longer use after the refactorization. file: [952d94c390] check-in: [258b8a4944] user: js, branch: trunk, size: 5383 [annotate] [blame] [check-ins using] [diff]

This moves the locked queue for actions to
OFKernelEventObserver_LockedQueue, which is now used for select and
poll, but skipped for kqueue and epoll, as they natively support changes
from another thread.

This fixes the problem that removing an object is delayed until the next
observe call - at which point it might have already been closed, meaning
the fd is no longer available. This was mainly a problem with kqueue, as
closing the fd already removed it from the kqueue, which then resulted
in an error being returned when trying to manually remove the fd from
the kqueue. file: [8054f8aa66] check-in: [c5f0c5f9ba] user: js, branch: 0.8, size: 5343 [annotate] [blame] [check-ins using] [diff]

This moves the locked queue for actions to
OFKernelEventObserver_LockedQueue, which is now used for select and
poll, but skipped for kqueue and epoll, as they natively support changes
from another thread.

This fixes the problem that removing an object is delayed until the next
observe call - at which point it might have already been closed, meaning
the fd is no longer available. This was mainly a problem with kqueue, as
closing the fd already removed it from the kqueue, which then resulted
in an error being returned when trying to manually remove the fd from
the kqueue. file: [898e307ee4] check-in: [e9b4700cb6] user: js, branch: trunk, size: 5216 [annotate] [blame] [check-ins using] [diff]

This increases the required GCC version from 4.0 to 4.6 (exception:
Apple GCC, which already supports this with >= 4.0 starting with OS X
10.5). Since even GCC 4.6 is really old by now, there is no point in
still supporting something even older and making the code ugly because
of that. While some hardware and OS support was dropped from GCC 4.6
compared to GCC 4.0, there is nothing in there that would be an
interesting target with the exception of BeOS maybe - but a port to BeOS
can also be achieved using the Haiku support. The other dropped OSes are
mostly old versions of OSes while newer ones are still being supported
(and those newer versions of those OSes still support the same
hardware). file: [d6c5a9d524] check-in: [48980f2297] user: js, branch: trunk, size: 8050 [annotate] [blame] [check-ins using] [diff]

This is necessary as the Wii does not allow picking a random free port,
and thus we need to track which ports are used. file: [23a24b058b] check-in: [ed4549ddd3] user: js, branch: trunk, size: 8179 [annotate] [blame] [check-ins using] [diff]

This fixes the tests on Wii. file: [b0c771eac2] check-in: [4cecf82254] user: js, branch: trunk, size: 8177 [annotate] [blame] [check-ins using] [diff]

This was necessary because select(), poll() and kevent() on FreeBSD and
OS X would sometimes return 0 events, even if there are some, and
sometimes return the correct number of events that were pending, meaning
the number of events returned is unreliable. To make things worse,
whether it returns 0 or the number of events that were pending is
completely non-deterministic on both FreeBSD and OS X (running the same
tests multiple times in a row would make it sometimes work and sometimes
fail).

In order to prevent code from depending on the return value of
-[observeForTimeInterval:] (which would depend on select(), poll() and
kevent() returning the correct number), OFKernelObserver no longer
returns whether there were pending events. It is expected that
-[observe] or -[observeForTimeInterval:] is just called in a loop as
long as events should be handled.

The tests have been changed as well to reflect this. What they do now is
set a deadline and call -[observeForTimeInterval:] with a small timeout
in a loop until the deadline is reached or all events have been handled.

Note: DragonFlyBSD has not been tested, but will most likely behave like
FreeBSD and OS X. file: [b099b55bf8] check-in: [220513a3f5] user: js, branch: trunk, size: 7927 [annotate] [blame] [check-ins using] [diff]

Removing the FD from the FD -> object mapping results in
OF_processReadBuffers passing nil to objectIsReadyForReading: if there's
still something in the read buffer.

Additionally, this also broke when observing the same object for reading
and writing and then removing it for either reading or writing. file: [57b253b8a0] check-in: [f9ceddcb7d] user: js, branch: trunk, size: 9210 [annotate] [blame] [check-ins using] [diff]

of_getsockname() calls getsockname() after acquiring a mutex. This is
necessary as some implementations of getsockname() are not thread-safe. file: [e8b15decf5] check-in: [f18615e057] user: js, branch: trunk, size: 9103 [annotate] [blame] [check-ins using] [diff]

The old behaviour where the exception would access errno directly on
creation of the exception was very fragile. The two main problems with
it were that sometimes it would pick up an errno even though none had
been set and in other cases that when the exception was created errno
had already been overridden.

This also greatly increases errno handling on Win32, especially in
conjunction with sockets. It can still be improved further, though. file: [83e01ba01e] check-in: [62e2de30b9] user: js, branch: trunk, size: 9076 [annotate] [blame] [check-ins using] [diff]

Not retaining them caused kevent() to be called on an invalid fd. file: [3ffd7510cd] check-in: [1dbe9a4e4e] user: js, branch: trunk, size: 9071 [annotate] [blame] [check-ins using] [diff]

This means that OFObject.h imports macros.h now, making it unnecessary
to manually import macros.h in almost every file. And while at it, also
import autorelease.h in OFObject.h, so that this doesn't need to be
manually imported in almost every file as well. file: [380728b304] check-in: [13ee56edf3] user: js, branch: trunk, size: 8962 [annotate] [blame] [check-ins using] [diff]

After all, this might (and does for OFArray_adjacent!) return an
internal representation that must not be changed, so changes should be
prevented at compile-time. file: [cb71953a13] check-in: [68d32a92c1] user: js, branch: trunk, size: 9005 [annotate] [blame] [check-ins using] [diff]

This replaces -[numberOfBytesInReadBuffer], as it's not always known how
many bytes there are exactly and thus the number would often be wrong
(e.g. because data is compressed). file: [fb20fdd1d1] check-in: [acc999a75e] user: js, branch: trunk, size: 8993 [annotate] [blame] [check-ins using] [diff]

Removed file descriptors were returned in the event list with EBADF if
the file descriptor has been closed before removing them. Interpreting
that as a read event caused problems, as the file descriptor could not
be mapped to an object anymore, thus the entry in the event list is
skipped now if there was a EBADF error. file: [8aa249806a] check-in: [41ca862453] user: js, branch: trunk, size: 9215 [annotate] [blame] [check-ins using] [diff]

It is no longer limited to streams now. file: [71bb648f05] check-in: [c694569d86] user: js, branch: trunk, size: 9111 [annotate] [blame] [check-ins using] [diff]