Differences From Artifact [fc85a500ca]:
- File
src/exceptions/OFHTTPRequestFailedException.m
— part of check-in
[3d16a30f41]
at
2013-06-22 12:12:36
on branch trunk
— Rework exceptions.
This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. (user: js, size: 1909) [annotate] [blame] [check-ins using]
To Artifact [1241a691b7]:
- File src/exceptions/OFHTTPRequestFailedException.m — part of check-in [36d0b1e2d8] at 2013-07-29 19:43:06 on branch trunk — Rename OFHTTPRequestReply to OFHTTPResponse. (user: js, size: 1927) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
17 18 19 20 21 22 23 | #include "config.h" #include <stdlib.h> #import "OFHTTPRequestFailedException.h" #import "OFString.h" #import "OFHTTPRequest.h" | | | | | | | | 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 |
#include "config.h"
#include <stdlib.h>
#import "OFHTTPRequestFailedException.h"
#import "OFString.h"
#import "OFHTTPRequest.h"
#import "OFHTTPResponse.h"
#import "common.h"
@implementation OFHTTPRequestFailedException
+ (instancetype)exceptionWithRequest: (OFHTTPRequest*)request
response: (OFHTTPResponse*)response
{
return [[[self alloc] initWithRequest: request
response: response] autorelease];
}
- init
{
@try {
[self doesNotRecognizeSelector: _cmd];
} @catch (id e) {
[self release];
@throw e;
}
abort();
}
- initWithRequest: (OFHTTPRequest*)request
response: (OFHTTPResponse*)response
{
self = [super init];
_request = [request retain];
_response = [response retain];
return self;
}
- (void)dealloc
{
[_request release];
[_response release];
[super dealloc];
}
- (OFString*)description
{
const char *type = "(unknown)";
|
| ︙ | ︙ | |||
78 79 80 81 82 83 84 | case OF_HTTP_REQUEST_TYPE_POST: type = "POST"; break; } return [OFString stringWithFormat: @"A HTTP %s request with URL %@ failed with code %d!", type, | | | | | 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 |
case OF_HTTP_REQUEST_TYPE_POST:
type = "POST";
break;
}
return [OFString stringWithFormat:
@"A HTTP %s request with URL %@ failed with code %d!", type,
[_request URL], [_response statusCode]];
}
- (OFHTTPRequest*)request
{
OF_GETTER(_request, false)
}
- (OFHTTPResponse*)response
{
OF_GETTER(_response, false)
}
@end
|