Differences From Artifact [fa968ce497]:
- File
src/OFStreamObserver.m
— part of check-in
[e1e7ffa903]
at
2011-09-22 23:25:42
on branch trunk
— Exceptions are now autoreleased.
This is safe as an "exception loop" can't happen, since if allocating
an exception fails, it throws an OFAllocFailedException which is
preallocated and can always be thrown.So, the worst case would be that an autorelease of an exception fails,
triggering an OFOutOfMemoryException for which there is no memory,
resulting in an OFAllocFailedException to be thrown. (user: js, size: 8827) [annotate] [blame] [check-ins using]
To Artifact [b9eb3c11d8]:
- File src/OFStreamObserver.m — part of check-in [87cd99ff88] at 2011-10-24 18:28:28 on branch trunk — Don't retain delegates to prevent reference cycles. (user: js, size: 8756) [annotate] [blame] [check-ins using]
︙ | ︙ | |||
43 44 45 46 47 48 49 | # import "OFStreamObserver_select.h" #endif #import "OFInitializationFailedException.h" #import "OFNotImplementedException.h" #import "OFOutOfRangeException.h" | < < | 43 44 45 46 47 48 49 50 51 52 53 54 55 56 | # import "OFStreamObserver_select.h" #endif #import "OFInitializationFailedException.h" #import "OFNotImplementedException.h" #import "OFOutOfRangeException.h" enum { QUEUE_ADD = 0, QUEUE_REMOVE = 1, QUEUE_READ = 0, QUEUE_WRITE = 2 }; #define QUEUE_ACTION (QUEUE_ADD | QUEUE_REMOVE) |
︙ | ︙ | |||
157 158 159 160 161 162 163 | } - (void)dealloc { close(cancelFD[0]); close(cancelFD[1]); | < | | | 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 | } - (void)dealloc { close(cancelFD[0]); close(cancelFD[1]); [readStreams release]; [writeStreams release]; [queue release]; [queueInfo release]; [queueFDs release]; #ifdef OF_THREADS [mutex release]; #endif [super dealloc]; } - (id <OFStreamObserverDelegate>)delegate { return delegate; } - (void)setDelegate: (id <OFStreamObserverDelegate>)delegate_ { delegate = delegate_; } - (void)addStreamForReading: (OFStream*)stream { [mutex lock]; @try { int qi = QUEUE_ADD | QUEUE_READ; |
︙ | ︙ |