Differences From Artifact [de79d304be]:
- File src/exceptions/OFMoveItemFailedException.m — part of check-in [cfd374b906] at 2015-01-03 20:57:18 on branch trunk — Update copyright (user: js, size: 1697) [annotate] [blame] [check-ins using]
To Artifact [9aecf924e2]:
- File
src/exceptions/OFMoveItemFailedException.m
— part of check-in
[62e2de30b9]
at
2015-02-16 08:39:17
on branch trunk
— Explicitly pass errno to exceptions
The old behaviour where the exception would access errno directly on
creation of the exception was very fragile. The two main problems with
it were that sometimes it would pick up an errno even though none had
been set and in other cases that when the exception was created errno
had already been overridden.This also greatly increases errno handling on Win32, especially in
conjunction with sockets. It can still be improved further, though. (user: js, size: 1900) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
15 16 17 18 19 20 21 | */ #include "config.h" #import "OFMoveItemFailedException.h" #import "OFString.h" | < < > | > > | > | | > > > > | | 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 |
*/
#include "config.h"
#import "OFMoveItemFailedException.h"
#import "OFString.h"
@implementation OFMoveItemFailedException
+ (instancetype)exceptionWithSourcePath: (OFString*)sourcePath
destinationPath: (OFString*)destinationPath
errNo: (int)errNo
{
return [[[self alloc] initWithSourcePath: sourcePath
destinationPath: destinationPath
errNo: errNo] autorelease];
}
- init
{
OF_INVALID_INIT_METHOD
}
- initWithSourcePath: (OFString*)sourcePath
destinationPath: (OFString*)destinationPath
errNo: (int)errNo
{
self = [super init];
@try {
_sourcePath = [sourcePath copy];
_destinationPath = [destinationPath copy];
_errNo = errNo;
} @catch (id e) {
[self release];
@throw e;
}
return self;
}
- (void)dealloc
{
[_sourcePath release];
[_destinationPath release];
[super dealloc];
}
- (OFString*)description
{
if (_errNo != 0)
return [OFString stringWithFormat:
@"Failed to move item at path %@ to %@: %@",
_sourcePath, _destinationPath, of_strerror(_errNo)];
else
return [OFString stringWithFormat:
@"Failed to move item at path %@ to %@!",
_sourcePath, _destinationPath];
}
- (OFString*)sourcePath
{
OF_GETTER(_sourcePath, true)
}
|
| ︙ | ︙ |