Differences From Artifact [dac9f53f6d]:
- File src/OFKernelEventObserver_kqueue.m — part of check-in [92344de237] at 2015-05-08 21:13:52 on branch trunk — OFKernelEventObserver_kqueue: More error checking (user: js, size: 5268) [annotate] [blame] [check-ins using]
To Artifact [306f8337d7]:
- File
src/OFKernelEventObserver_kqueue.m
— part of check-in
[220513a3f5]
at
2015-05-09 18:13:19
on branch trunk
— More OFKernelEventObserver refactoring
This was necessary because select(), poll() and kevent() on FreeBSD and
OS X would sometimes return 0 events, even if there are some, and
sometimes return the correct number of events that were pending, meaning
the number of events returned is unreliable. To make things worse,
whether it returns 0 or the number of events that were pending is
completely non-deterministic on both FreeBSD and OS X (running the same
tests multiple times in a row would make it sometimes work and sometimes
fail).In order to prevent code from depending on the return value of
-[observeForTimeInterval:] (which would depend on select(), poll() and
kevent() returning the correct number), OFKernelObserver no longer
returns whether there were pending events. It is expected that
-[observe] or -[observeForTimeInterval:] is just called in a loop as
long as events should be handled.The tests have been changed as well to reflect this. What they do now is
set a deadline and call -[observeForTimeInterval:] with a small timeout
in a loop until the deadline is reached or all events have been handled.Note: DragonFlyBSD has not been tested, but will most likely behave like
FreeBSD and OS X. (user: js, size: 5089) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
144 145 146 147 148 149 150 | memset(&event, 0, sizeof(event)); event.ident = [object fileDescriptorForWriting]; event.filter = EVFILT_WRITE; event.flags = EV_DELETE; [_changeList addItem: &event]; } | | | | < < < | < < < | 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 |
memset(&event, 0, sizeof(event));
event.ident = [object fileDescriptorForWriting];
event.filter = EVFILT_WRITE;
event.flags = EV_DELETE;
[_changeList addItem: &event];
}
- (void)observeForTimeInterval: (of_time_interval_t)timeInterval
{
void *pool = objc_autoreleasePoolPush();
struct timespec timeout;
struct kevent eventList[EVENTLIST_SIZE];
int i, events;
timeout.tv_sec = (time_t)timeInterval;
timeout.tv_nsec = lrint((timeInterval - timeout.tv_sec) * 1000000000);
/*
* Make sure to keep the streams retained and thus the file descriptors
* valid until the actual change has been performed.
*/
[self OF_processQueueAndStoreRemovedIn: _removedArray];
[self OF_processReadBuffers];
objc_autoreleasePoolPop(pool);
events = kevent(_kernelQueue, [_changeList items],
(int)[_changeList count], eventList, EVENTLIST_SIZE,
(timeInterval != -1 ? &timeout : NULL));
if (events < 0)
@throw [OFObserveFailedException exceptionWithObserver: self
errNo: errno];
[_changeList removeAllItems];
[_removedArray removeAllObjects];
for (i = 0; i < events; i++) {
if (eventList[i].flags & EV_ERROR)
@throw [OFObserveFailedException
exceptionWithObserver: self
errNo: (int)eventList[i].data];
if (eventList[i].ident == _cancelFD[0]) {
|
| ︙ | ︙ | |||
216 217 218 219 220 221 222 | (id)eventList[i].udata]; break; default: assert(0); } objc_autoreleasePoolPop(pool); | | < | < < < < < < | 210 211 212 213 214 215 216 217 218 219 | (id)eventList[i].udata]; break; default: assert(0); } objc_autoreleasePoolPop(pool); } } @end |