Differences From Artifact [cbe290bc1c]:
- File tests/OFDDPSocketTests.m — part of check-in [707206e796] at 2022-10-22 18:32:59 on branch appletalk — OFDDPSocket: Bind with network, node & port (user: js, size: 1994) [annotate] [blame] [check-ins using] [more...]
To Artifact [7798ad31e7]:
- File
tests/OFDDPSocketTests.m
— part of check-in
[9c2f20e736]
at
2022-11-03 00:14:27
on branch trunk
— OFDDPSocket: Don't include the type with the data
This seems to be an oddity limited to OSes that have implemented DDP
exclusively for netatalk, while macOS and Windows don't include it with
the data.While on macOS it's possible to achieve the previous behavior via some
hacks, this is impossible on Windows, so the proper approach is to
handle it like everybody else: Specify the protocol type when binding
and only handle packets of the correct protocol type. (user: js, size: 2076) [annotate] [blame] [check-ins using] [more...]
| ︙ | ︙ | |||
29 30 31 32 33 34 35 |
OFSocketAddress address1, address2;
char buffer[5];
TEST(@"+[socket]", (sock = [OFDDPSocket socket]))
@try {
TEST(@"-[bindToNetwork:node:port:]",
| | > > > | | > | | > | 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 |
OFSocketAddress address1, address2;
char buffer[5];
TEST(@"+[socket]", (sock = [OFDDPSocket socket]))
@try {
TEST(@"-[bindToNetwork:node:port:]",
R(address1 = [sock bindToNetwork: 0
node: 0
port: 0
protocolType: 11]))
} @catch (OFBindSocketFailedException *e) {
switch (e.errNo) {
case EAFNOSUPPORT:
[OFStdOut setForegroundColor: [OFColor lime]];
[OFStdOut writeLine:
@"\r[OFDDPSocket] -[bindToNetwork:node:port:"
@"protocolType:] AppleTalk unsupported, skipping "
@"tests"];
break;
case EADDRNOTAVAIL:
[OFStdOut setForegroundColor: [OFColor lime]];
[OFStdOut writeLine:
@"\r[OFDDPSocket] -[bindToNetwork:node:port:"
@"protocolType:] AppleTalk not configured, "
@"skipping tests"];
break;
default:
@throw e;
}
objc_autoreleasePoolPop(pool);
return;
|
| ︙ | ︙ |