Differences From Artifact [ca95dac731]:
- File src/exceptions/OFHTTPRequestFailedException.h — part of check-in [590c377d8a] at 2013-04-26 19:42:52 on branch trunk — Make it possible to disable sockets. (user: js, size: 2171) [annotate] [blame] [check-ins using]
To Artifact [8a7c6a0eaf]:
- File
src/exceptions/OFHTTPRequestFailedException.h
— part of check-in
[3d16a30f41]
at
2013-06-22 12:12:36
on branch trunk
— Rework exceptions.
This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. (user: js, size: 1990) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
36 37 38 39 40 41 42 | @property (readonly, retain, nonatomic) OFHTTPRequest *request; @property (readonly, retain, nonatomic) OFHTTPRequestReply *reply; #endif /*! * @brief Creates a new, autoreleased HTTP request failed exception. * | < | < | < < | | | 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 | @property (readonly, retain, nonatomic) OFHTTPRequest *request; @property (readonly, retain, nonatomic) OFHTTPRequestReply *reply; #endif /*! * @brief Creates a new, autoreleased HTTP request failed exception. * * @param request The HTTP request which failed * @param reply The reply of the failed HTTP request * @return A new, autoreleased HTTP request failed exception */ + (instancetype)exceptionWithRequest: (OFHTTPRequest*)request reply: (OFHTTPRequestReply*)reply; /*! * @brief Initializes an already allocated HTTP request failed exception. * * @param request The HTTP request which failed * @param reply The reply of the failed HTTP request * @return A new HTTP request failed exception */ - initWithRequest: (OFHTTPRequest*)request reply: (OFHTTPRequestReply*)reply; /*! * @brief Returns the HTTP request which failed. * * @return The HTTP request which failed */ - (OFHTTPRequest*)request; |
| ︙ | ︙ |