Differences From Artifact [a21b81861e]:
- File
src/OFHTTPRequest.m
— part of check-in
[3d16a30f41]
at
2013-06-22 12:12:36
on branch trunk
— Rework exceptions.
This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. (user: js, size: 4743) [annotate] [blame] [check-ins using]
To Artifact [ee350c6f2d]:
- File src/OFHTTPRequest.m — part of check-in [7cb70e45cf] at 2013-08-15 17:39:32 on branch trunk — OFHTTPRequest: Add -[isEqual:] and -[hash]. (user: js, size: 5780) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
72 73 74 75 76 77 78 79 80 81 82 83 84 85 |
[_headers release];
[_POSTData release];
[_MIMEType release];
[_remoteAddress release];
[super dealloc];
}
- (void)setURL: (OFURL*)URL
{
OF_SETTER(_URL, URL, true, 1)
}
- (OFURL*)URL
| > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > | 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 |
[_headers release];
[_POSTData release];
[_MIMEType release];
[_remoteAddress release];
[super dealloc];
}
- (bool)isEqual: (id)object
{
OFHTTPRequest *request;
if (![object isKindOfClass: [OFHTTPRequest class]])
return false;
request = object;
if (request->_requestType != _requestType ||
request->_protocolVersion.major != _protocolVersion.major ||
request->_protocolVersion.minor != _protocolVersion.minor ||
![request->_URL isEqual: _URL] ||
![request->_headers isEqual: _headers] ||
![request->_POSTData isEqual: _POSTData] ||
![request->_MIMEType isEqual: _MIMEType] ||
![request->_remoteAddress isEqual: _remoteAddress])
return false;
return true;
}
- (uint32_t)hash
{
uint32_t hash;
OF_HASH_INIT(hash);
OF_HASH_ADD(hash, _requestType);
OF_HASH_ADD(hash, _protocolVersion.major);
OF_HASH_ADD(hash, _protocolVersion.minor);
OF_HASH_ADD_HASH(hash, [_URL hash]);
OF_HASH_ADD_HASH(hash, [_headers hash]);
OF_HASH_ADD_HASH(hash, [_POSTData hash]);
OF_HASH_ADD_HASH(hash, [_MIMEType hash]);
OF_HASH_ADD_HASH(hash, [_remoteAddress hash]);
OF_HASH_FINALIZE(hash);
return hash;
}
- (void)setURL: (OFURL*)URL
{
OF_SETTER(_URL, URL, true, 1)
}
- (OFURL*)URL
|
| ︙ | ︙ |