Differences From Artifact [a08f06103a]:
- File
src/OFStream.m
— part of check-in
[d16ad96cbd]
at
2018-12-07 01:33:47
on branch trunk
— OFStream: Use a delegate for async operations
The target / selector approach had several drawbacks:
* It was inconvenient to use, as for every read or write, a target,
selector and context would need to be specified.
* It lacked any kind of type-safety and would not even warn about using
a callback method with the wrong number of parameters.
* It encouraged using a different callback method for each read or
write call, which results in code that is hard to follow and also
slower (as it needs to recreate the async operation with a new
callback every time). (user: js, size: 38772) [annotate] [blame] [check-ins using]
To Artifact [4879805b8b]:
- File
src/OFStream.m
— part of check-in
[f218986f51]
at
2018-12-18 14:14:25
on branch trunk
— Use OFData instead of a buffer for async writes
This avoids the entire problem of keeping the buffer alive until the
write finished. (user: js, size: 38513) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
1162 1163 1164 1165 1166 1167 1168 | _writeBufferLength += length; return length; } } #ifdef OF_HAVE_SOCKETS | | < | < | | < | | < | < | | < | | | < | | | < | 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 |
_writeBufferLength += length;
return length;
}
}
#ifdef OF_HAVE_SOCKETS
- (void)asyncWriteData: (OFData *)data
{
[self asyncWriteData: data
runLoopMode: of_run_loop_mode_default];
}
- (void)asyncWriteData: (OFData *)data
runLoopMode: (of_run_loop_mode_t)runLoopMode
{
OFStream <OFReadyForWritingObserving> *stream =
(OFStream <OFReadyForWritingObserving> *)self;
[OFRunLoop of_addAsyncWriteForStream: stream
data: data
mode: runLoopMode
delegate: _delegate];
}
# ifdef OF_HAVE_BLOCKS
- (void)asyncWriteData: (OFData *)data
block: (of_stream_async_write_block_t)block
{
[self asyncWriteData: data
runLoopMode: of_run_loop_mode_default
block: block];
}
- (void)asyncWriteData: (OFData *)data
runLoopMode: (of_run_loop_mode_t)runLoopMode
block: (of_stream_async_write_block_t)block
{
OFStream <OFReadyForWritingObserving> *stream =
(OFStream <OFReadyForWritingObserving> *)self;
[OFRunLoop of_addAsyncWriteForStream: stream
data: data
mode: runLoopMode
block: block];
}
# endif
#endif
- (void)writeInt8: (uint8_t)int8
|
| ︙ | ︙ |