Differences From Artifact [9c145d6316]:
- File src/exceptions/OFAcceptFailedException.h — part of check-in [cfd374b906] at 2015-01-03 20:57:18 on branch trunk — Update copyright (user: js, size: 1812) [annotate] [blame] [check-ins using]
To Artifact [8ed051874b]:
- File
src/exceptions/OFAcceptFailedException.h
— part of check-in
[62e2de30b9]
at
2015-02-16 08:39:17
on branch trunk
— Explicitly pass errno to exceptions
The old behaviour where the exception would access errno directly on
creation of the exception was very fragile. The two main problems with
it were that sometimes it would pick up an errno even though none had
been set and in other cases that when the exception was created errno
had already been overridden.This also greatly increases errno handling on Win32, especially in
conjunction with sockets. It can still be improved further, though. (user: js, size: 1921) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
10 11 12 13 14 15 16 | * * Alternatively, it may be distributed under the terms of the GNU General * Public License, either version 2 or 3, which can be found in the file * LICENSE.GPLv2 or LICENSE.GPLv3 respectively included in the packaging of this * file. */ | < < | 10 11 12 13 14 15 16 17 18 19 20 21 22 23 | * * Alternatively, it may be distributed under the terms of the GNU General * Public License, either version 2 or 3, which can be found in the file * LICENSE.GPLv2 or LICENSE.GPLv3 respectively included in the packaging of this * file. */ #import "OFException.h" #ifndef OF_HAVE_SOCKETS # error No sockets available! #endif /*! |
| ︙ | ︙ | |||
39 40 41 42 43 44 45 46 47 | @property (readonly) int errNo; #endif /*! * @brief Creates a new, autoreleased accept failed exception. * * @param socket The socket which could not accept a connection * @return A new, autoreleased accept failed exception */ | > | > > | > | 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 | @property (readonly) int errNo; #endif /*! * @brief Creates a new, autoreleased accept failed exception. * * @param socket The socket which could not accept a connection * @param errNo The errno for the error * @return A new, autoreleased accept failed exception */ + (instancetype)exceptionWithSocket: (id)socket errNo: (int)errNo; /*! * @brief Initializes an already allocated accept failed exception. * * @param socket The socket which could not accept a connection * @param errNo The errno for the error * @return An initialized accept failed exception */ - initWithSocket: (id)socket errNo: (int)errNo; /*! * @brief Returns the socket which could not accept a connection. * * @return The socket which could not accept a connection */ - (id)socket; |
| ︙ | ︙ |