@@ -1,7 +1,7 @@
 /*
- * Copyright (c) 2008-2021 Jonathan Schleifer <js@nil.im>
+ * Copyright (c) 2008-2022 Jonathan Schleifer <js@nil.im>
  *
  * All rights reserved.
  *
  * This file is part of ObjFW. It may be distributed under the terms of the
  * Q Public License 1.0, which can be found in the file LICENSE.QPL included in
@@ -17,11 +17,11 @@
 
 #include <errno.h>
 
 #import "TestsAppDelegate.h"
 
-static OFString *module = @"OFSPXSocket";
+static OFString *const module = @"OFSPXSocket";
 
 @interface SPXSocketDelegate: OFObject <OFSPXSocketDelegate>
 {
 @public
 	OFSequencedPacketSocket *_expectedServerSocket;
@@ -48,22 +48,22 @@
 		[[OFRunLoop mainRunLoop] stop];
 
 	return false;
 }
 
--     (void)socket: (OFSPXSocket *)sock
-  didConnectToNode: (unsigned char [IPX_NODE_LEN])node
-	   network: (uint32_t)network
-	      port: (uint16_t)port
-	 exception: (id)exception
+-	 (void)socket: (OFSPXSocket *)sock
+  didConnectToNetwork: (uint32_t)network
+		 node: (unsigned char [IPX_NODE_LEN])node
+		 port: (uint16_t)port
+	    exception: (id)exception
 {
 	OFEnsure(!_connected);
 
 	_connected = (sock == _expectedClientSocket &&
+	    network == _expectedNetwork &&
 	    memcmp(node, _expectedNode, IPX_NODE_LEN) == 0 &&
-	    network == _expectedNetwork && port == _expectedPort &&
-	    exception == nil);
+	    port == _expectedPort && exception == nil);
 
 	if (_accepted && _connected)
 		[[OFRunLoop mainRunLoop] stop];
 }
 @end
@@ -70,15 +70,15 @@
 
 @implementation TestsAppDelegate (OFSPXSocketTests)
 - (void)SPXSocketTests
 {
 	void *pool = objc_autoreleasePoolPush();
-	OFSPXSocket *sockClient, *sockServer, *sockAccepted;;
+	OFSPXSocket *sockClient, *sockServer = nil, *sockAccepted;
 	OFSocketAddress address1;
 	const OFSocketAddress *address2;
-	unsigned char node[IPX_NODE_LEN], node2[IPX_NODE_LEN];
 	uint32_t network;
+	unsigned char node[IPX_NODE_LEN], node2[IPX_NODE_LEN];
 	uint16_t port;
 	char buffer[5];
 	SPXSocketDelegate *delegate;
 
 	TEST(@"+[socket]", (sockClient = [OFSPXSocket socket]) &&
@@ -113,18 +113,18 @@
 
 		objc_autoreleasePoolPop(pool);
 		return;
 	}
 
-	OFSocketAddressIPXNode(&address1, node);
 	network = OFSocketAddressIPXNetwork(&address1);
+	OFSocketAddressIPXNode(&address1, node);
 	port = OFSocketAddressPort(&address1);
 
 	TEST(@"-[listen]", R([sockServer listen]))
 
-	TEST(@"-[connectToNode:network:port:]",
-	    R([sockClient connectToNode: node network: network port: port]))
+	TEST(@"-[connectToNetwork:node:port:]",
+	    R([sockClient connectToNetwork: network node: node port: port]))
 
 	TEST(@"-[accept]", (sockAccepted = [sockServer accept]))
 
 	TEST(@"-[sendBuffer:length:]",
 	    R([sockAccepted sendBuffer: "Hello" length: 5]))
@@ -133,13 +133,13 @@
 	    [sockClient receiveIntoBuffer: buffer length: 5] == 5 &&
 	    memcmp(buffer, "Hello", 5) == 0)
 
 	TEST(@"-[remoteAddress]",
 	    (address2 = sockAccepted.remoteAddress) &&
+	    OFSocketAddressIPXNetwork(address2) == network &&
 	    R(OFSocketAddressIPXNode(address2, node2)) &&
-	    memcmp(node, node2, IPX_NODE_LEN) == 0 &&
-	    OFSocketAddressIPXNetwork(address2) == network)
+	    memcmp(node, node2, IPX_NODE_LEN) == 0)
 
 	delegate = [[[SPXSocketDelegate alloc] init] autorelease];
 
 	sockServer = [OFSPXSocket socket];
 	delegate->_expectedServerSocket = sockServer;
@@ -151,33 +151,33 @@
 
 	address1 = [sockServer bindToPort: 0];
 	[sockServer listen];
 	[sockServer asyncAccept];
 
+	delegate->_expectedNetwork = network =
+	    OFSocketAddressIPXNetwork(&address1);
 	OFSocketAddressIPXNode(&address1, node);
 	memcpy(delegate->_expectedNode, node, IPX_NODE_LEN);
-	delegate->_expectedNetwork = network =
-	    OFSocketAddressIPXNetwork(&address1);
 	delegate->_expectedPort = port = OFSocketAddressPort(&address1);
 
 	@try {
-		[sockClient asyncConnectToNode: node
-				       network: network
-					  port: port];
+		[sockClient asyncConnectToNetwork: network
+					     node: node
+					     port: port];
 
 		[[OFRunLoop mainRunLoop] runUntilDate:
 		    [OFDate dateWithTimeIntervalSinceNow: 2]];
 
-		TEST(@"-[asyncAccept] & -[asyncConnectToNode:network:port:]",
+		TEST(@"-[asyncAccept] & -[asyncConnectToNetwork:node:port:]",
 		    delegate->_accepted && delegate->_connected)
 	} @catch (OFObserveFailedException *e) {
 		switch (e.errNo) {
 		case ENOTSOCK:
 			[OFStdOut setForegroundColor: [OFColor lime]];
 			[OFStdOut writeLine:
 			    @"\r[OFSPXSocket] -[asyncAccept] & "
-			    @"-[asyncConnectToNode:network:port:]: select() "
+			    @"-[asyncConnectToNetwork:node:port:]: select() "
 			    @"not supported for SPX, skipping test"];
 			break;
 		default:
 			@throw e;
 		}