Differences From Artifact [850e9c668c]:
- File src/exceptions/OFOpenItemFailedException.m — part of check-in [cc5923d6bb] at 2017-06-04 23:41:38 on branch trunk — Add designated initializer to all exceptions (user: js, size: 2758) [annotate] [blame] [check-ins using]
To Artifact [649447f7ba]:
- File
src/exceptions/OFOpenItemFailedException.m
— part of check-in
[4f36894ce7]
at
2017-06-05 17:36:28
on branch trunk
— Clean up exceptions a little
This removes several initializers that omitted the errNo. Removing those
forces to think about whether there is a meaningful errNo to set instead
of just omitting it. (user: js, size: 1683) [annotate] [blame] [check-ins using]
︙ | ︙ | |||
23 24 25 26 27 28 29 | @synthesize path = _path, mode = _mode, errNo = _errNo; + (instancetype)exception { OF_UNRECOGNIZED_SELECTOR } | < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < | 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 | @synthesize path = _path, mode = _mode, errNo = _errNo; + (instancetype)exception { OF_UNRECOGNIZED_SELECTOR } + (instancetype)exceptionWithPath: (OFString *)path mode: (OFString *)mode errNo: (int)errNo { return [[[self alloc] initWithPath: path mode: mode errNo: errNo] autorelease]; } - init { OF_INVALID_INIT_METHOD } - initWithPath: (OFString *)path mode: (OFString *)mode errNo: (int)errNo { self = [super init]; @try { |
︙ | ︙ | |||
107 108 109 110 111 112 113 | [_mode release]; [super dealloc]; } - (OFString *)description { | | < | | | | | < < < < < | < < < < | < | 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 | [_mode release]; [super dealloc]; } - (OFString *)description { if (_mode != nil) return [OFString stringWithFormat: @"Failed to open item %@ with mode %@: %@", _path, _mode, of_strerror(_errNo)]; else return [OFString stringWithFormat: @"Failed to open item %@: %@", _path, of_strerror(_errNo)]; } @end |