Differences From Artifact [61b9685104]:
- File
src/exceptions/OFConnectionFailedException.h
— part of check-in
[62e2de30b9]
at
2015-02-16 08:39:17
on branch trunk
— Explicitly pass errno to exceptions
The old behaviour where the exception would access errno directly on
creation of the exception was very fragile. The two main problems with
it were that sometimes it would pick up an errno even though none had
been set and in other cases that when the exception was created errno
had already been overridden.This also greatly increases errno handling on Win32, especially in
conjunction with sockets. It can still be improved further, though. (user: js, size: 3481) [annotate] [blame] [check-ins using]
To Artifact [60f2feca02]:
- File src/exceptions/OFConnectionFailedException.h — part of check-in [efc6b07e2c] at 2015-04-11 11:04:48 on branch trunk — Documentation improvements (user: js, size: 3491) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
55 56 57 58 59 60 61 | /*! * @brief Creates a new, autoreleased connection failed exception. * * @param host The host to which the connection failed * @param port The port on the host to which the connection failed * @param socket The socket which could not connect | | | 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 | /*! * @brief Creates a new, autoreleased connection failed exception. * * @param host The host to which the connection failed * @param port The port on the host to which the connection failed * @param socket The socket which could not connect * @param errNo The errno of the error that occurred * @return A new, autoreleased connection failed exception */ + (instancetype)exceptionWithHost: (OFString*)host port: (uint16_t)port socket: (id)socket errNo: (int)errNo; |
| ︙ | ︙ | |||
81 82 83 84 85 86 87 | /*! * @brief Initializes an already allocated connection failed exception. * * @param host The host to which the connection failed * @param port The port on the host to which the connection failed * @param socket The socket which could not connect | | | 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 | /*! * @brief Initializes an already allocated connection failed exception. * * @param host The host to which the connection failed * @param port The port on the host to which the connection failed * @param socket The socket which could not connect * @param errNo The errno of the error that occurred * @return An initialized connection failed exception */ - initWithHost: (OFString*)host port: (uint16_t)port socket: (id)socket errNo: (int)errNo; |
| ︙ | ︙ | |||
111 112 113 114 115 116 117 | * @brief Returns the port on the host to which the connection failed. * * @return The port on the host to which the connection failed */ - (uint16_t)port; /*! | | | | 111 112 113 114 115 116 117 118 119 120 121 122 123 | * @brief Returns the port on the host to which the connection failed. * * @return The port on the host to which the connection failed */ - (uint16_t)port; /*! * @brief Returns the errno of the error that occurred. * * @return The errno of the error that occurred */ - (int)errNo; @end |