Differences From Artifact [3ad5dffb1b]:
- File
src/OFKernelEventObserver_kqueue.m
— part of check-in
[e9b4700cb6]
at
2015-12-29 21:33:07
on branch trunk
— Refactor OFKernelEventObserver
This moves the locked queue for actions to
OFKernelEventObserver_LockedQueue, which is now used for select and
poll, but skipped for kqueue and epoll, as they natively support changes
from another thread.This fixes the problem that removing an object is delayed until the next
observe call - at which point it might have already been closed, meaning
the fd is no longer available. This was mainly a problem with kqueue, as
closing the fd already removed it from the kqueue, which then resulted
in an error being returned when trying to manually remove the fd from
the kqueue. (user: js, size: 5123) [annotate] [blame] [check-ins using]
To Artifact [8f67672c8e]:
- File
src/OFKernelEventObserver_kqueue.m
— part of check-in
[258b8a4944]
at
2016-01-03 00:35:01
on branch trunk
— Fix a regression from the previous refactorization
kqueue and epoll were not updating _readObjects and _writeObjects
anymore, since this was done by the queue handling code, which they no
longer use after the refactorization. (user: js, size: 5963) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
28 29 30 31 32 33 34 35 36 37 38 39 40 41 | #include <sys/time.h> #import "OFKernelEventObserver.h" #import "OFKernelEventObserver+Private.h" #import "OFKernelEventObserver_kqueue.h" #import "OFDataArray.h" #import "OFArray.h" #import "OFInitializationFailedException.h" #import "OFObserveFailedException.h" #import "OFOutOfRangeException.h" #define EVENTLIST_SIZE 64 | > > > | 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 | #include <sys/time.h> #import "OFKernelEventObserver.h" #import "OFKernelEventObserver+Private.h" #import "OFKernelEventObserver_kqueue.h" #import "OFDataArray.h" #import "OFArray.h" #ifdef OF_HAVE_THREADS # import "OFMutex.h" #endif #import "OFInitializationFailedException.h" #import "OFObserveFailedException.h" #import "OFOutOfRangeException.h" #define EVENTLIST_SIZE 64 |
| ︙ | ︙ | |||
92 93 94 95 96 97 98 | event.flags = EV_ADD; #ifndef OF_NETBSD event.udata = object; #else event.udata = (intptr_t)object; #endif | > > > > > > | > | | | > > > > > > > > > > > > | > | | | > > > > > > > > > > | | | | > > > > > > > > > > > | | | | > > > > > > > | 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 |
event.flags = EV_ADD;
#ifndef OF_NETBSD
event.udata = object;
#else
event.udata = (intptr_t)object;
#endif
#ifdef OF_HAVE_THREADS
[_mutex lock];
@try {
#endif
[_readObjects addObject: object];
if (kevent(_kernelQueue, &event, 1, NULL, 0, NULL) != 0) {
[_readObjects removeObjectIdenticalTo: object];
@throw [OFObserveFailedException
exceptionWithObserver: self
errNo: errno];
}
#ifdef OF_HAVE_THREADS
} @finally {
[_mutex unlock];
}
#endif
}
- (void)addObjectForWriting: (id <OFReadyForWritingObserving>)object
{
struct kevent event;
memset(&event, 0, sizeof(event));
event.ident = [object fileDescriptorForWriting];
event.filter = EVFILT_WRITE;
event.flags = EV_ADD;
#ifndef OF_NETBSD
event.udata = object;
#else
event.udata = (intptr_t)object;
#endif
#ifdef OF_HAVE_THREADS
[_mutex lock];
@try {
#endif
[_writeObjects addObject: object];
if (kevent(_kernelQueue, &event, 1, NULL, 0, NULL) != 0) {
[_writeObjects removeObjectIdenticalTo: object];
@throw [OFObserveFailedException
exceptionWithObserver: self
errNo: errno];
}
#ifdef OF_HAVE_THREADS
} @finally {
[_mutex unlock];
}
#endif
}
- (void)removeObjectForReading: (id <OFReadyForReadingObserving>)object
{
struct kevent event;
memset(&event, 0, sizeof(event));
event.ident = [object fileDescriptorForReading];
event.filter = EVFILT_READ;
event.flags = EV_DELETE;
#ifdef OF_HAVE_THREADS
[_mutex lock];
@try {
#endif
if (kevent(_kernelQueue, &event, 1, NULL, 0, NULL) != 0)
@throw [OFObserveFailedException
exceptionWithObserver: self
errNo: errno];
[_readObjects removeObjectIdenticalTo: object];
#ifdef OF_HAVE_THREADS
} @finally {
[_mutex unlock];
}
#endif
}
- (void)removeObjectForWriting: (id <OFReadyForWritingObserving>)object
{
struct kevent event;
memset(&event, 0, sizeof(event));
event.ident = [object fileDescriptorForWriting];
event.filter = EVFILT_WRITE;
event.flags = EV_DELETE;
#ifdef OF_HAVE_THREADS
[_mutex lock];
@try {
#endif
if (kevent(_kernelQueue, &event, 1, NULL, 0, NULL) != 0)
@throw [OFObserveFailedException
exceptionWithObserver: self
errNo: errno];
[_writeObjects removeObjectIdenticalTo: object];
#ifdef OF_HAVE_THREADS
} @finally {
[_mutex unlock];
}
#endif
}
- (void)observeForTimeInterval: (of_time_interval_t)timeInterval
{
void *pool = objc_autoreleasePoolPush();
struct timespec timeout;
struct kevent eventList[EVENTLIST_SIZE];
|
| ︙ | ︙ |