Differences From Artifact [231337000a]:
- File src/exceptions/OFReadOrWriteFailedException.m — part of check-in [cfd374b906] at 2015-01-03 20:57:18 on branch trunk — Update copyright (user: js, size: 1879) [annotate] [blame] [check-ins using]
To Artifact [545888cf6f]:
- File
src/exceptions/OFReadOrWriteFailedException.m
— part of check-in
[62e2de30b9]
at
2015-02-16 08:39:17
on branch trunk
— Explicitly pass errno to exceptions
The old behaviour where the exception would access errno directly on
creation of the exception was very fragile. The two main problems with
it were that sometimes it would pick up an errno even though none had
been set and in other cases that when the exception was created errno
had already been overridden.This also greatly increases errno handling on Win32, especially in
conjunction with sockets. It can still be improved further, though. (user: js, size: 2200) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
14 15 16 17 18 19 20 | * file. */ #include "config.h" #import "OFReadOrWriteFailedException.h" #import "OFString.h" | < < < < < < > > > > > > > > > | > | | > | > | | > > | > | | > > > > > > | < < < < | 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 |
* file.
*/
#include "config.h"
#import "OFReadOrWriteFailedException.h"
#import "OFString.h"
@implementation OFReadOrWriteFailedException
+ (instancetype)exceptionWithObject: (id)object
requestedLength: (size_t)requestedLength
{
return [[[self alloc] initWithObject: object
requestedLength: requestedLength] autorelease];
}
+ (instancetype)exceptionWithObject: (id)object
requestedLength: (size_t)requestedLength
errNo: (int)errNo
{
return [[[self alloc] initWithObject: object
requestedLength: requestedLength
errNo: errNo] autorelease];
}
- init
{
OF_INVALID_INIT_METHOD
}
- initWithObject: (id)object
requestedLength: (size_t)requestedLength
{
self = [super init];
_object = [object retain];
_requestedLength = requestedLength;
return self;
}
- initWithObject: (id)object
requestedLength: (size_t)requestedLength
errNo: (int)errNo
{
self = [super init];
_object = [object retain];
_requestedLength = requestedLength;
_errNo = errNo;
return self;
}
- (void)dealloc
{
[_object release];
[super dealloc];
}
- (OFString*)description
{
if (_errNo != 0)
return [OFString stringWithFormat:
@"Failed to read or write %zu bytes from / to an object of "
@"type %@: %@",
_requestedLength, [_object class], of_strerror(_errNo)];
else
return [OFString stringWithFormat:
@"Failed to read or write %zu bytes from / to an object of "
@"type %@!",
_requestedLength, [_object class]];
}
- (id)object
{
OF_GETTER(_object, true)
}
- (size_t)requestedLength
{
return _requestedLength;
}
- (int)errNo
{
return _errNo;
}
@end
|