Differences From Artifact [2191f51302]:
- File
src/exceptions/OFAddressTranslationFailedException.m
— part of check-in
[c5ef582958]
at
2013-03-04 17:20:15
on branch trunk
— Replace BOOL with bool.
The only places where BOOL is left are those where they are required by
the ABI. (user: js, size: 2134) [annotate] [blame] [check-ins using]
To Artifact [d737be39ca]:
- File
src/exceptions/OFAddressTranslationFailedException.m
— part of check-in
[3d16a30f41]
at
2013-06-22 12:12:36
on branch trunk
— Rework exceptions.
This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. (user: js, size: 2441) [annotate] [blame] [check-ins using]
︙ | ︙ | |||
19 20 21 22 23 24 25 | #import "OFAddressTranslationFailedException.h" #import "OFString.h" #import "OFTCPSocket.h" #import "common.h" @implementation OFAddressTranslationFailedException | > > > > > | | < | | > > > > > > > | > | > > | > | > > | > > > > | | < | < > | | | | | | | > > | | > > > > > < < < < < | 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 | #import "OFAddressTranslationFailedException.h" #import "OFString.h" #import "OFTCPSocket.h" #import "common.h" @implementation OFAddressTranslationFailedException + (instancetype)exceptionWithSocket: (OFTCPSocket*)socket { return [[[self alloc] initWithSocket: socket] autorelease]; } + (instancetype)exceptionWithHost: (OFString*)host socket: (OFTCPSocket*)socket { return [[[self alloc] initWithHost: host socket: socket] autorelease]; } - init { @try { [self doesNotRecognizeSelector: _cmd]; } @catch (id e) { [self release]; @throw e; } abort(); } - initWithSocket: (OFTCPSocket*)socket { self = [super init]; @try { _socket = [socket retain]; _errNo = GET_AT_ERRNO; } @catch (id e) { [self release]; @throw e; } return self; } - initWithHost: (OFString*)host socket: (OFTCPSocket*)socket { self = [super init]; @try { _host = [host copy]; _socket = [socket retain]; _errNo = GET_AT_ERRNO; } @catch (id e) { [self release]; @throw e; } return self; } - (void)dealloc { [_host release]; [_socket release]; [super dealloc]; } - (OFString*)description { if (_host != nil) return [OFString stringWithFormat: @"The host %@ could not be translated to an address for a " @"socket of type %@. This means that either the host was " @"not found, there was a problem with the name server, " @"there was a problem with your network connection or you " @"specified an invalid host. " ERRFMT, _host, [_socket class], AT_ERRPARAM]; else return [OFString stringWithFormat: @"An address could not be translated translation for a " @"socket of type %@! " ERRFMT, [_socket class], AT_ERRPARAM]; } - (OFString*)host { OF_GETTER(_host, false) } - (OFTCPSocket*)socket { OF_GETTER(_socket, false) } - (int)errNo { return _errNo; } @end |