ObjFW: Diff

Differences From Artifact [1f70933951]:

File src/OFXMLElement.m — part of check-in [48980f2297] at 2015-11-29 11:43:05 on branch trunk — Make properties a requirement and clean up code
This increases the required GCC version from 4.0 to 4.6 (exception:
Apple GCC, which already supports this with >= 4.0 starting with OS X
10.5). Since even GCC 4.6 is really old by now, there is no point in
still supporting something even older and making the code ugly because
of that. While some hardware and OS support was dropped from GCC 4.6
compared to GCC 4.0, there is nothing in there that would be an
interesting target with the exception of BeOS maybe - but a port to BeOS
can also be achieved using the Haiku support. The other dropped OSes are
mostly old versions of OSes while newer ones are still being supported
(and those newer versions of those OSes still support the same
hardware). (user: js, size: 27300) [annotate] [blame] [check-ins using]

To Artifact [767015e338]:

File src/OFXMLElement.m — part of check-in [6b13727ce0] at 2015-11-29 14:02:11 on branch trunk — Make use of fast enumeration
Now that we require GCC >= 4.6 anyway, there's no more reason to not use
it anymore. (user: js, size: 26973) [annotate] [blame] [check-ins using]

︙
317 318 319 320 321 322 323 ~~324~~ ~~325~~ 326 327 328 329 330 331 332 333 334 335 336 ~~337~~ ~~338~~ 339 340 341 342 343 344 345	317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343	- + - - + -	if ((_attributes != nil && ![_attributes isKindOfClass: [OFMutableArray class]]) \|\| (_namespaces != nil && ![_namespaces isKindOfClass: [OFMutableDictionary class]]) \|\| (_children != nil && ![_children isKindOfClass: [OFMutableArray class]])) @throw [OFInvalidArgumentException exception]; ~~object~~Enumerator = [~~_attributes ~~objectEnumerator];~~~~ for (object in _attributes) ~~while ((object = [objectEnumerator nextObject]) != nil)~~ if (![object isKindOfClass: [OFXMLAttribute class]]) @throw [OFInvalidArgumentException exception]; keyEnumerator = [_namespaces keyEnumerator]; objectEnumerator = [_namespaces objectEnumerator]; while ((key = [keyEnumerator nextObject]) != nil && (object = [objectEnumerator nextObject]) != nil) if (![key isKindOfClass: [OFString class]] \|\| ![object isKindOfClass: [OFString class]]) @throw [OFInvalidArgumentException exception]; ~~object~~Enumerator = [~~_children ~~objectEnumerator];~~~~ for (object in _children) ~~while ((object = [objectEnumerator nextObject]) != nil)~~ if (![object isKindOfClass: [OFXMLNode class]]) @throw [OFInvalidArgumentException exception]; if (_namespaces == nil) _namespaces = [[OFMutableDictionary alloc] init]; [_namespaces
︙
916 917 918 919 920 921 922 ~~923 924 925~~ ~~926 927~~ 928 929 930 931 932 ~~933 934~~ 935 936 937 938 939 940 941	914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933	- - - + - - - -	[_children insertObject: child atIndex: index]; } - (void)insertChildren: (OFArray)children atIndex: (size_t)index { ~~~~void pool = objc_autoreleasePoolPush();~~ ~~OFEnumerator enumerator = [children objectEnumerator];~~ OFXMLNode node;~~ for (OFXMLNode node in children) ~~while ((node = [enumerator nextObject]) != nil)~~ if ([node isKindOfClass: [OFXMLAttribute class]]) @throw [OFInvalidArgumentException exception]; [_children insertObjectsFromArray: children atIndex: index]; ~~objc_autoreleasePoolPop(pool);~~ } - (void)removeChild: (OFXMLNode)child { if ([child isKindOfClass: [OFXMLAttribute class]]) @throw [OFInvalidArgumentException exception];
︙

ObjFW Diff

Differences From Artifact [1f70933951]:

To Artifact [767015e338]: