Differences From Artifact [08e07c93e0]:
- File src/exceptions/OFBindFailedException.h — part of check-in [590c377d8a] at 2013-04-26 19:42:52 on branch trunk — Make it possible to disable sockets. (user: js, size: 2578) [annotate] [blame] [check-ins using]
To Artifact [8e4f2bb116]:
- File
src/exceptions/OFBindFailedException.h
— part of check-in
[3d16a30f41]
at
2013-06-22 12:12:36
on branch trunk
— Rework exceptions.
This mostly removes the argument for the class in which the exception
occurred. As backtraces were recently added for all platforms, the
passed class does not give any extra information on where the exception
occurred anymore.This also removes a few other arguments which were not too helpful. In
the past, the idea was to pass as many arguments as possible so that it
is easier to find the origin of the exception. However, as backtraces
are a much better way to find the origin, those are not useful anymore
and just make the exception more cumbersome to use. The rule is now to
only pass arguments that might help in recovering from the exception or
provide information that is otherwise not easily accessible. (user: js, size: 2383) [annotate] [blame] [check-ins using]
︙ | ︙ | |||
30 31 32 33 34 35 36 | OFTCPSocket *_socket; OFString *_host; uint16_t _port; int _errNo; } #ifdef OF_HAVE_PROPERTIES | < > < < > | < < | > < < > < < | | < < < < < < | > > > > > > > | 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 | OFTCPSocket *_socket; OFString *_host; uint16_t _port; int _errNo; } #ifdef OF_HAVE_PROPERTIES @property (readonly, copy, nonatomic) OFString *host; @property (readonly) uint16_t port; @property (readonly, retain, nonatomic) OFTCPSocket *socket; @property (readonly) int errNo; #endif /*! * @brief Creates a new, autoreleased bind failed exception. * * @param host The host on which binding failed * @param port The port on which binding failed * @param socket The socket which could not be bound * @return A new, autoreleased bind failed exception */ + (instancetype)exceptionWithHost: (OFString*)host port: (uint16_t)port socket: (OFTCPSocket*)socket; /*! * @brief Initializes an already allocated bind failed exception. * * @param host The host on which binding failed * @param port The port on which binding failed * @param socket The socket which could not be bound * @return An initialized bind failed exception */ - initWithHost: (OFString*)host port: (uint16_t)port socket: (OFTCPSocket*)socket; /*! * @brief Returns the host on which binding failed. * * @return The host on which binding failed */ - (OFString*)host; /*! * @brief Return the port on which binding failed. * * @return The port on which binding failed */ - (uint16_t)port; /*! * @brief Returns the socket which could not be bound. * * @return The socket which could not be bound */ - (OFTCPSocket*)socket; /*! * @brief Returns the errno from when the exception was created. * * @return The errno from when the exception was created */ - (int)errNo; @end |